- Jan 22, 2019
-
-
GetProcessId() is currently only implemented for Win32, Linux and OS X. This commit adds wider support for it by extending the definitions in the function to also cover BSD platforms, which implement this function.
-
7a5e5af8 SystemTools: Revert "Fix FileIsSymlink with Windows data deduplication" Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !120
-
Brad King authored
This reverts commit ef373416 (SystemTools: Fix FileIsSymlink with Windows data deduplication, 2019-01-18). It regressed `FileIsSymlink` such that it does not always recognize broken symlinks as symlinks. Revert pending further investigation. Notes for re-introduction: * We need to add a test to cover the case that broke. * We should save the Encoding::ToWindowsExtendedPath result and use it for both GetFileAttributesW and CreateFileW instead of using Encoding::ToWide for the latter.
-
- Jan 21, 2019
-
-
ef373416 SystemTools: Fix FileIsSymlink with Windows data deduplication Acked-by:
-
- Jan 18, 2019
-
-
On Windows machines with enabled data deduplication files duplicates are incorrectly recognized as symlinks and therefore install fails with "file COPY cannot read symlink". Similar issues can be found here: * https://github.com/Microsoft/vcpkg/issues/2488 * https://github.com/puppetlabs/puppet/pull/6513 From the later fix this commit is mainly influenced.
-
- Jan 14, 2019
-
-
f44cbf93 Fixed clang -Wextra-semi-stmt warnings Acked-by:
-
- Jan 11, 2019
-
-
Sean McBride authored
-
- Dec 12, 2018
-
-
228c60b8 SystemTools: CopyFileAlways: try to create a cheap CoW clone first Acked-by:
-
- Dec 11, 2018
-
-
Gregor Jasny authored
-
- Nov 28, 2018
-
-
4f9fb9aa SystemTools: Fix Touch to avoid requiring file ownership Acked-by:
-
SystemTools::Touch should only require +w file permissions. The previous implementation used `stat` to get the current time, and then passed that time to one of utimensat/utimes/utime. However, utimes/utimensat only permit an arbitrary-time argument to be passed by the file owner. Therefore, per the docs, we pass NULL for the `times` argument to utimes and utimensat, to indicate using the current time. This is permitted for any UID with +w on the file. Remove plain `utime` fallback that is no longer necessary.
-
- Oct 25, 2018
-
-
993be8b6 Set CMake Policy CMP0069 to NEW within KWSys Acked-by:
-
- Oct 24, 2018
-
-
Add LTO flags when `INTERPROCEDURAL_OPTIMIZATION` is enabled.
-
- Oct 19, 2018
-
-
162b3ed7 SystemInformation: Fix compilation on GNU/{kFreeBSD,Hurd} Acked-by:
-
- Oct 18, 2018
-
-
Includes of `cxxabi.h`, `execinfo.h`, etc. were guarded more restrictively (e.g. additionally by `__linux`) than the code which needs them (just by e.g. `KWSYS_SYSTEMINFORMATION_HAS_CPP_DEMANGLE`). kFreeGNU has some of these headers so extend the `__linux` ifdef to `kFreeBSD` and `Hurd` as well. Ideally the code should be fixed to have the same level of ifdef protection for both include and use of these APIs, but this is good enough for now pending further investigation.
-
- Oct 05, 2018
-
-
a5caf8a4 cmake: support an alias target Acked-by:
-
- Oct 04, 2018
-
-
Ben Boeckel authoredVTK's new module system expects alias targets for each actual target. Support creating such an alias target.
-
- Oct 03, 2018
-
-
f17f22a2 Terminal: Add alacritty and alacritty-direct to VT100 color support whitelist Acked-by:
-
- Oct 02, 2018
-
-
- Sep 14, 2018
-
-
bdd39241 Process: On Windows do not open stdin file with write permission Acked-by:
-
- Sep 12, 2018
-
-
The fix in commit ed7f53e0 (BUG: When handing the child stdin pipe a file, allow another process to be writing to the file at the same time, 2006-07-17) added `GENERIC_WRITE` but since we do not actually need to write to the file, only `FILE_SHARE_WRITE` is enough to allow others to do so. Remove the request for write permission. Issue: cmake/cmake#18359
-
- Sep 11, 2018
-
-
ab0d44c9 SystemTools::Split: use str.find_first_of(char) b5b294c1 SystemTools::Split: fix copy-pasta comments Acked-by:
-
- Sep 07, 2018
-
-
Ben Boeckel authored
-
Ben Boeckel authored
-
- Aug 07, 2018
-
-
55a29eba SystemTools: Allow FileExists on Windows to follow symlinks Acked-by:
-
- Aug 01, 2018
-
-
Jon Chronopoulos authored
This makes FileExists consistent across Unix and Windows.
-
- Jul 12, 2018
-
-
2cbf13d2 Terminal: Add support for z/OS terminal Acked-by:
-
- Jul 10, 2018
-
-
Devin Nakamura authored
the z/OS terminal understands standard vt100 escape codes, however since the system uses EBCDIC, the escape character has a different encoding.
-
aebe4597 XL: Restore suppression of infinite loop warning in process test Acked-by:
-
- Jul 09, 2018
-
-
Brad King authored
Our use of the `-qsuppress=` flag to suppress this warning was removed by commit 51e95ba7 (XL: Fix compatibility with newer clang-based XL on Linux, 2017-04-28) because XL 13.1.[1-6] for Linux does not support the flag. XL 16.1 restores support for the flag. Restore our use of it for this version. Suppress the warning on intermediate versions by blocking all warnings with `-w`.
-
- Jun 22, 2018
-
-
5d6f59fe SystemTools: Change SplitString return type to use std::string Acked-by:
-
- Jun 21, 2018
-
-
Brad King authored
Avoid using our custom KWSys String type in interfaces.
-
- Jun 14, 2018
-
-
61501133 SystemInformation: Avoid use of dangling pointers on Solaris Acked-by:
-
- Jun 13, 2018
-
-
`ParseValueFromKStat` was constructing local `std::string` instances in a loop and passing their `.c_str()` to `RunProcess` after destruction. Preserve the strings in a vector to avoid dangling pointers. While at it, simplify some logic by using standard algorithms.
-
- Jun 12, 2018
-
-
361e54e3 Get rid of redundant string initialization 0b9f51a1 Remove redundant calls to c_str Acked-by:
-
- Jun 09, 2018
-
-
Marian Klymov authored
-
Marian Klymov authored
-
- Jun 01, 2018
-
-
828b6837 Revise C++ coding style using clang-format-6.0 b7a341cf Empty commit at end of history preceding clang-format-6.0 style transition 6b9c233c clang-format.bash: update to clang-format-6.0 Acked-by:
-
- May 31, 2018
-
-
Run the `clang-format.bash` script to update all our C and C++ code to a new style defined by `.clang-format`. Use `clang-format` version 6.0. * If you reached this commit for a line in `git blame`, re-run the blame operation starting at the parent of this commit to see older history for the content. * See the parent commit for instructions to rebase a change across this style transition commit.
-
Brad King authored
This is an empty commit that precedes an automatic application of clang-format-6.0 to update the C++ style of our entire source tree. This may be helpful to rebase a topic branch that was originally based on a commit preceding the transition. One may first rebase the topic on this commit. Then use one of the following approaches. * Rewrite the topic, including this commit, using `git filter-branch` `--tree-filter` with `clang-format.bash` to update the style in every commit. Rebase the revised topic, excluding the rewrite of this commit, on the style transition commit. OR * Add a `.git/info/grafts` entry to change the parent of the first commit in the topic from this commit to the style transition commit. Rewrite the topic using `git filter-branch --tree-filter` with `clang-format.bash` to update the style in every commit. Then remove the graft, which was resolved by the filter. See `git help filter-branch` and `git help repository-layout` for details.
-
