- May 18, 2018
-
-
898dc6b9 SystemTools: Fix GetLineFromStream to avoid libc++ bug on OS X 10.7 Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !100
-
LLVM libc++ as included with Mac OS X 10.7 suffers from an issue where the trailing character is discarded when the delimiter (LF) is not found within the given buffer size (1024). The returned length is also 1024 rather than 1023. This issue results in truncated reads as observed with CMake 3.11.0 on Mac OS X 10.7 and `cmake -E cmake_link_script link.txt`. Solve this by replacing `istream::getline` by `std::getline` which does not trigger the buffering issue. There is one edge case that I decided to leave up to the callers though: a file containing `\0` previously resulted in line truncation, but is now included in the result. Tested with Mac OS X 10.7 and 10.11: -DCMAKE_OSX_DEPLOYMENT_TARGET=10.7 -DCMAKE_CXX_FLAGS=-stdlib=libc++ and `./kwsysTestsCxx testSystemTools`. Issue: cmake/cmake#15039
-
- May 15, 2018
-
-
d06fcab7 SystemTools: Check source directory in CopyADirectory Acked-by:
-
- May 12, 2018
-
-
Marian Klymov authored
-
- May 11, 2018
-
-
0e14a1a6 Misc. typos and whitespace fixes Acked-by:
-
- May 09, 2018
-
-
luz.paz authored
Found via `codespell`
-
- Apr 24, 2018
-
-
e5733515 Fix recent regression in installation of namelink Acked-by:
-
Kyle Edwards authored
The check for whether or not to install a namelink depends on KWSYS_BUILD_SHARED, but this variable wasn't being set until later in CMakeLists.txt, causing the namelink to not be installed if KWSYS_BUILD_SHARED is not explicitly set. Fix this by moving the variable assignment closer to the top of the file.
-
- Apr 23, 2018
-
-
5b8bf75b INSTALL: move namelink into development component Acked-by:
-
- Apr 19, 2018
-
-
Kyle Edwards authored
Namelinks are used by the compiler when compiling a program that uses a library, so they should be part of the development component.
-
- Apr 12, 2018
-
-
c7ef6c1b SystemInformation: Do not include unnecessary fenv.h Acked-by:
-
- Apr 11, 2018
-
-
Brad King authored
We do not use any symbols from this header. The `FPE_` macros that we use are defined by signal headers.
-
- Mar 29, 2018
-
-
805d9a7c Terminal: Add xterm-kitty to VT100 color support whitelist Acked-by:
-
- Mar 28, 2018
-
-
Brad King authored
-
- Mar 09, 2018
-
-
94484960 Source typo fix s/[Pp]athes/[Pp]aths/ Acked-by:
-
a3caaeec SystemTools: faster relative path codepath Acked-by:
-
- Mar 08, 2018
-
-
Ben Boeckel authored
-
- Mar 07, 2018
-
-
luz.paz authored
Found via `codespell` and `grep`
-
a241fd13 SystemTools: Remove caching from public GetActualCaseForPath 0a0974d0 SystemTools: Restore unconditional caching in GetActualCaseForPath Acked-by:
Ben Boeckel <ben.boeckel@kitware.com> Acked-by:
Clinton Stimpson <clinton@elemtech.com> Merge-request: !92
-
- Mar 06, 2018
-
-
Brad King authored
Do not expose caching to `GetActualCaseForPath` callers. Cache path case conversion results internally for `CollapseFullPath` only.
-
-
- Feb 22, 2018
-
-
6d4e9fde SystemInformation: Android has no getifaddrs prior to API 24 Acked-by:
-
- Feb 21, 2018
-
-
Brad King authored
-
- Feb 20, 2018
-
-
6e190d9a Fix include directory usage requirement for build tree Acked-by:
-
Brad King authored
The include directory usage requirement for the build tree was added by commit 993f0ea4 (Add an option to split object and interface libs, 2017-06-19) and preserved by commit b61faf89 (Fix install rules and usage requirements for interface+object libs, 2017-06-28). However, its value should be that of `KWSYS_HEADER_ROOT` rather than just its default.
-
- Feb 01, 2018
-
-
318550c7 CheckCollapsePath: add more test cases 71a6de42 CollapseFullPath: refactor the overloads to share implementations 68807138 CollapseFullPath: prefer .empty() to .length() == 0 55d1d6ab CollapseFullPath: reserve space for components 3b46b7c0 ConvertToUnixSlashes: bail early on empty paths 5dd87350 ConvertToUnixSlashes: remove pos1 342d69a4 ConvertToUnixSlashes: short-circuit on hasDoubleSlash 22b189b0 ConvertToUnixSlashes: remove escaped space logic ... Acked-by:
-
- Jan 31, 2018
-
-
-
-
-
The number of input components is a good hint for the number of output components.
-
-
Instead of using two pointers to iterate through the string, iterate using just one.
-
Checking the bool is faster than checking characters, so perform it first.
-
The function only works on paths which are already properly escaped.
-
Non-Windows platforms don't have backslash as a separator, however some projects may want to support Windows paths on non-Windows platforms (e.g., paths from data files). For those which don't need this, this allows the search to be faster since it's searching for a single character.
-
This avoids a `strlen` call at least.
-
All callers of this function use temporary storage for the input. Instead of copying strings, move them.
-
- Jan 23, 2018
-
-
c6829e4d Fixed a few comments, mostly regarding base 2 vs base 10 sizes Acked-by:
-
- Jan 19, 2018
-
-
Sean McBride authored
-
20c458d0 Set CMP0022 policy to new to provide link interface definitions Acked-by:
-
