Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S Slicer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Sam Horvath
  • Slicer
  • Merge requests
  • !962

COMP: Fix "was hidden" warning -Woverloaded-virtual

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed phcerdan requested to merge github/fork/phcerdan/4566-fix-Woverloaded-vtkITKImageThreshold into master May 29, 2018
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Update() function in derived class was hiding methods from base class: Update(foo), Update(foo, bar), etc.

This is because the way cpp lookup works, more info: https://stackoverflow.com/questions/6727087/c-virtual-function-being-hidden

vtkAlgorithm.h warning: ‘virtual void vtkAlgorithm::Update(int)’ was hidden [-Woverloaded-virtual]

vtkAlgorithm.h:569:15: warning: ‘virtual int vtkAlgorithm::Update(vtkInformation*)’ was hidden [-Woverloaded-virtual]
   virtual int Update(vtkInformation* requests);
               ^~~~~~
vtkITKImageThresholdCalculator.h:80:8: warning:   by ‘virtual void vtkITKImageThresholdCalculator::Update()’ [-Woverloaded-virtual]
   void Update() VTK_OVERRIDE;
        ^~~~~~
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/phcerdan/4566-fix-Woverloaded-vtkITKImageThreshold