Skip to content

ENH: Extension buildsystem: Remove custom (Experimental|Nightly)Upload targets

Sam Horvath requested to merge github/fork/jcfr/extension-build-systemremove-experimental-upload-targets into master

Created by: jcfr

This commit simplifies the extension build system removing targets made obsolete by adding support for the "packageupload" target in r24289 (BUG: Update extension build system to report packaging error on CDash.)

This means that the Extensions FAQ will be updated to remove references to ExperimentalUpload and NightlyUpload

Remaining reference to ExperimentalUploadOnly will also be removed. They became irrelevant after r24289

Tests now pass:

$ ctest -R "extension"
Test project /home/jcfr/Projects/Slicer-2-build/Slicer-build
    Start  3: cmake_slicer_extension_description_spec_defaults_test
1/8 Test  #3: cmake_slicer_extension_description_spec_defaults_test ...............   Passed    0.01 sec
    Start  4: cmake_slicer_extension_metadata_set_defaults_test
2/8 Test  #4: cmake_slicer_extension_metadata_set_defaults_test ...................   Passed    0.01 sec
    Start  5: cmake_slicer_extract_extension_description_test
3/8 Test  #5: cmake_slicer_extract_extension_description_test .....................   Passed    0.01 sec
    Start  6: cmake_slicer_generate_extension_description_test
4/8 Test  #6: cmake_slicer_generate_extension_description_test ....................   Passed    0.01 sec
    Start  7: py_cmake_slicer_extensions_index_build_without_upload
5/8 Test  #7: py_cmake_slicer_extensions_index_build_without_upload ...............   Passed    6.54 sec
    Start  8: py_cmake_slicer_extensions_index_build_with_upload
6/8 Test  #8: py_cmake_slicer_extensions_index_build_with_upload ..................   Passed   34.65 sec
    Start  9: py_cmake_slicer_extensions_index_build_with_upload_using_ctest
7/8 Test  #9: py_cmake_slicer_extensions_index_build_with_upload_using_ctest ......   Passed   34.45 sec
    Start 10: py_cmake_slicer_extensions_index_build_without_upload_using_ctest
8/8 Test #10: py_cmake_slicer_extensions_index_build_without_upload_using_ctest ...   Passed    6.89 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
CMake    =  82.56 sec (8 tests)

Total Test time (real) =  82.64 sec

Merge request reports