Skip to content

Fix sh warnings

Sam Horvath requested to merge fix-sh-warnings into master

Created by: jcfr

This PR fixes the following warnings:

/home/jcfr/Projects/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.cxx:849:42: warning: unused variable 'mostSuitablePluginByConfidenceNumbers' [-Wunused-variable]
  qSlicerSubjectHierarchyAbstractPlugin* mostSuitablePluginByConfidenceNumbers =
                                         ^
/home/jcfr/Projects/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx:296:32: warning: unused variable 'shNode' [-Wunused-variable]
  vtkMRMLSubjectHierarchyNode* shNode = vtkMRMLSubjectHierarchyNode::GetSubjectHierarchyNode(scene);
                               ^
/home/jcfr/Projects/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx:355:102: warning: implicit conversion of NULL constant to 'vtkIdType' (aka 'long long')
      [-Wnull-conversion]
      qSlicerSubjectHierarchyPluginHandler::instance()->pluginsForAddingNodeToSubjectHierarchy(node, NULL);
                                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~       ^~~~
                                                                                                     0

@cpinter Are these benign warnings or do they reveal some other issues ? Thanks for checking

Merge request reports