- Dec 06, 2023
-
-
e6398395 Tests/CXXModules: enhance `internal-partitions` test 8a658fb9 Tests/CXXModules: import from an internal partition Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !9039
-
e9b0dcbb cmCxxModuleMapper: Fix transitive requirements computation Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Merge-request: !9030
-
ef49ed0f LLVMFlang: Fix MSVC ABI debug information format options Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !9037
-
fc650892 cmComputeLinkInformation: Restore soname lookup for non-imported targets 03d86f9d cmGeneratorTarget: Add helper to check for known runtime artifact Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Acked-by:
Robert Maynard <robertjmaynard@gmail.com> Merge-request: !9041
- Dec 05, 2023
-
-
Brad King authored
In commit 7351d590 (cmTarget: Add a way to represent imported shared library stubs, 2023-07-17, v3.28.0-rc1~344^2) we accidentally stopped passing the SONAME of a non-imported SHARED library to our runtime search path ordering logic. Unfortunately I have not found a way to add a test case for this, but it at least shouldn't regress existing tests or those added by that commit.
-
Brad King authored
-
Previously CMake may generate incomplete transitive requirements in CMakeFiles/<target>.dir/CXXModules.json and therefore in module mapper for compiler, when source files were listed in CMakeList.txt in a certain order. This commit fixes the problem by correctly tracking unfinished transitive requirements computation of module units. There have been a simple circular test case whose circular dependency was reported by build system. Now with this correct implementation it's reported by CMake generating module mappers. Add two test cases for transitive requirements computation, one with adding source files in hardcoded order, and the other in randomized order. Fixes: #25465
-
40af1034 cmCMakePath: do not use std::filesystem::path with RH gcc-toolset-10 Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Merge-request: !9026
-
40dc13b2 cmNinjaTargetGenerator: PCH files do not need dyndep f61c64cd cmLocalGenerator: prevent scanning of PCH source files ea8c37b7 Tests/CXXModules: add a test which scans a PCH-using source Acked-by:
Kitware Robot <kwrobot@kitware.com> Tested-by:
buildbot <buildbot@kitware.com> Merge-request: !9032
-
a820877d errors: avoid constructing a stream before getting the last error 5cf7018a cmFileCopier: remember error statuses and get their strings 0639a32d cmFileTimes: return status codes from APIs Acked-by:
Kitware Robot <kwrobot@kitware.com> Tested-by:
buildbot <buildbot@kitware.com> Merge-request: !9023
-
696e14d9 cmFileLockResult: Fix inclusion of windows.h when cross-compiling Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !9035
-
fc6231be libuv: win/spawn: run executables with no file extension b37d9378 libuv: Revert "win/spawn: run executables with no file extension" Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
Kyle Edwards <kyle.edwards@kitware.com> Merge-request: !9033
-
Ben Boeckel authored
This test previously did not *require* that the internal partition be specified as a transitive usage because nothing from it was exposed. Plumb through usages such that the internal partitions are required.
-
Ben Boeckel authored
It is reported that MSVC doesn't support the `modname=` syntax in its `-reference modname=modname.ifc` for internal partitions. Add a test case.
-
- Dec 04, 2023
-
-
Brad King authored
In commit 26bf32cd (LLVMFlang: Add support for targeting MSVC ABI on Windows, 2023-09-28, v3.28.0-rc1~10^2) we incorrectly recorded `-g` as supporting the `ProgramDatabase` format, but it is actually `Embedded`, matching Clang. In order to support easy integration with C and C++ projects that use the `.pdb` debug formats, pretend LLVMFlang supports them and just don't actually emit any debug information. Issue: #24840
-
Backport this commit from libuv PR 4241 to restore `execute_process()` support for running executables on Windows with no file extension. Fixes: #25450
-
Brad King authored
This reverts commit da9df742 (libuv: win/spawn: run executables with no file extension, 2023-11-29, v3.28.0-rc6~1^2~1). It incorrectly searched the `PATH` for extension-less command names. Another fix will be needed for the regression motivating it. Record this as a merge from the last-imported upstream libuv snapshot branch so that future `git blame` points to the upstream for the original code instead of this commit. Fixes: #25473 Issue: #25450
-
Marc Chevrier authored
Fixes: #25458, #25453
-
ab561b86 libuv: win: honor NoDefaultCurrentDirectoryInExePath env var Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !9022
-
Ben Boeckel authored
Fixes: #24209
-
Ben Boeckel authored
-
Ben Boeckel authored
This tests that PCH usage works with scanning logic.
-
- Dec 01, 2023
-
-
Ben Boeckel authored
Constructing a stream may involve operations that change the global error state. Avoid the streams by using `cmStrCat` instead.
-
Ben Boeckel authored
The last error may have changed between the original call and the `GetLastSystemError()` call. Remember the status explicitly and ask it for its error string. Reported on Discourse: https://discourse.cmake.org/t/9539
-
Ben Boeckel authored
This avoids accidentally overwriting the global error state before fetching the intended error code.
-
Kyle Edwards authored
Backport commit 5e302730cd (win: honor NoDefaultCurrentDirectoryInExePath env var, 2023-12-01) from libuv PR 4238.
-
- Nov 30, 2023
-
-
f6d2efa7 Tests: Add case to cover execute_process support for no extension on Windows da9df742 libuv: win/spawn: run executables with no file extension Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
scivision <michael@scivision.dev> Merge-request: !9017
-
Kyle Edwards authored
Issue: #25450
-
Kyle Edwards authored
Backport this commit from libuv PR 4241 to restore `execute_process()` support for running executables on Windows with no file extension. Fixes: #25450
-
5123e9e1 ci: unmask RPM tests on Fedora 39 bf22ac52 CPack/RPM: Quote paths in rpm spec only if they have whitespace 75ea6207 CPack/RPM: Factor out helper to quote paths in generated rpm spec Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !9005
-
d01120a4 cmGlobalGenerator: clear RuntimeDependencySet members at configure Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !9013
- Nov 29, 2023
-
-
-
Brad King authored
RPM supports either whitespace with quoting or globbing without quoting. Prior to RPM 4.19 it accepted globbing in quotes, but it only globbed correctly without whitespace, where quoting was not necessary anyway. Starting in RPM 4.19, glob characters in quotes are considered literal. Fixes: #25421 Inspired-by:
Ben Boeckel <ben.boeckel@kitware.com> See: https://github.com/rpm-software-management/rpm/commit/d44114f007f54f205ffa13d22724199fe50a137a
-
Brad King authored
-
Ben Boeckel authored
Commit f2617cf8 (Source: Add cmInstallRuntimeDependencySet, 2021-05-19) introduced via !6186 to 3.21 added storage to the global generator for runtime dependency sets. However, this was not cleared at the start of configure in the `ClearGeneratorMembers()` method. When using `ccmake` to configure (and, presumably `cmake-gui` too), projects using `install(TARGETS … RUNTIME_DEPENDENCY_SET)` would use dependency set tracking instances from previous configure runs that held references to targets free'd with the `cmMakefile` instance that held them. Clear the dependency sets at the beginning of configure so that they are not remembered and trigger via use-after-free bugs when used. Fixes: #25446
-
cbd549b0 cxxmodules: Add more suggestions to no-modules-support diagnostics Acked-by:
Kitware Robot <kwrobot@kitware.com> Tested-by:
buildbot <buildbot@kitware.com> Merge-request: !9011
-
6030df20 Xcode: Fix embed resources prop name Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
Deal <halx99@live.com> Merge-request: !9008
-