- Mar 23, 2023
-
-
a6bb4975 FindHDF5: Restore parallel HDF5 detection with only CXX enabled Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !8355
- Mar 22, 2023
-
-
Brad King authored
Since commit 14c46fb1 (FindHDF5: Find C component with only CXX compiler, 2022-12-13, v3.26.0-rc1~175^2), if CXX is enabled but C is not, the `_HDF5_test_regular_compiler_C` helper writes a `.cpp` source but the `_HDF5_invoke_compiler` still expects a `.c` source. Refactor the logic to select a name for the source file up front, and use it in both helpers. Fixes: #24627 Issue: #24241
-
- Mar 21, 2023
-
-
1b7c26da Ninja: Wrap rules using '>' shell redirection with 'cmd /C' on Windows ffd8537a Clang: Record Clang 16.0 C++ modules flags only for GNU-like front-end 60132272 cmGlobalNinjaGenerator: Use forward slashes in clang modmap format on Windows d9d74b5e cmDyndepCollation: Drop outdated mentions of CXX_MODULE_INTERNAL_PARTITIONS edab56d2 cmLocalNinjaGenerator: De-duplicate condition for using 'cmd /C' on Windows 8ebe3f92 cmGlobalNinjaGenerator: Detect GNU-like command-line for dyndep collator f3ca199c cmGlobalNinjaGenerator: Factor out GNU-like command-line detection on Windows f79817fc cmCxxModuleMapper: Use value semantics in path conversion callback ... Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !8346
-
843fc607 Ninja: Restore detection of clang-cl showIncludes prefix 3346570a Tests: Comment RunCMake.Ninja ShowIncludes sample input languages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !8344
-
4c902d67 FindPython: ensure Stable ABI is correctly handled Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !8345
-
- Mar 20, 2023
-
-
Brad King authored
This is needed for the clang-scan-deps rule added by commit 0e21e55fc5 (Clang: Record Clang 16.0 C++ modules flags only for GNU-like front-end, 2023-03-16). Fixes: #24611
-
Brad King authored
The settings added by commit 3fe8e33f (Clang: Record Clang 16.0 flags for our experimental C++ modules support, 2023-03-03, v3.26.0-rc6~6^2) work only for the GNU-like `clang++` front-end, and not for the MSVC-like `clang-cl` on Windows. Also quote the path to `clang-scan-deps` to support spaces in its path. Issue: #24611
-
Since commit 8f82e755 (Ninja: Fix detection of MSVC showIncludes prefix in Italian, 2023-01-26, v3.26.0-rc1~20^2) our regex no longer matches the output from `clang-cl`, which uses a relative path, forward slashes, and is always in English [1]: Note: including file: ./foo.h Update the regex to match that too. [1] https://github.com/llvm/llvm-project/blob/llvmorg-16.0.0/clang/lib/Frontend/HeaderIncludeGen.cpp#L102 Co-authored-by: Brad King <brad.king@kitware.com>
-
Brad King authored
-
Fixes: #24610
-
- Mar 18, 2023
-
-
Brad King authored
Issue: #24611
-
Brad King authored
These were left from an older design iteration in which, for MSVC, we needed to distinguish `cl -internalPartition` from `cl -interface` before scanning. It is no longer needed since `cl -scanDependencies` was updated to use the standard-conforming interpretation of non-exported module partition syntax. Issue: #24611
-
Brad King authored
-
Brad King authored
This will help the collator choose flags and path styles for modmap files.
-
Brad King authored
-
Brad King authored
The call site already owns a path it doesn't need when the callback returns. Hand ownership to the callback so it can optionally mutate the path without necessarily allocating.
-
Brad King authored
Two calls to `PathForGenerator` were applied to values returned by `BmiGeneratorPathForModule`, that already calls `PathForGenerator`.
-
- Mar 17, 2023
-
-
6988ddf8 WriteBasicConfigVersionFile: Fix regression in ARCH_INDEPENDENT check Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !8337
-
58ab34d8 FindMatlab: add version/release map for R2023a Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !8334
-
- Mar 16, 2023
-
-
Brad King authored
Refactoring in commit 77982de9 (CMakePackageConfigHelpers: only emit arch check if needed, 2023-01-29, v3.26.0-rc1~16^2) did not correctly preserve the check for empty `CMAKE_SIZEOF_VOID_P`. Fix it. The difference between the version files generated before and after is: -if(CMAKE_SIZEOF_VOID_P STREQUAL "" OR "8" STREQUAL "") +if("${CMAKE_SIZEOF_VOID_P}" STREQUAL "" OR "8" STREQUAL "") This restores the check generated before the above-mentioned commit. Fixes: #24608
-
- Mar 14, 2023
-
-
97fcd3bd CheckCompilerFlag: Revert 'Match the Clang "argument unused" output ...' Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Acked-by: scivision <michael@scivision.dev> Merge-request: !8322
- Mar 13, 2023
-
-
Brad King authored
Revert commit 5b45a3d0 (CheckCompilerFlag: Match the Clang "argument unused" output for all languages, 2023-01-23, v3.26.0-rc1~38^2). It broke existing projects that were silently tolerating unrelated unused arguments in their checks for C and CXX. For example, using `CFLAGS=-nostdinc` or `CXXFLAGS=-nostdinc++` causes those flags to be used when driving the linker as well, and Clang warns they are unused in that case. Add a test case covering the now-restored behavior. Fixes: #24591
-
Brad King authored
-
Brad King authored
Merge-request: !8320
-
Brad King authored
Changes in commit 9c5bd7fe (CompilerId: Output errors from all attempts at detection, 2022-08-16, v3.25.0-rc1~290^2) accidentally stopped logging failed compiler identification build output. This was fixed for CMake 3.26 and later by commit 24ccc8c3 (CompilerId: Restore logging of failed identifications, 2023-01-16, v3.26.0-rc1~70^2~6). Backport it to 3.25.
-
685108a5 Ninja: Revert "Optimize target depends closure" due to performance regression Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !8315
-
- Mar 10, 2023
-
- Mar 08, 2023
-
-
Brad King authored
-
Brad King authored
-
Brad King authored
-
Brad King authored
-
abb1c121 VS: Revert "Build custom commands concurrently when possible" Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !8297
-
Brad King authored
-
a6f5bdd6 Merge branch 'backport-3.24-file-install-macos' 35f2b1bf file(INSTALL): Fix file ownership regression when running as root on macOS a5d65485 file(INSTALL): Fix file ownership regression when running as root on macOS Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !8293
-
Brad King authored
-