- 23 Jan, 2023 1 commit
-
-
Kitware Robot authored
-
- 22 Jan, 2023 1 commit
-
-
Kitware Robot authored
-
- 21 Jan, 2023 1 commit
-
-
Kitware Robot authored
-
- 20 Jan, 2023 8 commits
-
-
ebd81d0e ci: rebase nvidia-derived docker images on tags we control Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
Robert Maynard <robertjmaynard@gmail.com> Merge-request: !8102
-
Brad King authored
According to NVIDIA's container image support policy [1], they will remove tags for older images over time. In order to preserve our ability to rebuild CI images based on them in the future, base them on tags we control. [1] https://gitlab.com/nvidia/container-images/cuda/blob/85fbd45b92/doc/support-policy.md
-
317aac14 cmake: Stop pointing users at logs on configure errors eae1398d cmake --system-information: Stop dumping CMake{Output,Error}.log Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Merge-request: !8094
-
4165eb3d Ninja: Emit swiftmodule from executable with exports Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !8048
-
a429e4b9 CYGWIN: Drop pre-2.8.4 compatibility mode CMAKE_LEGACY_CYGWIN_WIN32 Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Merge-request: !8096
-
5f0c5ec4 cmake: Print configure/generate time Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Acked-by:
scivision <michael@scivision.dev> Merge-request: !8083
-
dae189fb Merge branch 'upstream-KWSys' into update-kwsys 4ac17cff KWSys 2023-01-19 (be3c441e) Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Merge-request: !8092
-
Kitware Robot authored
-
- 19 Jan, 2023 18 commits
-
-
Evan Wilde authored
This patch adds support for tracking the swiftmodules for executables exporting symbols. This fixes a bug in the earlier implementation around emitting the swiftmodule. Previously, the code would use `CMAKE_EXE_EXPORTS_Swift_FLAG` to inject the `-emit-module`, and module path information into the `CMAKE_Swift_LINK_EXECUTABLE` rule. Because Swift skips the build step and only runs during the link phase, these flags were injected in `cmNinjaNormalTargetGenerator::ComputeLinkCmd` instead of `cmLocalGenerator::GetTargetFlags` where it is done normally. Unfortunately, injecting in `ComputeLinkCmd` didn't do anything because we have a `linkCmd` so `ComputeLinkCmd` exits early, before the EXE_EXPORT flags get added to the link command. Instead of playing with that flag, CMake checks `CMAKE_Swift_LINK_EXECUTABLE_WITH_EXPORTS` and uses that as the link rule if it exists and falls back on `CMAKE_Swift_LINK_EXECUTABLE`. I've defined that variable in terms of `CMAKE_Swift_LINK_EXECUTABLE` with the necessary additional flags for emitting the swift module instead. This has the same end effect as the desired behavior, but simplifies things a bit. Since we're generating the swiftmodule for executables with exports, I've also updated the dependency graph to include the swiftmodule as an output in the build dependency graph if the executable has exports. Tests updated: - RunCMake/NoWorkToDo: Ensure that the build graph does not result in unnecessary rebuilds with exporting executables. - SwiftOnly: Ensure that we can consume functions defined in the executable by a library getting linked into said executable.
-
Brad King authored
Prior to CMake 2.8.4 (released in 2011), we defined `WIN32` on CYGWIN. That was removed, but an undocumented `CMAKE_LEGACY_CYGWIN_WIN32` compatibility mode was left to help projects transition. Only projects that do not require at least 2.8.4 as their minimum CMake version need the compatibility mode. We've also long warned about projects that do not require at least 2.8.12, so it is now reasonable to remove the legacy compatibility mode.
-
Brad King authored
Since commit 18e1bfbb (cmake: On configure error suggest looking at CMake*.log files, 2013-07-09, v2.8.12~210^2), when configuring a project fails, we print `See also .../CMake{Output,Error}.log` near the end of the output. This was intended to help users find failures in system and compiler inspection checks, but for normal project errors the messages may be misleading. The logs may contain incidental errors that are part of normal operation and do not need to be addressed by the user. Since commit f6ed2585 (Modules: Record system inspection steps in the configure log, 2023-01-16), CMake's builtin modules no longer log information to the old-style `CMake{Output,Error}.log` files anyway, so stop mentioning them. Fixes: #22131 Issue: #23200
-
Brad King authored
CMake no longer logs system information to these files.
-
f6ed2585 Modules: Record system inspection steps in the configure log 0f688386 Modules: Drop redundant check logging to CMakeOutput.log and CMakeError.log ecc26f98 UsewxWidgets: Remove leftover debugging code 874c2e11 FindQt4: Drop outdated advice to look at CMakeError.log on failure a80465bc GHS: Drop debugging message from log 91994496 CompileFeatures: Warn explicitly when feature detection binary is not found 24ccc8c3 CompilerId: Restore logging of failed identifications 95976514 Tests: Avoid using CMake{Output,Error}.log files Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !8089
-
Brad King authored
-
Kyle Edwards authored
-
Brad King authored
-
2e3fcf93 Tutorial: Fix typos in Step 11 exercise and solution f04c5488 Tutorial: Fix exercise in Step 10 to match solution provided in Step 11 566e12c9 Tutorial: Fix destination of link from Step 6 to Step 5 bef0b9eb Tutorial: Fix exercise in Step 5 to match solution provided in Step 6 Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !8087
-
b4be6077 FindLibLZMA: Fix failure when no include directories are needed Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !8088
-
1f16af01 cmGlobalNinjaGenerator: Optimize target depends closure Acked-by:
Kitware Robot <kwrobot@kitware.com> Tested-by:
buildbot <buildbot@kitware.com> Merge-request: !8079
-
a525f5f1 cmGeneratorTarget: Cache full name components Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
buildbot <buildbot@kitware.com> Merge-request: !8033
-
Brad King authored
# By KWSys Upstream * upstream-KWSys: KWSys 2023-01-19 (be3c441e)
-
Code extracted from: https://gitlab.kitware.com/utils/kwsys.git at commit be3c441e46e091a7606565221bb5ae7c9a9b684f (master). Upstream Shortlog ----------------- Brad King (4): 6c66ba9e clang-format.bash: Use generic clang-format attribute 82ae3f28 clang-format.bash: update to clang-format-15 a61d0ad6 Empty commit at end of history preceding clang-format-15 style transition 3cb35bf3 CONTRIBUTING: Update documented clang-format version to 15 Kitware Robot (1): f685d817 Revise C++ coding style using clang-format-15 Sean McBride (1): d6c6fd82 testDirectory: Rename functions to fix -Wreserved-identifier warnings
-
53d7d8d4 Help/dev: Update source code guide to specify clang-format version 15 Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !8091
-
Brad King authored
-
33abef74 Revise C++ coding style using clang-format-15 57221fd5 Empty commit at end of history preceding clang-format-15 style transition 6739d579 clang-format.bash: update to clang-format-15 9ee57226 clang-format: Add comments to suppress some formatting Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !8086
-
Kitware Robot authored
-
- 18 Jan, 2023 11 commits
-
-
Joshua Perrett authored
-
Joshua Perrett authored
The solution in Step 11 sets POSITION_INDEPENDENT_CODE to `${BUILD_SHARED_LIBS}`, rather than simply to "True" in all cases.
-
Joshua Perrett authored
The link in Step 6 (to "Testing Support") clearly refers to Exercise 2. Fix the location to which the link jumps.
-
Brad King authored
-
Brad King authored
The find module does not write information to the log.
-
Brad King authored
-
Brad King authored
This step is not normally expected to fail, so warn instead of logging it.
-
Brad King authored
These log files will soon go away, so avoid using them in tests.