Skip to content
Snippets Groups Projects
  1. Jan 26, 2017
    • Alexis Girault's avatar
      ENH: Use vtkTriangleMeshPointNormals · 969659fd
      Alexis Girault authored
      The main bottleneck with real-time VTK rendering so far
      appeared to be the normals computation. This commit addresses
      that issue by making use of the latest normals computation
      filter in VTK: vtkTriangleMeshPointNormals.
      
      While this filter is much (5 to 16 times) faster than
      vtkPolyDataNormals, it does not check for consistency in the
      cell orientations that could cause inverted normals, which
      is why the vtkPolyDataNormals is called once in the surfacemesh
      renderdelegate to retrieve consistent cells for the input mesh.
      
      See VTK merge request for more information :
      vtk/vtk!2271
      
      PS: That MR requires the latest commits from VTK master, which
      does not include work made on texture wrap mode nor on multi
      texture attributes yet:
      - iMSTK/vtk@62a7ecd8
      - iMSTK/vtk@ae373026
      969659fd
  2. Jan 24, 2017
  3. Jan 06, 2017
    • Alexis Girault's avatar
      Merge branch 'fix-std-functional-msvc' into 'master' · 402d718f
      Alexis Girault authored
      COMP: Fix function is not a member of std (Win)
      
      The merge request !117 to add custom event handlers
      for vtk interaction introduced a bug on Windows, where
      the <functional> header needs to be included to be able
      to use `std::function`.
      
      This fixes the 50 errors listed on cdash (due to those
      `std::function` members being used frequently):
      http://my.cdash.org/viewBuildError.php?buildid=1111691
      
      PS: The experimental build for this MR did not show any
      issues on CDash [1], but they appeared once merged in the
      master branch (continuous). There seem to be an issue
      with how buildbot runs those builds on Windows, since a
      similar issue happened on windows 32 bits with Eigen
      aligned data structures in stl containers.
      
      [1] http://my.cdash.org/buildSummary.php?buildid=1111615
      
      See merge request !122
      402d718f
    • Alexis Girault's avatar
      COMP: Fix function is not a member of std (Win) · b746ea57
      Alexis Girault authored
      The merge request !117 to add custom event handlers
      for vtk interaction introduced a bug on Windows, where
      the <functional> header needs to be included to be able
      to use `std::function`.
      
      This fixes the 50 errors listed on cdash (due to those
      `std::function` members being used frequently):
      http://my.cdash.org/viewBuildError.php?buildid=1111691
      
      PS: The experimental build for this MR did not show any
      issues on CDash [1], but they appeared once merged in the
      master branch (continuous). There seem to be an issue
      with how buildbot runs those builds on Windows, since a
      similar issue happened on windows 32 bits with Eigen
      aligned data structures in stl containers.
      
      [1] http://my.cdash.org/buildSummary.php?buildid=1111615
      b746ea57
    • Alexis Girault's avatar
      Merge branch 'custom-vtk-interactor' into 'master' · a20d4483
      Alexis Girault authored
      ENH: Add custom event handlers for vtk interaction
      
      1. Allow to set up lambda functions from `VTKViewer`
      as custom behavior to run in the interactor Style
      in event callbacks.
      2. Simplify `VTKInteractorStyle::OnChar()` to only have
      simple default behaviors (start, stop, pause, play, quit)
      3. Move the implementation of `getTargetFrameRate()`,
      `setTargetFrameRate()` and `setSimulationManager()` from
      `VTKInteractorStyle` to `VTKViewer`, which becomes friend class
      of the private members of `VTKInteractorStyle` to avoid
      repeatedly wrapping around the interactor style methods.
      
      Co-authored-by: Hina Shah <hina.shah@kitware.com> (@hina), adapted from iMSTK/iMSTK!113
      
      See merge request !117
      a20d4483
  4. Jan 05, 2017
  5. Jan 03, 2017
    • Alexis Girault's avatar
      Merge branch 'skip-computebounds-vtk' into 'master' · 31d746cf
      Alexis Girault authored
      Skip compute bounds in vtk
      
      Apply changes referenced [here](vtk/vtk!2271) to speed up VTK rendering by avoiding calling `GetBounds()` which requires recomputing the bounding box at every frame for deformable objects:
      
      1. RemoveCuller
      2. Disable VBO Shift&Scale check
      
      Also use `setUpMapper` (previously setActorMapper) more consistently along the vtk render delegates.
      
      See merge request !115
      31d746cf
    • Alexis Girault's avatar
      Merge branch 'fix-some-warnings' into 'master' · 17de16d8
      Alexis Girault authored
      Correct some warnings
      
      Mostly due to lack of `override` where needed.
      
      See merge request !116
      17de16d8
  6. Dec 20, 2016
    • Alexis Girault's avatar
      ENH: Add custom event handlers for vtk interaction · a63f98b5
      Alexis Girault authored
      
      1) Allow to set up lambda functions from VTKViewer
      as custom behavior to run in the interactor Style
      in event callbacks.
      2) Simplify VTKInteractorStyle::OnChar() to only have
      simple default behaviors (start, stop, pause, play, quit)
      3) Move the implemenation of getTargetFrameRate(),
      setTargetFrameRate() and setSimulationManager() from
      VTKInteractorStyle to VTKViewer, which becomes friend class
      of the private members of VTKInteractorStyle to avoid
      repeatedly wrapping around the interactor style methods.
      
      Co-authored-by: default avatarHina Shah <hina.shah@kitware.com>
      a63f98b5
    • Alexis Girault's avatar
      ENH: skip compute bounds in vtk · 5b2ce23a
      Alexis Girault authored
      1) RemoveCuller
      2) Disable VBO Shift&Scale check
      
      Also use `setUpMapper` (previously setActorMapper) more
      consistently.
      5b2ce23a
    • Alexis Girault's avatar
      ENH: Correct some warnings · 0692305e
      Alexis Girault authored
      0692305e
  7. Dec 08, 2016
    • Alexis Girault's avatar
      Merge branch 'mshReader' into 'master' · c8dbe384
      Alexis Girault authored
      MeshIO (input, output, convert) for (volumetric) meshes in  .msh and .veg file format
      
      ![liverScreenShot2](/uploads/f396f4cc1570700aa9c90e835dd932d2/liverScreenShot2.png)New addition(s):
      1. Added `MSHMeshIO` to read a mesh in .msh file format, and instantiate `imstk::VolumetricMesh` 
      2. Added a method in `VegaMeshIO` to convert `imstk::VolumetricMesh` to `vega::VolumetricMesh`
      3. Added a method in `VegaMeshIO` to write `imstk::Mesh` in .veg file format.
      4. Added an example `testMshandVegaIO` in `Sandbox` to test these implementations (Attached is the output with this merge request).
      
      See merge request !112
      c8dbe384
  8. Dec 06, 2016
  9. Nov 30, 2016
    • Alexis Girault's avatar
      Merge branch 'improve-render-clock' into 'master' · c6298aa5
      Alexis Girault authored
      Improve render clock
      
      `VTKInteractorStyle::CreateRepeatingTimer` would call
      `VTKInteractorStyle::OnTimer` then sleep for the period
      given in ms after calling `OnTimer` again. This isn't
      adapted for rendering at a uniform frame rate, because
      the time spent within the `OnTimer` function is not
      taken into account in the sleep time.
      
      By using `OneShotTimer`, we can manipulate when to
      render the next frame: in (period - time spent) ms
      if the time spent in `OnTimer` is smaller than the period
      time, or right away (period of 0 ms) if the time spent
      is over the target period (late frame).
      
      An interface is added in the `VTKInteractorStyle`,
      wrapped in the `VTKViewer`, to set the target frame rate.
      
      Also added a commit to use `DATA_DIR` defined in the Sandbox example to easily change the data directory for each user on their own machine. Any local change to the `DATA_DIR` value should not be committed in the future.
      
      See merge request !114
      c6298aa5
  10. Nov 29, 2016
  11. Nov 23, 2016
  12. Nov 19, 2016
  13. Nov 17, 2016
Loading