Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • engine engine
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Pulse Physiology Suite
  • engineengine
  • Merge requests
  • !73

Fix a series of warnings in the engine code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Harald Scheirich requested to merge fix/warnings into 3.x Jan 08, 2021
  • Overview 0
  • Commits 21
  • Changes 13

This is a set of changes to remove some of the warnings in the engine code, there are still warnings left in the code stemming from protobuff, the test code, and one warning type in the engine. Still needs full testing.

There were quite a few variable defined that were unused, while some seemed just left over from development some look like physical or other constants. The latter were marked up with the keyword 'const' which at least prevents visual studio to warn about them.

Edited Jan 08, 2021 by Harald Scheirich
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/warnings