Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • engine engine
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Pulse Physiology Suite
  • engineengine
  • Merge requests
  • !113

COMP: Update imstkSolveDependencies module based on commontk/Artichoke@101b332f4

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jean-Christophe Fillion-Robin requested to merge jcfr/engine:fix-configuration-with-cmake-3.23rc1-updating-SolveDependencies into 4.x Feb 18, 2022
  • Overview 0
  • Commits 4
  • Changes 3

This commit fixes configuration of Eigen3 external project issue using CMake 3.23.0-rc1. See discussion at cmake/cmake#23238 (closed)

It removes obsolete setting of CMAKE_GENERATOR_* variables in add_external_project_ex, indeed these variables are now automatically passed to projects from within the updated SolveDependencies CMake module.

Changes adapted from Kitware/iMSTK@359400116

Edited Feb 18, 2022 by Jean-Christophe Fillion-Robin
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-configuration-with-cmake-3.23rc1-updating-SolveDependencies