Kenneth Moreland authored 5 years ago and Kitware Robot committed 5 years ago

7518d067 Try to fix uninitialized anonymous variable warning
5b18ffd7 Register Variant as trivially copyable if possible
16305bd8 Add tests of ArrayHandleMultiplexer on multiple devices

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !1898

The code from the previous commit was causing one of the dashboards,
which is using gcc-7, to produce the following warning:

In file included from ../testing/UnitTestVariant.cxx:11:0:
../Variant.h: In function 'void {anonymous}::TestCopyDestroy()':
../Variant.h:269:5: warning: '<anonymous>' may be used uninitialized in this function [-Wmaybe-uninitialized]
     this->Storage = std::move(rhs.Storage);
     ^~~~

At best, this warning is not helpful as it does not seem to point to
anything that could be used uninitialized. At worst, it might be a
compiler bug. A Google search finds a few similar bugs although none I
can assert with any confidence of this issue. However, many reported
bugs and issues point to the use of anonymous namespaces. So, I'm going
to attempt to fix the problem by removing anonymous namespaces.
Hopefully it will fix the warning or at least point me to something
concrete that I can fix.

The Variant template can hold any type. If it is holding a type that is
non-copyable, then it has to make sure that appropriate constructors,
copiers, movers, and destructors are called.

Previously, these were called even the Variant was holding a trivially
copyable class because no harm no foul. If you were holding a trivially
copyable class and did a memcpy, that work work, which should make it
possible to copy between host and device, right?

In theory yes, but in practice no. The problem is that Cuda is
outsmarting the code. It is checking that Variant is not trivially-
copyable by C++ semantics and refusing to push it.

So, change Variant to check to see if all its supported classes are
trivially copyable. If they are, then it use the default constructors,
destructors, movers, and copiers so that C++ recognizes it as trivially
copyable.

Sujin Philip authored 5 years ago and Kitware Robot committed 5 years ago

5ca9a4bd Fix UnitTestError

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !1897

The previous changes were incorrect and did not fix the problem.

Sujin Philip authored 5 years ago and Kitware Robot committed 5 years ago

79f7f827 Fix UnitTestError failure
901711bf Fix test failure due to floating point issues

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !1896

Compiler optimization may remove recursion and other function calls so we
cannot rely on the number of stack frames to be consistent.

Floating point precision issues are causing the Reduce algorithm of the OpenMP
backend to produce result that is off by more than 0.001.

Robert Maynard authored 5 years ago and Kitware Robot committed 5 years ago

0fccc5f2 improve moments algorithm performance

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Allison Vacanti <allison.vacanti@kitware.com>
Merge-request: !1895

Robert Maynard authored 5 years ago and Kitware Robot committed 5 years ago

552d4734 Initial documentation on how to cut a VTK-m release

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !1894

Robert Maynard authored 5 years ago and Kitware Robot committed 5 years ago

f66d980d 1.5.0 is our 6th official release of VTK-m.
3c54de5f Add release notes for v1.5.0

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1893

The major changes to VTK-m from 1.5-1.0 can be found in:
  docs/changelog/1.5/release-notes.md

Kenneth Moreland authored 5 years ago and Kitware Robot committed 5 years ago

677962f9 Add Matrix.h to cellmetrics include

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Hank <hank@uoregon.edu>
Merge-request: !1892

Robert Maynard authored 5 years ago and Kitware Robot committed 5 years ago

d47f7aaa Add an ImageMedian filter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1890

Robert Maynard authored 5 years ago and Kitware Robot committed 5 years ago

64dede74 Fix Compilation bug with Fill method

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Allison Vacanti <allison.vacanti@kitware.com>
Merge-request: !1889

Dave Pugmire authored 5 years ago and Kitware Robot committed 5 years ago

665f323d optimization for mask select for all masks active.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !1891

This file was using the Matrix class but not including Matrix.h. When I
tried to use the MeshQuality filter in an example that did not include
Matrix.h on its own, I got a compile error.

Sujin Philip authored 5 years ago and Kitware Robot committed 5 years ago

0bb8cbf4 Fix CellLocatorUniformBins test
16904914 Merge branch 'upstream-lcl' into fix-lcl-dashboard
e7cf79a9 lcl 2019-10-09 (d7604cbf)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !1888

Robert Maynard authored 5 years ago and Kitware Robot committed 5 years ago

cf2d62fb Remove unneeded ExecutionSignatures
c3f0060c ExecutionSignatures are now optional for simple worklets
1b08521f Merge branch 'upstream-taotuple'
c6d30956 taotuple 2019-10-08 (0d1e4dfd)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !1882

Allison Vacanti authored 5 years ago and Kitware Robot committed 5 years ago

56b4fa9a MSVC 2019 needs a different integer sequence impl, too.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !1887

* upstream-lcl:
  lcl 2019-10-09 (d7604cbf)

Kitware Robot authored 5 years ago and Sujin Philip committed 5 years ago

Code extracted from:

    https://gitlab.kitware.com/vtk/lcl.git

at commit d7604cbf4a7776a937f6a176e112de0549dd0a91 (master).

Dave Pugmire authored 5 years ago and Kitware Robot committed 5 years ago

c41bf99b Adjust tolerance
2554de78 Fix tolerance for unittest.
9e486e07 Fix for smallStep in integrator.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1879