Skip to content

Improve unnamed object naming scheme

Steven Pehrson requested to merge sbp/qttesting:improve-unnamed-object-serialization into master

Greatly reduce the set of objects that are considered when looking for an unnamed object. The previous implementation considered all widgets, named or not, and of any type. This was particulary poor when the object's parent was the QMainWindow as it considered every single Widget in the the entire QMainWindow object tree because the children() function is recursive.

This will likely break existing scripts. It might be a good idea to also consider a more verbose and flexible naming scheme. For example instead of "1QTabWidget16", "QTabWidget:visible=yes,sibling_index=16". visible is a good way to disambiguate, but there are other properties we could consider as well like enabled, focus, toolTip, windowTitle, pos, etc. Maybe encode the extra information with JSON

Merge request reports