Skip to content

Fixing/improving external plugin builds for Windows.

Keith Ballard requested to merge keith.m.ballard/paraview:patch-1 into master

These changes do two things:

  1. Fixes a bug due to // in paths breaking Windows.

paraview_plugin_build takes the option LIBRARY_SUBDIRECTORY, which defaults to "". There were guards for if the variable was defined in most places, but not all. This resulted in paths being convoluted with "//". If CMAKE_RUNTIME_OUTPUT_DIRECTORY is not set, this situation leads to the output directory in Visual Studio to be "\${PLUGIN_NAME}" after the conversion to Windows paths, which is not a valid path and breaks builds on Windows for plugins when no LIBRARY_SUBDIRECTORY and CMAKE_RUNTIME_OUTPUT_DIRECTORY is provided.

This change updates paraview_plugin_build to avoid the situation of having // in the CMake path variables.

  1. Provides improved errors when GNUInstallDirs is not included but needed for defaults

  2. Provides a warning when the plugin may create a directory at the root of the drive when CMAKE_RUNTIME_OUTPUT_DIRECTORY is not set.

Edited by Keith Ballard

Merge request reports