Save/ Restore current settings as default - Properties is broken
This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
There are at least two issues with Save current settings values as default for Properties. Bigger picture, I am not sure if we want to even be able to save settings for properties. But, assuming this code is here for some purpose and some user, here are the two bugs, and how to replicate them.
-
PV 4.3.1, local server, Linux.
-
load can.exo. All vars on. Now, turn VEL off. In the blocks section, turn off the second block. Apply.
-
Save current settings values as default (for Properties).
-
Reset session. Reload can.exo. Apply. Notice that the behavior I would expect happens - we have not loaded the second block or VEL.
-
Click Restore application default settings values.
<> Nothing happens. I assume this is a bug. -
Reset session. Reload can.exo. Apply.
<> We still have not loaded the second block or VEL. So, Restore does not work. It needs to be fixed. -
Reset session.
-
Load disk_out_ref.exo. Apply.
<> Note that we still have the variables displayed in the Properties tab from can.exo!
-- Seems to me that a saved current settings value needs to be tied to a specific dataset. Further, I don't think we want more than one dataset, or the underlying json file is going to blow up to a huge size.
-- Higher level question - is this how we want to allow users to default variables and blocks on/off? Isn't a saved state a better solution? (By the way, was this implemented for one of my users? I don't remember.)