Rename VR plugins
Due to these MR: paraview!5546 (merged) paraview!5649 (merged), flags needed to be renamed.
For the openvr plugin i changed only the flags not the library name too (the actual openvr).
cc: @ken-martin @mwestphal @tiffany.chhim @cory.quammen @scott.wittenburg
Merge request reports
Activity
assigned to @spiros.tsalikis
requested review from @scott.wittenburg
- Resolved by Spiros Tsalikis
added 2 commits
- Resolved by Mathieu Westphal (Kitware)
- Resolved by Spiros Tsalikis
- Resolved by Spiros Tsalikis
added 2 commits
Used this to build paraview on Windows and Linux yesterday (with the fix you pushed this morning @spiros.tsalikis), and it produced usable binaries. I didn't enable XRInterface on Linux, but CAVEInteraction loaded fine. On Windows, both plugins loaded successfully, and I was able to use XRInterface as expected.
+1
Have you seen the following error again? Mac keeps on complaining.
CPack Verbose: Install configuration: "Release" CMake Error at /opt/glr/paraview/paraview-ci/build/cpack/paraview/DragNDrop/build/cmake_install.cmake:53 (message): Failed to install ParaView-master-5.10.1-1239-ga5abf6e498.app: env: python2.7: No such file or directory CPack Error: Error when generating package: ParaView CMake Error at /opt/glr/paraview/paraview-ci/superbuild/cmake/scripts/package_test.cmake:25 (message): CPack failed with exit code 1
Edited by Spiros TsalikisNo I haven't seen that. But looking at CDash quickly, it seems it not only happened on this MR in the last few days, but happened on master as well:
https://open.cdash.org/testSummary.php?project=9&name=cpack-paraview-DragNDrop&date=2022-05-16
So I don't think it's related to this change, but maybe @ben.boeckel knows for sure.
@ben.boeckel shall i ignore it and merge?
Do: merge
Edited by Spiros Tsalikis@scott.wittenburg since there is no bot here (as it seems), would you mind merging this MR?
There IS a bot here, it may be broken ? @ben.boeckel
Do:merge
The robot doesn't understand arbitrary syntax.
Edited by Spiros Tsalikis 4 hours ago
GitLab informs no one that comments are edited, so the robot cannot act on edits (and would be dangerous to do so anyways).
Edited by Ben Boeckel
mentioned in commit debff4cf