ffmpeg: pass along CMAKE_OSX_SYSROOT to the linker

Doing so sets the SDK version in the binary, which was previously missing. When the SDK is missing, code verification during loading fails, preventing ParaView from starting.

With this change

> otool -l install/lib/libavformat.dylib | grep sdk
>     sdk 10.15.6

Without this change

> otool -l install/lib/libavformat.dylib | grep sdk
>     sdk n/a

Fixes #54 (closed).

Errors:

• This branch is ineligible for the paraview/5.8.x branch; it needs to be based on a commit before 6b0d7161.

Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

@ben.boeckel does kwrobot need to be updated? This is a change needed for ParaView 5.9. Thanks.

We haven't needed a paraview/release branch for the superbuild yet. We'll make it if/when needed.

Huh? https://gitlab.kitware.com/paraview/common-superbuild/-/tree/paraview/release

Or do you mean to just point paraview-superbuild master and release branches to the same common-superbuild commit?

added 2 commits

• 57bcf4b3 - 1 commit from branch master
• acc901d1 - ffmpeg: pass along CMAKE_OSX_SYSROOT to the linker

Compare with previous version

changed the description

changed the description

Please review, @ben.boeckel.

+1 Looks reasonable.

Thanks!

Do: merge

mentioned in commit b0778749

merged