Skip to content

Fix conduit node C++ wrapping

Francois Mazen requested to merge francois.mazen/catalyst:fix_conduit_node_wrapping into master

Current implementation of conduit_cpp::cpp_node leads to unwanted behavior when sub-keys are added or removed.

This patch changes the implementation with c_node* share and a boolean to check ownership when deleting the wrapper.

It's not perfect because deleting the original node before the wrappers could leads to crash. It does not invalidate the wrappers and the c_node* points to freed memory. A better approach would be to have a reference counter but it's too complex for the initial need of catalyst_results and catalyst_about.

Related to paraview#20855 (closed)

Edited by Francois Mazen

Merge request reports