Brad King authored 3 years ago and Kitware Robot committed 3 years ago

c8ec137d VS: Update Visual Studio 17 2022 generator for Preview 3.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6480

Issue: #22339

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

49a5dbca GNUInstallDirs: avoid unwanted variable dereference

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6474

Merge-request: !6474

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

25c5ebba VS: Add special case for '-T version=14.29.16.11' under VS 16.11

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6469

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

d2a6e160 AUTOUIC: Revert "Fix generating of dependency rules for UI header files"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !6465

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

2b2a6a71 FindMPI: do not detect `-framework` as a compile flag

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !6467

In some situations, it seems that the variable `0` is defined. In the
case found, it was set to `1`. This makes the detection of the missing
third argument bogus and unnecessarily triggers a warning.

This oversight was introduced in 229b5ee9 (GNUInstallDirs: Add dir
argument to GNUInstallDirs_get_absolute_install_dir, 2020-10-31) prior
to CMake 3.20's release cycle.

Extend the table of special cases from commit 58a50a3a (VS: Fix '-T
version=14.28' under VS 16.9, 2021-03-11, v3.19.7~1^2~1) and updated by
commit a60141fe (VS: Add special case for '-T version=14.29.16.10'
under VS 16.10, 2021-05-27, v3.20.4~11^2).  Add a special case for the
name VS 17 will use for VS 16.11's default toolset, so that it can be
used with VS 16.11 too.

Issue: #21922

MPICH 3.4.2 now reports `-framework OpenCL` as one of its compilation
flag. The compile flag extraction is seeing it as a generic `-f` flag
and misses its argument. This ends up with a compile option of
`-framework` which eats the next flag (and may be very important).

It does not seem that passing `-framework` as a link flag is necessary
at this time, so that is being actively ignored for now.

Fixes: #22555

Revert commit e5ec0e52 (AUTOUIC: Fix generating of dependency rules
for UI header files, 2021-07-22, v3.21.1~8^2) because it caused
regressions.  For example, changing one C++ source can now cause many
others to rebuild.  Revert the change pending further investigation.

Fixes: #22531
Issue: #16776

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

17e4934d FindPkgConfig: Restore legacy behavior when CMP0126 is set to NEW

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6461

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

788b7aff FindBinUtils: Fall back to ld for Clang without lld

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6457

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

89ed11ae CheckLanguage: Avoid CMP0126 warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6462

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

164643fc Android: Fix NDK toolchain dir on arm64 mac

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6449

The macro's implementation converts a normal variable into a cache
variable intentionally, so both are set.  Explicitly set CMP0126 to NEW
to avoid a warning in trace mode.  This won't affect the module behavior
because the code path does not activate if a normal variable is already
defined anyway.

Fixes: #22548

Marc Chevrier authored 3 years ago and Brad King committed 3 years ago

Module behavior must be independent from `CMP0126` policy.

Fixes: #22526

Thomas Bernard authored 3 years ago and Brad King committed 3 years ago

If `lld` is not available, Clang can still use `ld`.

Fixes: #22500

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

3f9ef370 VS: Fix /reference and /headerUnit flag table entries for v142 and v143

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6445

These flags accept values in following arguments, not immediately
appended.

Fixes: #22530

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

fc1f733c BinUtils: Avoid searching CMAKE_PREFIX_PATH

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6434

Cristian Adam authored 3 years ago and Brad King committed 3 years ago

Our `find_program` calls specify `HINTS` to look in the toolchain's
directory first, and then in `PATH`.  `CMAKE_PREFIX_PATH` may be
specified by the user to help find packages for project dependencies,
but this should not override the binutils.

Fixes: #22512

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

bb19af54 Help: cmake_path: add missing parameter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6431

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

9ac426e4 NVHPC-C: Add support for C17
f5dbc27c NVHPC-CXX: Add support for C++20

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Alex <leha-bot@yandex.ru>
Merge-request: !6430

Michael Hirsch authored 3 years ago and Brad King committed 3 years ago

for cmake_path(`CONVERT` ... [NORMALIZE]) was missing in top summary

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

93eb4a7b Ninja: Revert accidental LINK_WHAT_YOU_USE impl for static libraries

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6418

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

1af23c4d macOS: Restore support for Mac OS X 10.4 (Tiger)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6426

Đoàn Trần Công Danh authored 3 years ago and Brad King committed 3 years ago

In commit d7159f95, (Ninja: Fix LINK_WHAT_YOU_USE link flag placement,
2021-06-24), we fixed usage of -Wl,--no-as-needed to override
-Wl,--as-needed from LDFLAGS. However, that change also passes
-Wl,--no-as-needed to `ar`, which is incorrect flag for `ar`.

Let's check the target type before passing down the flags.

Fixes: #22487

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

3cdf2398 CPackRPM: avoid a spurious `;` in the `%pre` and other sections with scripts

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6415

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

213fec49 add_custom_command(DEPFILE) independent from CMAKE_DEPENDS_USE_COMPILER

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6421

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

8b28fe56 Help: get_filename_component: fix version info for cmake_path

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6423

Merge-request: !6426

Evan Miller authored 3 years ago and Brad King committed 3 years ago

Since commit 4aed96e2 (Apple: Set CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG
on non-macOS too, 2021-04-06, v3.20.1~5^2) we always enable support for
linking with `-rpath`.  The intention of the change was to enable using
the flag on iOS, tvOS and watchOS by avoiding a Darwin-specific version
check.  However, removing the check broke support for OS X 10.4 because
the flag is not supported on that version.

Restore a form of the check that disables the flag on OS X < 10.5 while
still allowing it for the other Apple platforms.  Since no one is doing
iOS/tvOS/etc development on 10.4, this change should have no unintended
side effects.

Fixes: #22490

Artur Samarin authored 3 years ago and Brad King committed 3 years ago

This was accidentally added by commit 34c8a230 (CPackRPM: add
scriplets tags only if scripts exist, 2021-04-01, v3.21.0-rc1~387^2).

Fixes: #22501