- Nov 10, 2017
-
-
Brad King authored
-
Brad King authored
Merge-request: !1470 Merge-request: !1473
-
Brad King authored
A diagnostic message added in commit v3.10.0-rc1~59^2 (Windows: Improve link-time error messages when rc or mt fail, 2017-09-22) incorrectly reports the `mt /notify_update` special return code as a failure. Fix the logic to consider the special return codes as success. Fixes: #17444
-
Brad King authored
Merge-request: !1472
-
- Nov 09, 2017
-
-
Brad King authored
Merge-request: !1466
-
Brad King authored
Projects using `OPENGL_LIBRARIES` or `OpenGL::GL` expect legacy GL. Although GLVND OpenGL+GLX provides legacy GL interfaces, using those library files may conflict with legacy GL library files used by dependencies (or dependents) of such projects. Therefore we should not yet use OpenGL+GLX when a legacy GL library is available. If `OPENGL_gl_LIBRARY` is set then use it as the legacy GL library. If it is *not* set then fall back to using GLVND OpenGL+GLX to provide legacy GL interfaces. This will allow users to build projects using GLVND even if they have not been ported. Fixes: #17437
-
- Nov 08, 2017
-
-
Brad King authored
Merge-request: !1465
-
Fix a typo from commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of compiler wrappers, 2016-04-04) that accidentally used the HDF5 C++ version (which could be empty) while detecting the C patch version. The detection failed for patch releases, such as `1.10.0-patch1` becoming `.1` instead of `1.10.0.1`.
-
Brad King authored
Merge-request: !1460
-
Since commit v3.9.0-rc1~148^2 (Do not assume GCC libs are linked by all compilers, 2017-05-05) we no longer filter out all `gcc*` implicit link libraries. This allows mixing of gcc and non-gcc compilers across languages. However, this caused a subtle problem with how GCC makes exception handling symbols available to linked binaries. GCC (at least on MinGW) provides two different libraries with exception handling symbols: * gcc_s: A shared library with -fvisibility=default, used by -shared-libgcc. * gcc_eh: A static library with -fvisibility=hidden, used by -static-libgcc. The C compiler (on MinGW) defaults to -static-libgcc and uses gcc_eh. The C++ compiler defaults to -shared-libgcc and uses gcc_s when linking shared libraries and executables so that exceptions can propagate across shared libraries [1]. When linking a mixed-language binary, the C++ compiler should be used along with its choice of gcc_s. In this case gcc_eh should not be added even though the C compiler implies it because gcc_s supersedes it. Since the above-mentioned change, CMake is adding gcc_eh to C++ link lines that also contain C code on MinGW. This causes both gcc_s and gcc_eh to be used, which is incorrect. We can fix this simply by excluding gcc_eh from the C compiler's implicit link libraries. [1] https://gcc.gnu.org/onlinedocs/gcc-7.2.0/gcc/Link-Options.html#Link-Options Fixes: #17436
-
- Nov 07, 2017
-
-
Brad King authored
Merge-request: !1459
-
Brad King authored
Our comment says the logic matches that for OpenGL::GL. Structure the logic the same way to make this clearer. Issue: #17437
-
Brad King authored
Merge-request: !1449
-
When we run `csc.exe /help` we look for "Version" in the output. Explicitly ask for the output in English. Reported-by: <guttally@users.noreply.github.com>
-
- Nov 06, 2017
-
-
Brad King authored
Merge-request: !1451
-
Fixes: #17421
-
- Nov 01, 2017
-
-
Brad King authored
-
Brad King authored
Merge-request: !1435
-
Brad King authored
This was done for C++ by commit v3.5.0-rc1~69^2 (Record compile features for MinGW Clang on Windows, 2016-01-11). Make the same change for C. The `UNIX` condition on Clang C compiler features was already dropped by refactoring in commit v3.9.0-rc1~17^2~4 (Compilers: Port to use default cmake_record_lang_compile_features macros, 2017-05-10). Our documentation already claims support for this combination. This was simply an oversight when support was added for MinGW Clang C++. Issue: #15897 Issue: #15943
-
- Oct 31, 2017
-
-
Brad King authored
Merge-request: !1432
-
Sebastian Holtermann authored
-
Sebastian Holtermann authored
Closes #17418
-
- Oct 30, 2017
-
-
Brad King authored
Merge-request: !1425
-
Sebastian Holtermann authored
-
Brad King authored
Merge-request: !1422
-
Brad King authored
Merge-request: !1424
-
Test was failing in case dist macro contained a + symbol which is valid but must be escaped for using the string as a regex. Fixes #17328
-
- Oct 28, 2017
-
-
Sebastian Holtermann authored
Closes #17404
-
- Oct 27, 2017
-
-
Brad King authored
Merge-request: !1418
-
Brad King authored
Merge-request: !1408
-
-
When a STATIC_LIBRARY cycle is detected we don't add any STATIC_LIBRARY target from the cycle to the `_autogen` target dependencies. Closes #17389
-
Brad King authored
Refactoring in commit v3.10.0-rc1~115^2 (Clean up iwyu code to not be one big if statement, 2017-08-28) incorrectly changed the logic to run only one lint tool at a time. Restore support for running all tools specified on the command-line.
-
Brad King authored
These do not need to be declared in the header.
-
Brad King authored
-
- Oct 26, 2017
-
-
Brad King authored
Merge-request: !1415
-
Brad King authored
In commit v3.5.0-rc1~8^2~2 (Help: Clarify policy `CMP0040` documentation, 2016-01-28) the documentation was clarified to indicate that the target must be defined in the current directory. Do the same for the text of the policy warning itself. Fixes: #17399
-
- Oct 25, 2017
-