Brad King authored 3 years ago and Kitware Robot committed 3 years ago

6e59fd94 Process: Suppress NVHPC warning in FD_ZERO

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !213

NVHPC warns about the FD_ZERO implementation:

    warning #550-D: variable "__d0" was set but never used

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

7b0f5c20 SystemInformation: improve CPU counting on non-standard architectures

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !212

When /proc/cpuinfo does not match the expected layout the number of logical or
physical CPUs can be reported as 0. Adapt the parsing to catch the layout used
on Sparc, and ensure that the number of logical cores is never 0.

While at it slightly improve the CPU frequency checking so it also matches
Linux Sparc32.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

5b941f33 SystemTools: Adapt permissions test to MSYS
f00dd83e SystemTools: Avoid unnecessary assumption of working directory in test case
17f4af9b SystemTools: Use octal base for error messages in permission test

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !211

Orgad Shaneh authored 3 years ago and Brad King committed 3 years ago

Cygwin/MSYS uses umask on *stat* when noacl is set on the filesystem
(which MSYS sets by default), so the returned permissions don't
necessarily reflect what was actually set.

Solve by delaying umask to where it is actually needed.

Orgad Shaneh authored 3 years ago and Brad King committed 3 years ago

It matches the chmod notation, and easier to read on test failure.

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

a95f61cf SystemTools: Return Status from symlink operations
0664553b SystemTools: Return Status from copy operations
6aec6af9 SystemTools: Return Status from ChangeDirectory
2446b205 SystemTools: Return Status from MakeDirectory
ab198a22 SystemTools: Return Status from GetShortPath
06216f0b SystemTools: Return Status from FileTimeCompare
fadfd7a0 SystemTools: Return Status from Touch
c5a99e59 SystemTools: Return Status from GetPermissions and SetPermissions
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !210

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

9a6d6c54 Terminal: Avoid using Windows functions on Cygwin

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !209

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

4c61b968 SystemTools::FileIsFullPath: Do not accept Windows paths on Cygwin

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !208

Lemures Lemniscati authored 3 years ago and Brad King committed 3 years ago

Cygwin patch:

    https://cygwin.com/pipermail/cygwin-patches/2021q1/011276.html

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

dd703ac6 SystemTools: make file copying mechanisms public

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !207

CMake will use these in its own file copying routines (which will
capture errors).

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

7ee0dbee Directory: capture the error message
2a118b34 SystemTools: use nullptr in Windows-only code
f69c5cb7 Directory: return a bool literal on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !206

Instead of ignoring the argument completely.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

3ba8a6de Glob: Change deleted ctor and operator= from private to public

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !205

Sean McBride authored 4 years ago and Brad King committed 4 years ago

Some compilers first error that the deleted member is private before
erroring that it is deleted.

Suggested-by: Ben Boeckel <ben.boeckel@kitware.com>

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

45e42f63 SystemInformation: Improve ParseSysCtl error checking

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !204

Sean McBride authored 4 years ago and Brad King committed 4 years ago

- ensure the return value of every sysctlbyname call is checked.
  On Apple Silicon aka arm64 some of them do return an error,
  for example hw.cpufrequency, and we were getting nonsense values.
- when sysctlbyname returns an error, always provide a fallback value
- be a bit more paranoid about leaving space for null termination in temp buf
- corrected "machdep.cpu.model" and "machdep.cpu.stepping" from int64 to int32,
  as documented.
- added Apple to the Manufacturer enum

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

6e51fe76 FStream: Add std::fstream wrapper for in/out file streams

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !203

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

fca5ad3a Process: Fix execute error handling re working dir on windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !202

This should help fix cmake issue 21439.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

e6cc4679 SystemInformation: Add Zhaoxin x86 processor

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !201

DylanFan1 authored 4 years ago and Brad King committed 4 years ago

Add Zhaoxin CPU Vendor ID ("Shanghai" and "CentaurHauls") detection.