Brad King authored 5 years ago and Kitware Robot committed 5 years ago

c2420a42 SystemTools: Revert "CopyFileIfDifferent: Ensure that source is a file"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !165

The change in commit 573713fa (SystemTools: CopyFileIfDifferent: Ensure
that source is a file, 2020-02-11) breaks existing behavior w.r.t.
symbolic links.  Revert it pending further investigation.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

573713fa SystemTools: CopyFileIfDifferent: Ensure that source is a file

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !163

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

2581cfd1 SystemTools: Update EnableMSVCDebugHook to simulate "Retry"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !159

Update our report handler to pretend that the user pressed "Retry".
This will continue with what would have happened if there were no
debug hook, such as actually abort()ing the process.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

dfd0521e Terminal: Support GNU make's TTY notification environment variable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !158

Paul Smith authored 5 years ago and Brad King committed 5 years ago

Starting with release 4.0, GNU make provides for collecting recipe
output and printing it all at once after the recipe is complete, as
well as ensuring that only one rule is printing output at a time.
This allows parallel builds without mangled output.

However, it means that programs run by make do not have a TTY for
their stdout or stderr: make is collecting this.

GNU make 4.1 and above will set an environment variable MAKE_TERMOUT
to a non-empty value if make believes that after it's done collecting
stdout, the results will be displayed on a TTY.

This patch teaches KWsys to check that environment variable and if
set, proceed as if output is going to a TTY.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

a5248df0 CTestCustom: Suppress PGI Community Edition compiler license warnings
b019deea RegularExpression: Suppress VS 2013 warning C4351

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !157

These are not useful in nightly testing results.

The compiler warns on use of `{}` initialization of array members:

    warning C4351: new behavior: elements of array '...' will be
                   default initialized

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

680ab6d2 FStream: Expose is_open publicly
0492cad3 SystemTools: Remove redundant ToWindowsExtendedPath calls

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !155

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

cdd52ce1 RegularExpression: Initialize RegularExpressionMatch arrays fully

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !156

The `RegularExpressionMatch` class added by commit cff58f07
(RegularExpression: New RegularExpressionMatch class, 2017-12-04) has
members with array-of-pointer types.  Use uniform initialization
syntax to initialize all array elements on construction.

This fixes a Clang scan-build 7 warning:

```
RegularExpression.hxx:138:23: warning: The left operand of '==' is a garbage value
  if (this->startp[n] == nullptr) {
      ~~~~~~~~~~~~~~~ ^
```

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

569a1aed Encoding: Add ToWindowsExtendedPath support for wide string

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !153

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

46c55893 Replaced several 0, NULL, and KWSYS_NULLPTR with nullptr
419aaa35 Fixed -Wunused-macros warnings
750da75a Fixed 64 to 32 bit truncation warning by casting
30de8e17 Fixed -Wsign-conversion warnings by adding casts
4de1241f Fixed -Wextra-semi-stmt warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !152

Sean McBride authored 5 years ago and Brad King committed 5 years ago

- Find/replace of KWSYS_NULLPTR with nullptr
- Find/replace of NULL with nullptr
- Manually fixed -Wzero-as-null-pointer-constant warnings
- Careful review to fix some comments, string output, etc.

Sean McBride authored 5 years ago and Brad King committed 5 years ago

- Removed unused defines
- Conditionalized others

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

38486236 SystemTools: do not special case a junction in RemoveFile

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !150

Jon Chronopoulos authored 5 years ago and Brad King committed 5 years ago

The fix in commit 9f6cd407 (SystemTools: Fix removing of soft links to
directories on Windows., 2017-12-14) made the infastructure added by
commit de83c4d4 (SystemTools: support deleting junction points,
2016-02-17) unnecessary.  Remove it.

Before this commit, when a file on Windows was deleted, it would check
if a file is a junction and then delete just the junction.

Now just skip the special case of a junction and allow the rest of the
code to delete it correctly. Can handle symlinks and junctions.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

9afecb09 SystemTools: fix typo in junction functions

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !151

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

f73d1b4f SystemTools: factor out "dest is directory" case from CopyFileIfDifferent()
1ed70242 tests: verify SystemTools::CopyFileIfDifferent()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !147

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

b747462d CMake: drop needless x${VAR} tricks

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !148

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

5ca03af6 SystemTools: Revert "Reduce scope of 'buf' variable in CollapseFullPath"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !146

Revert commit 6e36d909 (SystemTools: Reduce scope of 'buf' variable in
CollapseFullPath, 2019-06-18).  A pointer to the buffer is returned by
`Getcwd` and stored in `res_in_base`.  The buffer must remain valid for
the lifetime of that variable.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

c6f8e24a SystemTools: Fix CollapseFullPath with relative base path
15896025 SystemTools: Use C++11 in SystemToolsAppendComponents

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !145

Although `CollapseFullPath` is meant to construct a full path, it
is possible that a caller will provide a relative base path.
In this case, keep leading `../` components from the base path
instead of discarding them.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

6c3dfd25 CommandLineArguments: initialize internal class members directly
a93bc28c SystemTools: Drop unnecessary .c_str()
6e36d909 SystemTools: Reduce scope of 'buf' variable in CollapseFullPath
31f5cdeb RegularExpression: Initialize private members on construction
116a4919 RegularExpression: Reduce scope of 'len' variable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !143