```
testSystemTools.cxx:901:32: warning: comparison of integers of different
  signs: 'size_type' (aka 'unsigned long') and 'long' [-Wsign-compare]
    if (!result || line.size() != size) {
                   ~~~~~~~~~~~ ^  ~~~~
```

Gregor Jasny authored 8 years ago and Brad King committed 8 years ago

Logic for the size limit argument added by commit 521c5483 (added a
limit to the getline method, 2007-03-01) had an off-by-one error in
truncating the buffer.  Fix it and add a test case.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

e25eb8dc CONTRIBUTING: Add step for running developer setup script
4b7bf8e4 Tell Git not to export any `.sh` or `.bash` scripts

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4

Our new scripts `update-gitsetup.bash` and `update-third-party.bash`
should not be exported by `git archive`.  Furthermore, they should be
checked out with LF newlines.  Update `.gitattributes` accordingly.

140357ea CONTRIBUTING: Document contribution through the Kitware GitLab Instance
56b707dd README: Add section about reporting bugs
33f828d4 README: Convert from `.txt` to `.rst` markup
5f206c3a Tell Git to use a distinct conflict marker size in `.rst` files
17a1200c Convert developer setup scripts away from Gerrit Code Review
41a7fe5b Add pre-commit hook to check whether SetupForDevelopment must re-run

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !1

Replace the instructions that routed contributors to our old Wiki with
new instructions routing them to our GitLab instance.

Move it out of `CONTRIBUTING.rst`.

Also add sections on licensing and contribution instructions.

Use a long conflict marker size that is unlikely to be in conflict
with a `=======` section header underline.

KWSys development is moving away from the Gerrit Code Review system.
Disable portions of `SetupForDevelopment.sh` related to Gerrit.

Add a version number to the `SetupForDevelopment.sh` script and use
a pre-commit hook to check when it changes.

365edba8 GitSetup: Tell Git not to export .gitattributes
1d71c502 Merge branch 'upstream-GitSetup' into developer-setup
868c1e68 GitSetup 2016-12-13 (cd5ada6d)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3

GitSetup upstream added an attribute to export `.gitattributes` so that
importing snapshots into the sources of other projects would bring along
the attributes.  However, we don't want to export them from KWSys.  Drop
`.gitattributes` entries not relevant to KWSys.

* upstream-GitSetup:
  GitSetup 2016-12-13 (cd5ada6d)

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Code extracted from:

    https://gitlab.kitware.com/utils/gitsetup.git

at commit cd5ada6d5626da409d3ff108c341b9afd615803f (setup).

32d94e8e Merge branch 'upstream-GitSetup' into developer-setup
a0144297 GitSetup 2016-12-13 (8af10838)
b606857a Merge branch 'upstream-GitSetup' into developer-setup
98505f79 Add script to update GitSetup from upstream
fed3d191 GitSetup 2012-09-27 (341043cf)
e0967411 Add a script to help update third-party sources

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2

* upstream-GitSetup:
  GitSetup 2016-12-13 (8af10838)

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Code extracted from:

    https://gitlab.kitware.com/utils/gitsetup.git

at commit 8af1083866f06d8a65d7565367e1ca7545b9e919 (setup).

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Code extracted from:

    https://gitlab.kitware.com/utils/gitsetup.git

at commit 341043cf (setup).

Ben Boeckel authored 8 years ago and Brad King committed 8 years ago

Use the CMake `Utilities/Scripts/update-third-party.bash` script as
of commit dcb2e39fda75ef20b950fe293bbc989e95adbdec.

Co-Author: Brad King <brad.king@kitware.com>

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: I941dcebe0193112f0d5aaf77cac55246febe4d3c

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

The `std::string` and `std::wstring` types are allowed to contain null
(`0`) bytes.  Teach Encoding::{ToNarrow,ToWide} to preserve them.

Change-Id: If9ddb77d275c1365016f2f1fa811d0c06e46d5f2

Chuck Atkins authored 8 years ago and Brad King committed 8 years ago

Rather than just testing for explicit platforms in the dynamic loader,
i.e. old BlueGene and Cray systems, leverage CMake's platform knowlege
to determine if shared libraries are supported.

Change-Id: I6189bcfb6d528cf4c96a40be2b31af981d09dbb2

Change-Id: I4993716a1efebd32b3b0fc3e992c1b29f5305fe0

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: Ib81221af43ee592b461b5d3c0437c46c2be0488d

Make KWSys honor visibility properties set by the consuming project.

Change-Id: I66b982d955089bc78f88e29c4a7bc19bf2abec00

Use a loop to avoid code duplication and comment the purpose of each
policy.

Change-Id: Id81c24868f89236dab3477034653e6a05321c696

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: Ib9f72534e2715ca6230b212231e4133e29bcab31

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

This allows to change ConsoleBuf parameters such as used codepages.

Change-Id: I35c9262ada27b3817f8e3e52b235dc754d1bdd4b

Change-Id: I9861bf74cfbababeeb559652123fff60bb16edc8

Fix the path to the script within this source tree in example commands.

Change-Id: Iee85cf12b2cf49eea7959685fe9bec223f7c1ff2

Matt Leotta authored 8 years ago and Brad King committed 8 years ago

DNS lookup on loopback devices is not needed to find the FQDN and just
slows down this function, especially when the DNS lookup times out.

Change-Id: I3f8b565cf8786b92cfef23b693c3c4fab57a904e

In commit 15e90a3c (Sort includes to stabilize include order w.r.t.
clang-format, 2016-11-04) we forgot to move `Configure.hxx` into its own
block to ensure it remains first.  Restore the original include order
and add separating blanks to make it stable w.r.t. clang-format.

Change-Id: Ibca524065147192da916ad98d7db3c5d86b26a5a

These files are only for development of KWSys itself and are not
needed when the source tree is merged into clients.

Change-Id: Ie4a42cae5bcf8993df958af178d3c5359684c598

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a new
style defined by `.clang-format`.  Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5

This is an empty commit that precedes an automatic application of
clang-format to update the C++ style of our entire source tree.
This may be helpful to rebase a topic branch that was originally
based on a commit preceding the transition.  One may first rebase
the topic on this commit.  Then use one of the following approaches.

*   Rewrite the topic, including this commit, using `git filter-branch`
    `--tree-filter` with `clang-format.bash` to update the style in
    every commit.  Rebase the revised topic, excluding the rewrite of
    this commit, on the style transition commit.

OR

*   Add a `.git/info/grafts` entry to change the parent of the first
    commit in the topic from this commit to the style transition commit.
    Rewrite the topic using `git filter-branch --tree-filter` with
    `clang-format.bash` to update the style in every commit.  Then
    remove the graft, which was resolved by the filter.

See `git help filter-branch` and `git help repository-layout` for
details.

Change-Id: Ieab41df4c10872a91c974330d27abd292e2da510

Document that we now define our coding style with `clang-format`.

Change-Id: I6dea8c3816f277b0e56e074ccd6c64a2cfeb094c