- May 13, 2020
-
-
775296c8 Applied clang-tidy bugprone-suspicious-string-compare fixes 2c179921 Applied clang-tidy modernize-deprecated-headers cb541c31 Auto-fixed various clang-tidy warnings Acked-by:
Kitware Robot <kwrobot@kitware.com> Merge-request: !185
-
a19f0ac6 Fixed clang -Wstrict-prototypes warning Acked-by:
-
- May 11, 2020
-
-
Sean McBride authored
-
- May 08, 2020
-
-
Sean McBride authored
-
Sean McBride authored
-
Sean McBride authored
-
- Apr 23, 2020
-
-
c58d4b47 SystemTools: On Windows, strip 'e' from Fopen mode Acked-by:
-
- Apr 22, 2020
-
-
The MSVC runtime does not support the 'e' mode specifier.
-
- Apr 21, 2020
-
-
00629420 SystemInformation: Add support for Windows on ARM64 Acked-by:
-
Update preprocessor defines and intrinsics.
-
- Apr 17, 2020
-
-
b8177b56 testProcess: Disable unreliable test case 7 Acked-by:
-
39fd4817 testProcess: fix another clang-tidy warning Acked-by:
-
- Apr 16, 2020
-
-
Brad King authored
This test fails very frequently on CI because it relies on the timing of process scheduling by the OS, which is not deterministic. Disable it.
-
- Apr 15, 2020
-
-
Ben Boeckel authored -
de210648 clang-tidy: address `readability-else-after-return` lint 535633fa clang-tidy: address `readability-isolate-declaration` lint 83b20b65 clang-tidy: address `readability-braces-around-statements` lint Acked-by:
-
- Apr 13, 2020
-
-
Ben Boeckel authored
-
Ben Boeckel authored
-
Ben Boeckel authored
-
- Apr 10, 2020
-
-
986519af SystemTools: handle splitting a string starting with the separator 09942f51 testSystemTools: add tests for SplitString Acked-by:
-
- Apr 09, 2020
-
-
If a string started with the separator, the first component would have the separator included in it.
-
-
ebb48d58 clang-tidy: address google-readability-casting lint 13b45a41 clang-tidy: address readability-else-after-return lints 87b57076 clang-tidy: address readability-braces-around-statements lints ccab3808 clang-tidy: address readability-isolate-declaration lints Acked-by:
-
-
-
-
-
41700ca4 SystemTools: Fix FileIsExecutable on Windows Acked-by:
-
Brad King authored
Since commit 66724af8 (SystemTools: Teach FindProgram to find non-readable programs, 2020-04-04), `FindProgram` uses the new `FileIsExecutable` method. On Windows this changed the check from `GetFileAttributesW` to `_waccess`, but the latter returns success even for Windows Store stubs like %USERPROFILE%\AppData\Local\Microsoft\WindowsApps\python.exe Since the goal of the original change was to fix executable permissions checks on UNIX-like platforms, simply restore the old check code on Windows.
-
- Apr 07, 2020
-
-
66724af8 SystemTools: Teach FindProgram to find non-readable programs Acked-by:
-
- Apr 06, 2020
-
-
e3989b18 SystemTools: Restore GetCurrentWorkingDirectory slash conversion on Windows Acked-by:
-
-
This commit fixes FindProgram failing to detect executable without read bit set. find_program internally uses SystemTools::FileExists which calls access(R_OK) instead of access(X_OK). Replacing SystemTools::FileExists with SystemTools::TestFileAccess fixes this issue. Fine example of such program is sudo.
-
c35a377f SystemTools: Refactor CollapseFullPath to call getcwd only when needed 019afb6e SystemTools: Drop GetCurrentWorkingDirectory 'collapse' argument 313b2f7a SystemTools: Make SystemToolsStatic singleton private to implementation file Acked-by:
-
- Apr 04, 2020
-
-
Brad King authored
Many calls to the one-argument `CollapseFullPath` variant already have an absolute path and just need to collapse it. Avoid calling `getcwd` if the result is not needed because it can be an expensive syscall.
-
Brad King authored
The result of `getcwd` is always an absolute canonical path and does not need to be collapsed.
-
Brad King authored
-
- Apr 01, 2020
-
-
4b537c59 Tests: Handle that root users on linux can always write to files Acked-by:
-
- Mar 31, 2020
-
-
It is common when running software from a container setup such as docker that the user is root. Because of this, some permission checks are pointless as the root user ( uid=0 ) can always do things such as write to files.
-
- Mar 25, 2020
-
-
0085096e avoid std::string::find() to check for prefix e3c051e2 SystemTools: create directories with the right permissions on Un*x bc9a4256 avoid inefficient usage of std::string::substr() 420c3b04 call std::string::clear() instead of assigning "" 8b1a29e1 optimize SystemToolsParseRegistryKey() Acked-by:
-
- Mar 24, 2020
-
-
Rolf Eike Beer authored
Use compare() instead which will terminate faster if things don't match.
-
