The check finds function parameters of a pointer type that could be changed to
point to a constant type instead.

When const is used properly, many mistakes can be avoided. Advantages when
using const properly:
 - prevent unintentional modification of data;
 - get additional warnings such as using uninitialized data;
 - make it easier for developers to see possible side effects.

This check is not strict about constness, it only warns when the constness will
make the function interface safer.

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`.  Use `clang-format` version 6.0.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

luzpaz authored 7 years ago and Brad King committed 7 years ago

Found using

    codespell -q 3 --skip="./Utilities" -I .cmake-whitelist.txt`

in CMake whereby the whitelist contained:

    ans
    dum
    helpfull
    emmited
    emmitted
    buil
    iff
    isnt
    nto
    ot
    pathes
    substract
    te
    todays
    upto
    whitespaces

Adam Weisi authored 7 years ago and Brad King committed 7 years ago

When running a pipeline of child processes, provide clients a way
to get individual results.

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a new
style defined by `.clang-format`.  Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5

Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool.  Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience.  Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.

Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices.  It also references version control
history for more precise information.  Therefore we no longer need to spell
out the list of Contributors in each source file notice.

Replace KWSys per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online
information available from "https://cmake.org/licensing#kwsys".

Run the `filter-notices.bash` script to perform the replacements mechanically.
Manually fix up the shebang line in one file.

Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334

Zack Galbreath authored 9 years ago and Brad King committed 9 years ago

Change-Id: I7d588cb060ea17ed4221c55b866cbbebab983e3c

James Johnston authored 9 years ago and Brad King committed 9 years ago

kwsysProcess_SetOption now allows you to specify a new
kwsysProcess_Option_CreateProcessGroup option, which creates the
process in a new process group (Windows/UNIX) and a new session
(UNIX).  Child process groups receive signals separately from their
parents.  This allowed for the introduction of the new
kwsysProcess_Interrupt function, which allows one to safely request
the child process in its own group to terminate.  The Ctrl+C handler
also manually sends that signal to child process groups, since it's
no longer automatic.

Change-Id: Id0a420ad65f1b1c1d299ac0eb95fbb8b50a52409

When enabled, ignore all stderr pipe configuration options and
just give the child a copy of stdout as its stderr.

Change-Id: I87a64657cc701b706da78f7bfc56ad0071383372

This converts the KWSys license to a pure 3-clause OSI-approved BSD
License.  We drop the previous license clause requiring modified
versions to be plainly marked.  We also update the KWSys copyright to
cover the full development time range.

All KWSys C symbol names begin with the KWSYS_NAMESPACE defined at
configuration time.  For ease of editing we write canonical names with
the prefix 'kwsys' and use macros to map them to the configured prefix
at preprocessing time.  In the case of standalone KWSys, the prefix is
'kwsys', so the macros were previously defined to their own names.

We now skip defining the macros in the identity case so that the final
symbol names are never themselves macros.  This will allow the symbols
to be further transformed behind the scenes to help linkers in special
cases on some platforms.

ENH: Added Process_SetPipeNative method to allow user code to override the pipes connected to the child pipeline.

ENH: Moved kwsys_ns and kwsysEXPORT macros to Configure.h in the case of building a kwsys source file.  This allows more than one header to be included in a kwsys source file without redefining the macros.

ENH: Do kwsys testing as part of cmake testing, command line arguments are not experimental and add simple test for systemtools

ENH: Added kwsysProcess_Disown an kwsysProcess_Option_Detach to allow detached processes to be created.  Currently implemented only on UNIX.

ERR: Avoiding namespace pollution: kw_sys -> kwsys_ns.  Also undefining the macro at the correct time.

ERR: On Borland preprocessor goes into recursion which adds some weid spaces in the include name. This fixes it

ENH: Added GetExceptionString method to provide an error description when GetState returns Exception.

ENH: Added SetPipeShared method to allow stdout and stderr pipes to be shared with the parent process.

ENH: Added SetPipeFile method to allow the process pipeline stdin, stdout, and stderr to be redirected from/to files.

ENH: Removed pipe selection argument from WaitForData method in kwsysProcess.  This greatly simplifies its use.

ERR: Reduced requirements on preprocessor for export macro due to limitations of Mac preprocessor.  The preprocessor can be fixed by using -no-cpp-precomp, but we don't want to require that option for every source file that includes our headers.

ENH: Added documentation to interface.  Finished process exit code interpretation implementation prototype.