Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d22c2743 clang-format.bash: Use Git attributes to mark files for formatting
6365886c Define a custom Git attribute to mark sources using our C style
0af48083 Drop custom Git whitespace check attribute

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !18

Git does not document a `no-lf-at-eof` attribute.  It was once used
by our custom hooks, but these have been superseded by clang-format.

858d5edd Encoding: Export CommandLineArguments from shared library
04e24b2b ConsoleBuf: Remove export macro from BasicConsoleBuf template
ce44c58a FStream: Export ReadBOM() from shared library

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !16

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

858d5edd Encoding: Export CommandLineArguments from shared library
04e24b2b ConsoleBuf: Remove export macro from BasicConsoleBuf template
ce44c58a FStream: Export ReadBOM() from shared library

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !16

Egor Pugin authored 8 years ago and Brad King committed 8 years ago

The uninstantiated template itself cannot be exported.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

c5529406 SystemTools: use std::string::empty

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !15

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

27e64d34 SystemInformation: Teach Is64Bits to check host architecture at runtime

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !13

Robert Maynard authored 8 years ago and Brad King committed 8 years ago

The previous implementation used compile-time detection, making it have
incorrect results when running 32bit binaries on 64bit platforms.

Issue: cmake/cmake#16653

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

a673a722 SystemInformation: Fix -Wconversion warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !12

Fix warning introduced by commit 9c4230b7 (SystemInformation: Fix counts
of logical and physical cores, 2017-01-26).

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

9c4230b7 SystemInformation: Fix counts of logical and physical cores

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !10

Nicolás Bértolo authored 8 years ago and Brad King committed 8 years ago

Issue: cmake/cmake#16594

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

8d8c86b5 testConsoleBuf: tighten the check for the /utf-8 flag

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !11

It appears that Visual Studio 2015 Update 1 lacks this flag. Update 3
includes it; Update2 is unknown.

See cmake/cmake#16623.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d6b87625 SystemTools: Add helper function to check for FIFO file type

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !9

Gregor Jasny authored 8 years ago and Brad King committed 8 years ago

Issue: cmake/cmake#16607

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

45db0937 SystemTools: use PathExists where appropriate

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

e08eee61 SystemTools: Fix conversion warning in test case

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !8

```
testSystemTools.cxx:901:32: warning: comparison of integers of different
  signs: 'size_type' (aka 'unsigned long') and 'long' [-Wsign-compare]
    if (!result || line.size() != size) {
                   ~~~~~~~~~~~ ^  ~~~~
```

687fcd79 Add -lsocket for libcmsys.a build on SunOS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

0541ce21 SystemTools: Fix off-by-one in GetLineFromStream with size limit

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6

The `Touch` method should care about existence and directory creation
should also be guarded against unreadable paths as well. In addition,
fix a path existence check which should have been updated before.

Gregor Jasny authored 8 years ago and Brad King committed 8 years ago

Logic for the size limit argument added by commit 521c5483 (added a
limit to the getline method, 2007-03-01) had an off-by-one error in
truncating the buffer.  Fix it and add a test case.

Without this the linking of code using
Source/kwsys/SystemInformation.cxx will
have undefined Symbols on Solaris 11.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

e25eb8dc CONTRIBUTING: Add step for running developer setup script
4b7bf8e4 Tell Git not to export any `.sh` or `.bash` scripts

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4

Our new scripts `update-gitsetup.bash` and `update-third-party.bash`
should not be exported by `git archive`.  Furthermore, they should be
checked out with LF newlines.  Update `.gitattributes` accordingly.

140357ea CONTRIBUTING: Document contribution through the Kitware GitLab Instance
56b707dd README: Add section about reporting bugs
33f828d4 README: Convert from `.txt` to `.rst` markup
5f206c3a Tell Git to use a distinct conflict marker size in `.rst` files
17a1200c Convert developer setup scripts away from Gerrit Code Review
41a7fe5b Add pre-commit hook to check whether SetupForDevelopment must re-run

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !1

Replace the instructions that routed contributors to our old Wiki with
new instructions routing them to our GitLab instance.

Move it out of `CONTRIBUTING.rst`.

Also add sections on licensing and contribution instructions.

Use a long conflict marker size that is unlikely to be in conflict
with a `=======` section header underline.

KWSys development is moving away from the Gerrit Code Review system.
Disable portions of `SetupForDevelopment.sh` related to Gerrit.

Add a version number to the `SetupForDevelopment.sh` script and use
a pre-commit hook to check when it changes.