Brad King authored 4 years ago and Kitware Robot committed 4 years ago

97f880e6 Directory: add extra tests involving errorMessage
f33ef4e3 Glob: issue warnings on Directory errors
9a3f9799 Directory: implement error reporting

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !187

The current implementation HandleGlobImpl with throw fatal errors for
all Glob::MessageType other than cyclicRecursion. This will need to be
addressed in cmake.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

775296c8 Applied clang-tidy bugprone-suspicious-string-compare fixes
2c179921 Applied clang-tidy modernize-deprecated-headers
cb541c31 Auto-fixed various clang-tidy warnings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !185

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

a19f0ac6 Fixed clang -Wstrict-prototypes warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !186

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

c58d4b47 SystemTools: On Windows, strip 'e' from Fopen mode

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !184

Sean McBride authored 4 years ago and Brad King committed 4 years ago

The MSVC runtime does not support the 'e' mode specifier.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

00629420 SystemInformation: Add support for Windows on ARM64

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !183

Hernan Martinez authored 4 years ago and Brad King committed 4 years ago

Update preprocessor defines and intrinsics.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

b8177b56 testProcess: Disable unreliable test case 7

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !182

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

39fd4817 testProcess: fix another clang-tidy warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !181

This test fails very frequently on CI because it relies on the
timing of process scheduling by the OS, which is not deterministic.
Disable it.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

de210648 clang-tidy: address `readability-else-after-return` lint
535633fa clang-tidy: address `readability-isolate-declaration` lint
83b20b65 clang-tidy: address `readability-braces-around-statements` lint

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !180

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

986519af SystemTools: handle splitting a string starting with the separator
09942f51 testSystemTools: add tests for SplitString

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !178

Ben Boeckel authored 4 years ago and Brad King committed 4 years ago

If a string started with the separator, the first component would have
the separator included in it.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

ebb48d58 clang-tidy: address google-readability-casting lint
13b45a41 clang-tidy: address readability-else-after-return lints
87b57076 clang-tidy: address readability-braces-around-statements lints
ccab3808 clang-tidy: address readability-isolate-declaration lints

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !177

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

41700ca4 SystemTools: Fix FileIsExecutable on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !179

Since commit 66724af8 (SystemTools: Teach FindProgram to find
non-readable programs, 2020-04-04), `FindProgram` uses the new
`FileIsExecutable` method.  On Windows this changed the check
from `GetFileAttributesW` to `_waccess`, but the latter returns
success even for Windows Store stubs like

  %USERPROFILE%\AppData\Local\Microsoft\WindowsApps\python.exe

Since the goal of the original change was to fix executable
permissions checks on UNIX-like platforms, simply restore the
old check code on Windows.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

66724af8 SystemTools: Teach FindProgram to find non-readable programs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !175

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

e3989b18 SystemTools: Restore GetCurrentWorkingDirectory slash conversion on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !176

Since commit 019afb6e (SystemTools: Drop GetCurrentWorkingDirectory
'collapse' argument, 2020-04-03) the return value of this method uses
backslashes.  Restore conversion to forward slashes.

Vladimir authored 4 years ago and Brad King committed 4 years ago

This commit fixes FindProgram failing to detect executable without
read bit set. find_program internally uses SystemTools::FileExists which
calls access(R_OK) instead of access(X_OK).
Replacing SystemTools::FileExists with SystemTools::TestFileAccess fixes
this issue.

Fine example of such program is sudo.

Brad King authored 4 years ago and Kitware Robot committed 4 years ago

c35a377f SystemTools: Refactor CollapseFullPath to call getcwd only when needed
019afb6e SystemTools: Drop GetCurrentWorkingDirectory 'collapse' argument
313b2f7a SystemTools: Make SystemToolsStatic singleton private to implementation file

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !174

Many calls to the one-argument `CollapseFullPath` variant already have
an absolute path and just need to collapse it.  Avoid calling `getcwd`
if the result is not needed because it can be an expensive syscall.

The result of `getcwd` is always an absolute canonical path and does not
need to be collapsed.