Sean McBride authored 5 years ago and Brad King committed 5 years ago

- Find/replace of KWSYS_NULLPTR with nullptr
- Find/replace of NULL with nullptr
- Manually fixed -Wzero-as-null-pointer-constant warnings
- Careful review to fix some comments, string output, etc.

Sean McBride authored 5 years ago and Brad King committed 5 years ago

- Removed unused defines
- Conditionalized others

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

38486236 SystemTools: do not special case a junction in RemoveFile

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !150

Jon Chronopoulos authored 5 years ago and Brad King committed 5 years ago

The fix in commit 9f6cd407 (SystemTools: Fix removing of soft links to
directories on Windows., 2017-12-14) made the infastructure added by
commit de83c4d4 (SystemTools: support deleting junction points,
2016-02-17) unnecessary.  Remove it.

Before this commit, when a file on Windows was deleted, it would check
if a file is a junction and then delete just the junction.

Now just skip the special case of a junction and allow the rest of the
code to delete it correctly. Can handle symlinks and junctions.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

9afecb09 SystemTools: fix typo in junction functions

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !151

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

f73d1b4f SystemTools: factor out "dest is directory" case from CopyFileIfDifferent()
1ed70242 tests: verify SystemTools::CopyFileIfDifferent()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !147

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

b747462d CMake: drop needless x${VAR} tricks

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !148

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

5ca03af6 SystemTools: Revert "Reduce scope of 'buf' variable in CollapseFullPath"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !146

Revert commit 6e36d909 (SystemTools: Reduce scope of 'buf' variable in
CollapseFullPath, 2019-06-18).  A pointer to the buffer is returned by
`Getcwd` and stored in `res_in_base`.  The buffer must remain valid for
the lifetime of that variable.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

c6f8e24a SystemTools: Fix CollapseFullPath with relative base path
15896025 SystemTools: Use C++11 in SystemToolsAppendComponents

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !145

Although `CollapseFullPath` is meant to construct a full path, it
is possible that a caller will provide a relative base path.
In this case, keep leading `../` components from the base path
instead of discarding them.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

6c3dfd25 CommandLineArguments: initialize internal class members directly
a93bc28c SystemTools: Drop unnecessary .c_str()
6e36d909 SystemTools: Reduce scope of 'buf' variable in CollapseFullPath
31f5cdeb RegularExpression: Initialize private members on construction
116a4919 RegularExpression: Reduce scope of 'len' variable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !143

bdvd authored 5 years ago and Brad King committed 5 years ago

The `Realpath` function takes `std::string`.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

887b1da5 Fixing issues when building with clang 8.0 on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !142

* Clang with the MSVC STL requires C++14
* Deprecatoion warning suppressions were specific to MSVC and Intel
* An assignment inside a condition resulted in a warning
* kwsysProcessSetExitException was declared, but never defined or used

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

93352b24 SystemInformation: Add Hygon Dhyana Support

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !141

hygonsoc authored 5 years ago and Brad King committed 5 years ago

Add Hygon CPU Vendor ID("HygonGenuine") detection and HasMMXPlus CPU
flag checking.

Signed-off-by: Fan Jinke <fanjinke@hygon.cn>

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

43c6e2fd SystemInformation: Implement backtrace support on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !140

Ken Martin authored 5 years ago and Brad King committed 5 years ago

The prior code had no implementation on windows. This code relies on
dbghelp.dll which is a standard part of the operating system. It is
implemented for OS from Vista forward when compiled with MSVC version
1800 or later (VS2013).

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

84bd7c9e SystemTools: support hiding the translation map

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !139

Ben Boeckel authored 9 years ago and Brad King committed 5 years ago

When determining full paths, CMake would treat the as-called path for
the source and build directories as real paths even if they were
symlinks. This causes problems when determining the relative path
between the source and build directories when they are symlinks.

Take the following setup as an example:

    /mnt/src/project/
        src/
        build/ -> /mnt/builds/project/build

With the translation map and /mnt/src/project/build/ as the build
directory, CMake would use ../src as the relative path to the source
tree from the build tree rather than ../../../src/project/src and
lookups using ../src would fail. If the build directory were instead
used *as* /mnt/builds/project/build, everything would work just
fine.

This patch makes the core logic which does this logic optional so that
it can be experimented with in CMake itself.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

5d8af0d6 SystemTools: Optimize range loop in RelativePath method
815cc593 SystemTools: Optimize range loop in FindProgramPath method
ac8d2033 SystemTools: Optimize range loop in FindLibrary method
c7e3ab12 SystemTools: Optimize range loop in FindProgram method
8c9ca162 SystemTools: Optimize range loop in FindProgram method
9992f69b SystemTools: Optimize range loop in FindName method
d6235796 SystemTools: Optimize iterator lifetime in JoinPath
00a3a436 SystemTools: Update buffered env value string only on a change

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !138