vtkStringToNumeric.cxx:274:57: warning: '*' in boolean context

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Kitware Robot authored 9 years ago and Dan Lipsa committed 9 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

VTK Developers authored 12 years ago and Brad King committed 12 years ago

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

VTK Developers authored 12 years ago and Brad King committed 12 years ago

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>

This fixes several whitespace issues introduced in this topic, such as
indentation, trailing whitespace.

Change-Id: I5b3cfc1e503fb7ea32fe88627dcb1627ff7da4c4

Enhanced vtkStringToNumeric to allow specification of default integer and
double values. Added a setting to trim strings before conversion to numeric
to make up for deficiencies in vtkVariant.  Propagated these settings up
to vtkDelimitedTextReader.

Change-Id: I95c20e9a4769338927e4c433b2293cf56141f112

Added a ForceDouble flag to vtkStringToNumeric and expose
the same flag in vtkDelimitedTextReader.

Change-Id: I5b3e13272e8dc5589a96c8bd88cfcb8479b3a6c3

Since the behaviour of SetInput changed - it no
longer connects the pipeline but sets up the data
object as the input -, it was decided to rename
it to SetInputData. This includes similar methods
such as AddInputData. This commit makes on
sweeping change that compiles.

Mark Olesen authored 14 years ago and Brad King committed 14 years ago

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

Mark Olesen authored 14 years ago and Brad King committed 14 years ago

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

ENH: Before execution, count how many items need to be converted.  This lets us emit ProgressEvent with meaningful values.

vtkDataObject::DATA_EXTENT_TYPE() needs to be only set on a data
object's information object. This is usually done in the constructor
of the data object's class. Those that are implementing algorithms
do not have to worry about this key.

STYLE: Set array components then tuples to ensure that the respective values are set properly and that the array gets allocated only once.

ENH: Add support for unicode strings. Also change the 'int test' logic so that it for a dataset without entries it doesn't assume int.

ENH: Now using an instance of vtkDataSetAttributes (RowData) in vtkTable to store table columns. All code referencing the FieldData needed to be changed to use RowData. vtkAlgorithm's SetInputArrayToProcess, vtkTableReader/Writer, and vtkSelection's field type, needed to be updated to handle row data.

* Iterator-based access to edges
* vtkGraph subclasses from vtkDataObject instead of vtkPointSet
* vtkGraph's implementation is much more like that of the boost graph library
* Separate classes vtkDirectedGraph and vtkUndirectedGraph instead of
a Directed flag
* Mutable classes vtkMutableDirectedGraph and vtkMutableUndirectedGraph used for building graphs