Brad King authored 2 years ago and Kitware Robot committed 2 years ago

3c3bce13 cmake: Honor CMAKE_GENERATOR env var in --help output

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Acked-by: Alex Turbov <i.zaufi@gmail.com>
Merge-request: !7808

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

75cfbef7 cmake: Support --list-presets=workflow

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Tested-by: Craig Scott <craig.scott@crascit.com>
Merge-request: !7816

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

75cfbef7 cmake: Support --list-presets=workflow

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Tested-by: Craig Scott <craig.scott@crascit.com>
Merge-request: !7816

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

36d76ed0 Help: cmake(1), ctest(1), versionadded for key flags

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7815

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

36d76ed0 Help: cmake(1), ctest(1), versionadded for key flags

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7815

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

f3c918ef cmGlobalVisualStudioGenerator: Fix compiling as C++20 in VS 2022

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7814

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

f3c918ef cmGlobalVisualStudioGenerator: Fix compiling as C++20 in VS 2022

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7814

Jörg Werner authored 2 years ago and Brad King committed 2 years ago

Adding missing narrow string conversion.

Fixes: #24072

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

3043c170 Help: Add more CLI `:option:` references to various pages

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7811

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

3043c170 Help: Add more CLI `:option:` references to various pages

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7811

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

65dc8aa8 Help: Mention CMake version for a recently-added `find_package` search path
93871cb5 Help: Reformat find_package search paths as Sphinx tables

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7810

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

65dc8aa8 Help: Mention CMake version for a recently-added `find_package` search path
93871cb5 Help: Reformat find_package search paths as Sphinx tables

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7810

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

ee9805cc cm/filesystem: Fix crash with pre-C++11 std::string GNU ABI in C++17

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7813

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

ee9805cc cm/filesystem: Fix crash with pre-C++11 std::string GNU ABI in C++17

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7813

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

79ce0f43 Tests: Explicitly allow usage of git file-based protocol in test cases

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7812

Brad King authored 2 years ago and Kitware Robot committed 2 years ago

79ce0f43 Tests: Explicitly allow usage of git file-based protocol in test cases

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7812

Merge-request: !7813

Merge-request: !7813

The `remove_filename` and `replace_extension` methods compute an offset
between the whole path in a `std::string` and a part of a path in a
`std::string_view`.  This is done by subtracting their `.data()`
pointers.  However, C++17 adds a non-const `.data()` through which
modification of the string is allowed.  This means the copy-on-write
implementation used by the pre-C++11 std::string GNU ABI must reallocate
if the string has been copied.  Our subtraction then computes an offset
between two different allocations, which is undefined behavior.

The workaround in commit b3ca4f9a (cm/filesystem: Work around crash
when compiled for CYGWIN/MSYS runtime, 2021-04-22, v3.21.0-rc1~271^2~2)
avoided the problem by calling the non-const `.data()` to reallocate
before constructing the `string_view`.  Instead, explicitly call the
const `.data()` method on the string, which does not reallocate.

Fixes: #22090, #23328

Merge-request: !7812