David Thompson authored 3 months ago and Ben Boeckel committed 3 months ago

This also forces all inclusions of the `Singleton.h` header
to use angle brackets (since in theory third-party libraries
may be in system paths and even when provided by VTK should
use `-isystem` instead of `-I`).

(cherry picked from commit 615c9f21)

This also forces all inclusions of the `Singleton.h` header
to use angle brackets (since in theory third-party libraries
may be in system paths and even when provided by VTK should
use `-isystem` instead of `-I`).

- This fixes a bug when applications completely rely on
  vtkLogger::Init(ac, av) to parse the -v flag on CLI and
  set the stderr verbosity.
- With this commit, it is finally possible to run the test
  executables with a custom verbosity by merely passing -v <verbosity>
  on the command line. This greatly simplifies debugging trace messages
  without having to manually set the stderr verbosity and recompile the
  test executable.

If the C++ object already existed within VTK, and the Python object
is being created because it is being returned by a method, then we
don't want the creation of the Python object to cause changes to
C++ object attributes that were already set by the C++ VTK code.

For example, if we are getting the output dataset from a C++ VTK
filter, we don't want any C++ attributes of the dataset to change
when the Python part of this pre-existing dataset object is created.

Since vtkIdType is just a typedef for one of the fundamental
types for which the template is already instantiated, we must
avoid instantiating for vtkIdType since the instantiation will
result in duplicate template symbols.  Most linkers will handle
the duplicated template symbols, but some linkers will generate
an error.

Previously when encountering an error during a Receive() call, server
hangs indefinitely as only WSAENOBUFS was checked.

For WSAECONNABORTED we cannot know if the disconnection is expected or
not so we don't output an error but log a trace for debugging purpose.

(cherry picked from commit c86e3aaa)

Previously when encountering an error during a Receive() call, server
hangs indefinitely as only WSAENOBUFS was checked.

For WSAECONNABORTED we cannot know if the disconnection is expected or
not so we don't output an error but log a trace for debugging purpose.

- this commit adds ability to view tracing information that is emitted from `vtkDeserializer`, `vtkSerializer` and `vtkObjectManager` by configuring a log verbosity. The verbosity can be set either as an environment variable or directly on the object manager, serializer and deserializer.
- for wasm, new methods are provided in the wasm scene manager bindings. these methods let you pass in strings like "WARNING", "INFO", etc.

David Gobbi authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

The Update() method of vtkAbstractTransform uses a mutex lock,
and calls virtual methods during the lock which are implemented
by subclasses.  Those methods can trigger callbacks that cause
Update() to be called again, resulting in a deadlock.

By ensuring that calls to Modified() during Update() do not invoke
ModifiedEvent, we can avoid at least some of these deadlocks.

(cherry picked from commit 0dbd7a9c)

Alexy Pellegrini authored 6 months ago and Mathieu Westphal (Kitware) committed 4 months ago

Caused by Windows.h

(cherry picked from commit fb499d41)

Ben Boeckel authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

The latter is deprecated.

(cherry picked from commit 87faceb1)

Mickael PHILIT authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit 5c4687d6)

Ben Boeckel authored 5 months ago and Mathieu Westphal (Kitware) committed 4 months ago

(cherry picked from commit 6fea24e9)

vtkImplicitFrustumRepresentation calls
`this->Frustum->GetBottomPlane()->GetNormal()`
where `GetNormal` is not const but `GetBottomPlane` is.
Looks hard to make vtkPlane API const-correct, so remove const
from vtkFrustum::GetXXXPlane().

Was introduced in !11575

The parametric center of a polyhedron has been the center of its bounding box.
This can be really problematic, because the actual location can be outside of
the cell itself.

If you consider a tetrahedron, the location of its parametric center is its
centroid.

Therefore, in this commit, as parametric center of a polyhedron, we return
the parametric location of the centroid of its points.

There are probably still going to be corner cases where it might not make sense,
but it's definitely better than bounding box center

This ensures that the lifetime of the token library singletons
is longer than the lifetime of vtkFilteringInformationKeyManager.
Without this, the vtkFilteringInformationKeyManager finalizers
might be called after the token library itself has finalized.

  -- Changing python class types for current overrides for multiple
  inheritance
  -- Adding proper equality checks for data objects and data arrays
  -- Adding custom `_numpy_attrs` for checking/comparing attributes for
  equality

The Update() method of vtkAbstractTransform uses a mutex lock,
and calls virtual methods during the lock which are implemented
by subclasses.  Those methods can trigger callbacks that cause
Update() to be called again, resulting in a deadlock.

By ensuring that calls to Modified() during Update() do not invoke
ModifiedEvent, we can avoid at least some of these deadlocks.

The latter is deprecated.

Remove the threshold that existed before because
the new image testing framework is now used, whose
threshold ranges from 0 to 1, and 0.05 is a good default.

… so it is marked modified when the query parameters
for Strategy and SelectionType are changed.

… into a cache object and the query that uses the cache.
This will allow other filters to use cached sides (specifically
the forthcoming vtkCellGridCrinkleCleaver).

… to the cell-grid "Compute Sides" filter so that
the summarization strategy and selection style can
be set by users.

Add vtkSMPToolImpl constructor declaration for the TBB backend so
that the compiler knows the definition in the .cxx exists and does
not generate duplicate symbols.