Jaswant Panchumarti (Kitware) authored 6 months ago and Kitware Robot committed 6 months ago

d3adc537 Exclude render window details from serialization

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Sebastien Jourdain <sebastien.jourdain@kitware.com>
Merge-request: !11437

Léon Victor authored 6 months ago and Kitware Robot committed 6 months ago

ee9bf198 Replace default destructor with default

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Merge-request: !11412

Cory Quammen authored 6 months ago and Kitware Robot committed 6 months ago

d4984de8 consolidate common test setup code

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11442

David Gobbi authored 6 months ago and Kitware Robot committed 6 months ago

ce525d83 Define comparison operators as const

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11439

Jaswant Panchumarti (Kitware) authored 6 months ago and Kitware Robot committed 6 months ago

c58f8c36 Mangle ThirdParty/glad library symbols
d14f9301 Add ThirdParty/glad library

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11415

Jaswant Panchumarti (Kitware) authored 6 months ago and Kitware Robot committed 6 months ago

d40e850d Fix mixed cell type rendering in vtkWebGPUPolyDataMapper

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11411

Mathieu Westphal (Kitware) authored 6 months ago and Kitware Robot committed 6 months ago

2ac14b21 Use WritePointer in vtkMultiBlockPLOT3DReader
022be287 Fix miscount in TestReflectionFilter
a851fd71 Fix small mistake in TestAppendMolecule
f0cb53b7 Fix otherFieldData array usage
7b11a643 Fix CellVectors size issue in vtkStreamTracer
9ef902e1 Use Insert to incrementally build cell array
e079c89e Fix vtkStructuredAMRGridConnectivity MaxId issue
a4fd5b72 Fix MaxId issue in vtkHyperTreeGridContour
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Acked-by: Sean McBride <sean@rogue-research.com>
Merge-request: !11432

Mathieu Westphal (Kitware) authored 6 months ago and Kitware Robot committed 6 months ago

57029bec Fix a few warnings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Léon Victor <leon.victor@kitware.com>
Reviewed-by: Lucas Givord <lucas.givord@kitware.com>
Merge-request: !11422

The two objects compared by the operators should be const, as
is already the case for most comparison operators in VTK.  This
fits with the default comparison operator definitions provided
by c++20.

Scott Wittenburg authored 6 months ago and Kitware Robot committed 6 months ago

84ef564f Rendering: Remove RenderingOpenGL2 dep on IOXML

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Acked-by: Jaswant Panchumarti (Kitware) <jaswant.panchumarti@kitware.com>
Merge-request: !11389

- excludes UseOffScreenBuffers, ShowWindow and OffScreenRendering and
  DPI properties
- these properties are typically setup differently in clients

When getting a naked pointer for writing to an array, the
WritePointer() method ensures the array is adjusted so that it
can receive the new values.  If just GetPointer() is used, then
the MaxId of the array is not correctly set.

Not enough tuples were added to the arrays.

The Atom and Bond data arrays were not regenerated when the number of
bonds and atoms was changed.

This very old test was using arrays in strange ways, resulting in
array access beyond the MaxId of the arrays.

The size of the array was not being adjusted to the cell size
prior to use.  As a result, the array was being written to beyond
MaxId, though still within the array's allocation.

The InsertComponent() method ensures that the MaxId of the array
is adjusted, so that out-of-bounds accesses do not occur.

The ghost arrays were built with SetValue() without adjusting the
MaxId to indicate the number of values in the array.  With
InsertValue(), the MaxId is adjusted automatically.

To ensure MaxId is properly set for cell scalar array, use Insert
instead of SetTuple.

When the size of an array is fixed, there is no reason to use
Allocate() since SetNumberOfTuples()/Values() is simpler and
ensures MaxId is set.

This ensures that we aren't reading into values that are beyond
the MaxId of the array.

Calling SetNumberOfTuples() already does the calculations that
were being done here in the code, and has the benefit of also
adjusting the MaxId of the array.

Added SetNumberOfValues() after the allocation in order to avoid
setting values beyond the MaxId of the array.

The tuple, component indices into the weight array were reversed.

Setting the size of an array is best done with SetNumberOfValues(),
since Resize() only changes the allocation but not the number of
items present.

This class was accessing its ItemLocation array beyond MaxId, now
it uses the array in a more standard way.

David Gobbi authored 7 months ago and Kitware Robot committed 7 months ago

0f4635e8 Prefer SystemTools::Stat over system stat/stat64
fd1b7a2f Revert include file ordering in large file check

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11406

- adds TestMixedGeometry.cxx to exercise rendering of a polydata with points, lines, polylines, polygons and triangles.

Jaswant Panchumarti (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

a4dc4865 Fix fractional point rendering in vtkWebGPUPolyDataMapper

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11410

Jaswant Panchumarti (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

bff04c86 Merge branch 'upstream-loguru' into wasm-enable-logging
3a556b15 loguru 2024-08-21 (24da0e01)
71c5dfe8 loguru: update for PTLS in emscripten

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11420

Mathieu Westphal (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

90874ba4 Doc: Update dev guide for CI fixes in fork settings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Lucas Givord <lucas.givord@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !11428