- the previous code did not work because VTK did not simulate
  a 'ResizeEvent' after starting the event loop.

- The default `emscripten_set_xyz_callback()` functions registered
  observers on the calling thread but explicitly blocked the main UI
  thread when invoking the callback. This resulted in a runtime warning
  when built with `-sASSERTIONS=1`.
- This commit refactors the callback handling into two parts.
- The lightweight non-blocking part `MaybeProxyEvent` always runs
  on the main UI thread. All it does is asynchronously enque the event.
- The second part is the actual enqueing which happens on the thread
  that is set to invoke `ProcessEvents`(same as thread which invokes
  `Start`) and process events from the queue one by one.

- Helps catch incorrect usage of any threads/gl APIs from emscripten.

Jaswant Panchumarti (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

387f9f50 ci: enable rendering tests in wasm linux

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11298

Jaswant Panchumarti (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

0cd56c54 Add wrapped wasm example using web worker and vtkAlgorithm abort
5d0f9811 Add simple wasm example using web worker and vtkAlgorithm abort

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11386

Mathieu Westphal (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

09f56434 Remove unused dependencies from Export and NetCDF

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11376

- This example adds on the AsyncClipper example by demonstrating how one
 might use embind and web workers.
- The main difference is that with embind, there is no `main(int, char**)`
 function and the entire application is driven from javascript.
- This example shows in detail how to create a pthread and transfer the
 canvas offscreen so that the new web worker can render into it. In the
 `AsyncClipper`, we used `-sPROXY_TO_PTHREAD` link flag which did all the
 tasks necessary to run our `main(int, char**)` on a new web worker.

- This example has a simple `main` function which sets up the VTK
  pipeline using vtkTableBasedClipDataSet.
- It shows how one might leverage the vtkAlgorithm abort functionality
  because now all the VTK rendering and processing is offloaded into a
  web worker leaving the main thread free to go and set the abort flag.
- In this example, the abort flag is set whenever user mouses
  down and moves the cursor on the canvas. As soon as the mouse is
  released, the abort flag is reset.

Léon Victor authored 7 months ago and Kitware Robot committed 7 months ago

9cf1108e Upload test baseline
369996df Add changelog
5e692546 Add vtkImplicitConeWidget test
0ec01b7a Introduce cone implicit widget

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Lucas Givord <lucas.givord@kitware.com>
Reviewed-by: Louis Gombert <louis.gombert@kitware.com>
Merge-request: !11330

Mathieu Westphal (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

11a016ac GLTFImporter: Add testing for invalid image
4a1bdcab GLTFImporter: Fix a potential when creating textures

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ryan Krattiger <ryan.krattiger@kitware.com>
Merge-request: !11385

Jaswant Panchumarti (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

5f91b59a Ignore EMSCRIPTEN_EVENT_KEYPRESS events in wasm interactor
b83c393b Fix mouse coordinates in hi-dpi screens

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Acked-by: Andrew Maclean <andrew.amaclean@gmail.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11384

Jaswant Panchumarti (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

387bf5dc Remove unnecessary assert
4c6d4997 Add missing header for stringstream
7d0a35b0 Fix redundant string initialization
17193b9a Fix -Wparentheses in vtkWebGPURenderer.cxx
8c8645e6 Use erase-remove-if idiom correctly to remove range of BGLs
7ff9fc84 Fix -Wdangling-gsl in vtkWebGPUComputePassBufferStorageInternals.cxx
31e2ee15 Fix -Winconsistent-missing-override warning in RenderingWebGPU module
9b05c923 Fix python wrapper compilation error for webgpu module

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11381

- ignore it so that the warning about unhandled events doesn't appear in console.
- the `EMSCRIPTEN_EVENT_KEYDOWN` immediately follows the keypress event and we handle that one.

- closes vtk-examples#17
- multiplies the mouse and touch X,Y coordinates with the device pixel ratio to account for a browser zoom setting or operating system wide zoom setting.
- the multiplication with `devicePixelRatio` was lost in the SDL2->emscripten refactor done in 540986cd

Spiros Tsalikis authored 7 months ago and Kitware Robot committed 7 months ago

14305452 Merge branch 'upstream-ioss' into update-ioss-exonull
863a314d ioss 2024-08-08 (0dda1fa8)
b81ec74a ioss: update.sh

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11378

Spiros Tsalikis authored 7 months ago and Kitware Robot committed 7 months ago

14305452 Merge branch 'upstream-ioss' into update-ioss-exonull
863a314d ioss 2024-08-08 (0dda1fa8)
b81ec74a ioss: update.sh

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11378

- assert on a stack variable does not seem useful

- modifies declaration of `actor` such that it is only valid inside the while loop's scope.

- also resolves compiler warning -Wunused-result

- Addresses the warning "object backing the pointer will be destroyed at the end of the full-expression" by taking the std::string instead of the underlying char*

- adds override at the end of `PrintSelf` function declarations

- adds missing include for weak pointer's template arg.
- otherwise the python wrapper for this class failed to compile
  saying that the weakpointer's template argument is incomplete.

Jaswant Panchumarti (Kitware) authored 7 months ago and Kitware Robot committed 7 months ago

cbabf2f4 Fix wasm upload jobs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Sebastien Jourdain <sebastien.jourdain@kitware.com>
Merge-request: !11379

# By Seacas Upstream
* upstream-ioss:
  ioss 2024-08-08 (0dda1fa8)

Kitware Robot authored 7 months ago and Spiros Tsalikis committed 7 months ago

Code extracted from:

    https://gitlab.kitware.com/third-party/seacas.git

at commit 0dda1fa8d652ec7cfd9949802e147a788463989b (ioss/for/vtk-20240808-v2024-06-27).

David Gobbi authored 7 months ago and Kitware Robot committed 7 months ago

0116de39 Use Lib, not bin/Lib, for site-packages on MSVC

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !11368