- Jun 10, 2023
-
-
Jean-Christophe Fillion-Robin authored
- Sort import alphabetically - Move script documentation at the script/module level and improve help display
-
Jean-Christophe Fillion-Robin authored
-
Jean-Christophe Fillion-Robin authored
This commit updates the "SPDX_generate_output.py" script to accept response files as input source file specifications. The previous implementation had a limitation of a maximum command length of 8191 characters on a Windows system (as documented in [1]), which led to generation failures in some modules. By using response files for specifying input files, this commit fixes the issue. In particular, certain modules such as the one listed below needed to accept input files beyond the 8191 limit: - vtkCommonImplicitArrays - vtkCommonDataModel - vtkCommonCore - vtkRenderingOpenGL2 - vtkInteractionWidgets To demonstrate this, we list these modules and the length of their "-spdx.Release.args" files using the commands shown below: ``` $ find . -type f -name "*-spdx.Release.args" | xargs wc -m | sort -n -r | tail +2 | head -n6 52896 ./vtkCommonImplicitArrays-spdx.Release.args 13542 ./vtkCommonDataModel-spdx.Release.args 10576 ./vtkCommonCore-spdx.Release.args 9783 ./vtkRenderingOpenGL2-spdx.Release.args 9302 ./vtkInteractionWidgets-spdx.Release.args 6592 ./vtkFiltersGeneral-spdx.Release.args ``` This listed was generated assuming the VTK source and build directories are respectively located at "C:/VTK" and "C:/VTK-build". This approach is similar to the one used for passing input files to the Python wrapping tool (see `CMake/vtkModuleWrapPython.cmake` that was originally implemented in 328d974b "ENH: Allow wrapping tools to accept argument files.") [1] https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation
-
Jean-Christophe Fillion-Robin authored
To avoid the apostrophe (or single quote) from confusing the execution of the command associated the build-system specific code resulting from the use of "add_custom_command()", this commit use the recommended VERBATIM option and ensure the argument is space separated. This allows to specify name like "John O'Keefe" or "Bob O'Bara"
-
Jean-Christophe Fillion-Robin authored
It turns out that the introduction of single-quote for handling argument passed to "SPDX_generate_output.py" allows to support the of parentheses. Experiment done using the "Unix Makefiles" generator also confirmed that the single escaping had no effect.
-
Jean-Christophe Fillion-Robin authored
-
- Jun 09, 2023
-
-
Mathieu Westphal (Kitware) authored
-
Mathieu Westphal (Kitware) authored
-
5fae7a4d Documentation: Add SPDX/SBOM documentation 73afe003 Module: Add SPDX generation at build time Acked-by:
Kitware Robot <kwrobot@kitware.com> Tested-by:
buildbot <buildbot@kitware.com> Merge-request: !10200
-
Kitware Robot authored
-
- Jun 08, 2023
-
-
332cac5f vtkLogger: hide the loguru callback bridge without loguru enabled Acked-by:
Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com> Merge-request: !10266
-
36c0ef27 Add missing export for vtkResourceParser::vtkParserContext class Acked-by:
Julien Fausty <julien.fausty@kitware.com> Acked-by:
Julien Schueller <schueller@phimeca.com> Merge-request: !10265
-
Ben Boeckel authored
-
Mathieu Westphal (Kitware) authored
Co-authored-by:Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
-
48b75a81 vtkTableBasedClipDataSet: fix normal artefacts due to the clip Acked-by:
-
Alexy Pellegrini authored
-
-
-
-
821fe510 vtkXRenderWindowInteractor: Fix a logic error with repeating timers Acked-by:
David Gobbi <david.gobbi@gmail.com> Reviewed-by:
Jaswant Panchumarti <jaswant.panchumarti@kitware.com> Merge-request: !10264
-
913f9122 Move vtkFLUENTCFFReader to a new dedicated module Acked-by:
Tim Thirion <tim.thirion@kitware.com> Reviewed-by:
Ben Boeckel <ben.boeckel@kitware.com> Merge-request: !10255
-
Lucas Givord authored
Previously when the locator, which will be the vtkMergePoints, merges points cannot handle properly normal array. To avoid to recompute each normal we using another locator which will not perform merge points : vtkNonMergingPointLocator, when 'normal' data is present.
-
Kitware Robot authored
-
- Jun 07, 2023
-
-
Mathieu Westphal (Kitware) authored
Co-authored-by: -
Mathieu Westphal (Kitware) authored
The generation system relies on three component. 1. SPDX variables in each vtk.module 2. global variables set at project level (this may change in future) 3. SPDX Tags in the sources files Assuming all these informations are provided, VTK will be able to generate complete SPDX file for each module and third-party module. If some information are missing, VTK will warn during configuration or during build but the SPDX file will still be generated with some field being `NOASSERTION` or another default value.
-
Mathieu Westphal (Kitware) authored
-
3deecf20 Interactors: Add repeating timers behavior test 1ba02432 vtkXRenderWindowInteractor: Fix a logic error with repeating timers Acked-by:
-
2ab3ec14 Import: Clarify vtkImporter::UpdateTimeStep doc and usage Acked-by:
Michael Migliore <mcmigliore@gmail.com> Acked-by:
-
Mathieu Westphal (Kitware) authored
-
Kitware Robot authored
-
- Jun 06, 2023
-
-
9b578f40 Handle zSpaceCoreCompat libraries not found 12842c43 Include zSpaceCoreCompatibility headers Acked-by:
-
Kitware Robot authored
-
- Jun 05, 2023
-
-
Mathieu Westphal (Kitware) authored
-
Mathieu Westphal (Kitware) authored
-
Thomas Galland authored
We do not search for zSpaceCoreCompatibility dynamic libraries during configuration anymore. These being searched and loaded only at runtime, ParaView will not crash anymore if they are not found.
-
Thomas Galland authored
zSpaceCoreComatibility headers are now directly included in the zSpace module. Furthermore, we do not search for zSpaceCoreCompatibility dynamic libraries during configuration anymore (this is done only at runtime).
-
1294302b Delimiting newlines should be kept when the solid does not have name with it Acked-by:
Andras Lasso <lasso@queensu.ca> Merge-request: !10215
-
b0645b50 Feat support not writing the object information Acked-by:
-
Jake Yun authored
-
Kitware Robot authored
-
