Setter should not modify values.

Clamping the radius in its setter forces the user to set Inner and Outer
in the correct order. Prefer accepting any value, and do some
sanity check when using them.

Check that annulus circle follows mouse position

Using actual position to compute radius helps with interaction:
widget stays under the mouse in a predictable way.

Previous code makes use of motion in Y direction of DisplayCoordinates,
which was harder to understand.

See also: #19537

We have 2 pickers: one for some handles, another for
the drawn widget. Depending on the interaction, using
the corresponding one gives better result when computing
WorldCoordinates.

- Lift the member variables from composite polydata mapper to the base class (vtkPolyDataMapper)

- This commit adds setter/getter functions to customize the text on the buttons corresponding to different axis viewpoints.

- this makes the property (de)serializable

- Earlier, the animation only worked in VTK apps which used the X11/Windows/macOS interactors because it called `Render` without yielding to the external framework's event loop like Qt/Wasm.
- This commit changes the design to use a repeating timer to interpolate camera step by step everytime the timer is fired. This now works in the wasm interactor because it ties into the `requestAnimationFrame` method which yields to the browser event loop.
- It will most likely start to work in Qt as well.

- This commit is a first step to getting the widget to deserialize
correctly because during deserialization a different renderer
is assigned as the default renderer.
- When another renderer is provided, this commit carefully removes
the previous reorientation observer. If the widget was previously
enabled, it replaces the older renderer in the render window with the
new renderer. Otherwise, upon deserialization, the render window had
an extra renderer which originated from the constructor of
`vtkCameraOrientationWidget``.
- Updated baseline images which used the camera orientation widget
  because the widget now resizes itself to correct proportions

Remove the threshold that existed before because
the new image testing framework is now used, whose
threshold ranges from 0 to 1, and 0.05 is a good default.

Will Schroeder authored 8 months ago and Sankhesh Jhaveri committed 5 months ago

The representation widget has been extended to easily support fixed
font sizes. This means that no matter how the renderer size changes,
the font size remains constant. Previously, the text scaled as the
renderer size changed in size.

Kitware Robot authored 5 months ago and Ben Boeckel committed 5 months ago

Also use C++17 syntax rules as the next release expects to use C++17.

- closes #18547
- closes #19383
- Use glad instead of glew for loading GL extension functions
because GLEW has trouble using GLX and EGL in the same build.
- Replaces the VTK::glew module with VTK::glad.
- Removed the utility VTK::opengl module because it is unnecessary
after the changes made to vtkOpenGLOptions.cmake
- OpenGL is now loaded at runtime in desktop platforms.
- For mobile and webassembly, when VTK_OPENGL_USE_GLES is ON,
glad finds and links to the OpenGL::GLES3 library.
- Support for OSMesa is always available from VTK. Users must make
sure the libOSMesa.so or osmesa.dll is installed.
- Support for EGL is always available from VTK in Linux and Android.
Users must make sure libEGL is installed.
- On platforms where multiple render window backends are possible, the
vtkOpenGLRenderWindow is made the default factory override and it's
New method implements runtime tests to determine what render windows
can work. It basically constructs the platform implementation render
window, attempts to initialize it and checks whether it was
successfully intialized.
- The X OpenGL render window class was updated to not call abort.
It also print warnings instead of errors when it fails to open X
display. This allows us to safely test support for GLX at runtime.
- The new environment variable VTK_DEFAULT_OPENGL_WINDOW
can optionally be used to force a render window subclass
at runtime. It is useful to debug support for a fallback render
window on different system configuration.
- Remove usage of unnecessary CMake flag VTK_OPENGL_HAS_MESA.
- Since there is no compile time depedency for OSMesa in VTK,
this commit makes VTK act as if it can always use OSMesa,
obviously when the system executing VTK code has osmesa installed.
- ci scripts will be adjusted in next commits

David Gobbi authored 6 months ago and Lucas Givord committed 6 months ago

Insert points to ensure points are properly sized.

(cherry picked from commit 4e276502)

David Gobbi authored 6 months ago and Lucas Givord committed 6 months ago

This is the loop to project the polyline points to a plane.

(cherry picked from commit 007fe299)

Insert points to ensure points are properly sized.

This is the loop to project the polyline points to a plane.

- The new SetCorners/GetCorners methods on the vtkBoxRepresentation allows direct specification of the 8 corners of the box. The effect is similar to calling PlaceWidget.

- This method should be used (instead of PlaceWidget(bds)) when users want to place the box widget in 3D space at exact coordinates.

The two objects compared by the operators should be const, as
is already the case for most comparison operators in VTK.  This
fits with the default comparison operator definitions provided
by c++20.

David Gobbi authored 8 months ago and Lucas Givord committed 8 months ago

In Python, a character is defined as a str with a length of 1, e.g.
the kind of value returned by chr() or accepted by ord().

(cherry picked from commit d6319bbf)