- Sep 13, 2022
-
- Sep 12, 2022
-
-
48b380c9 FetchContent: Ignore EXACT for redirected find_package() calls Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7665
-
0f5b6dd2 FortranCInterface: Add support for LLVMFlang mangling Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7658
-
- Sep 11, 2022
-
-
d9a6e0ff FetchContent: Fix unsetting wrong variable name after provider returns Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7663
-
Craig Scott authored
When FetchContent_MakeAvailable() populates a dependency for which find_package() integration is enabled, all future calls to find_package() MUST succeed using the contents of the redirection directory. The generated config version file was not handling calls where the EXACT keyword was given, resulting in such calls rejecting the redirection directory's contents and continuing its search. It is not allowed to do that. Fix the generated file to also set PACKAGE_VERSION_EXACT to true so that calls with EXACT now accept it, as was originally intended. Fixes: #23950
-
- Sep 10, 2022
-
-
Craig Scott authored
The unset() command was using __cmake_contentNameLower before that variable was restored from the __cmake_fcCurrentVarsStack. That means if there had been a nested call to FetchContent_MakeAvailable(), the wrong variable name would have been cleared (the nested name instead of the one from the current call). That would have left the variable set upon return, blocking the dependency provider from seeing any further calls to FetchContent_MakeAvailable() in the current variable scope or below for the current dependency.
-
- Sep 09, 2022
-
-
The following `module.f90` file module mymodule contains subroutine mysub() end subroutine end module when compiled with `flang-new` (from LLVM 15.0.0) generate the `_QMmymodulePmysub` symbol. $ flang-new -c module.f90 $ nm module.o 0000000000000000 T _QMmymodulePmysub This commit fixes the regular expressions accordingly.
-
629d106c Help: Fix typo in FetchContent example, extras should read extra Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: hinell <al.neodim@gmail.com> Merge-request: !7657
-
bd30d20b Tests: Add cases covering bad ctest output truncation types dbf84039 ctest: print error for invalid CTEST_CUSTOM_TEST_OUTPUT_TRUNCATION Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7596
-
e08d34ed automoc: revert attempts to silence linker warning on macos Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7652
-
985b4c82 Check link libraries properties: fix performances regression a47eef32 renames method FinalizeTargetCompileInfo() in FinalizeTargetConfiguration(). Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7651
-
Amends 29e31e28 (Packages: Integrate FetchContent and find_package(), 2022-04-28)
-
- Sep 07, 2022
-
-
Brad King authored
Issue: #23869
-
Print an error message for invalid values of `CTEST_CUSTOM_TEST_OUTPUT_TRUNCATION` in a ctest dashboard script. The option was added by commit 140704d4 (ctest: add option for output truncation, 2022-03-07, v3.24.0-rc1~513^2). Fixes: #23869
-
Brad King authored
We've made several attempts to add a dummy symbol to `mocs_compilation.cpp` when there are no automoc sources: * commit 4a9daae4 (automoc: silence linker warning on macos, 2022-05-25, v3.24.0-rc1~55^2) * commit 844244cc (automoc: avoid compiler warnings in linker-warning- silencing code, 2022-08-10, v3.24.1~6^2) * commit fc862838 (automoc: avoid more compiler warnings in linker- warning-silencing code, 2022-08-29) The last attempt derives a symbol name from the path to the source file, but that breaks reproducible builds because it is not stable w.r.t. the location of the build tree. Revert all these attempts for the 3.24 release series, and return to what 3.23 and below did. Further investigation will be needed to resolve the original issue. Fixes: #23937 Issue: #23551, #23823, #23823
-
67b6f1a0 FindZLIB: fix CMAKE_FIND_LIBRARY_PREFIXES being unset when it was empty Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7647
-
Brad King authored
-
f0918fe5 FindCUDAToolkit: Correctly state cusolver and cublas dependencies Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7633
-
Marc Chevrier authored
Fixes: #23939
-
Marc Chevrier authored
-
- Sep 06, 2022
-
-
CMAKE_FIND_LIBRARY_PREFIXES and CMAKE_FIND_LIBRARY_SUFFIXES have different behavior when undefined and when defined but empty: Empty means to use an empty prefix/suffix while undefined means to use a hardcoded default for the platform we are running on. Unfortunately, set(a ${b}) will undefine a when b is empty, meaning that when targeting a platform where either of these variables is empty (e.g. Windows where CMAKE_FIND_LIBRARY_PREFIXES is empty) the unpatched FindZLIB code ends up unsetting that variable, causing all subsequent find_library calls to use the hardcoded default for the runtime platform (e.g. "lib" for CMAKE_FIND_LIBRARY_PREFIXES on Linux). On the other hand, set(a "${b}") will always define a to be empty but defined so we have to do this dance to fully preserve the state of these variables.
-
Brad King authored
Merge-request: !7633
-
cb55d5e7 RunCMakeTest: fix Truncation test definition Acked-by: Kitware Robot <kwrobot@kitware.com> Tested-by: buildbot <buildbot@kitware.com> Merge-request: !7632
-
5b30ca24 Help: cmake-developer: Add section for Windows registry access. Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7642
-
- Sep 05, 2022
-
-
daa2a6cd Help: Fix wrong casing of GTest in FetchContent integration example Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7644
-
Frank Winklmeier authored
The `ctest_test` and `CTestCommandLine` truncation tests had multiple problems: - escape expected result string to avoid regex matching - specify the truncation size - pass the truncation mode correctly into the test definition - use unique test names Issue: #23868
-
- Sep 04, 2022
-
-
Marc Chevrier authored
Fixes: #23905
-
2a21555e ExternalProject: note the default of `GIT_TAG` being `master` Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7631
-
Craig Scott authored
-
- Sep 02, 2022
-
-
Robert Maynard authored
Fixes #23920
-
Ben Boeckel authored
Reported on Discourse: https://discourse.cmake.org/t/fetchcontent-makeavailable-invalid-reference-master/6386
-
- Sep 01, 2022
-
-
f799e0f2 FindPostgreSQL: Add brew-style directories to search path Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7627
-
f5a441a6 Xcode: Fix erroneous MACOSX_BUNDLE link Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7624
-
- Aug 31, 2022
-
-
Refactoring in commit a2cfa2da (GenEx/LINK_LIBRARY: Add features for framework support on Apple, 2022-02-10, v3.24.0-rc1~661^2) accidentally removed a `GetParentDirectory` call. Restore it. Fixes: #23891
-
0fc10bb1 CMAKE_FIND_USE_INSTALL_PREFIX considers CMAKE_STAGING_PREFIX 43d31c51 cmFindBase: Refactor CMAKE_FIND_USE_INSTALL_PREFIX handling Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !7623
-
d3ac4e82 Tests: Teach RunCMake.SymlinkTrees to tolerate CCACHE_BASEDIR Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7622
-
7dca3807 Help: Fix typos, grammar and formatting in CMP0134 policy docs Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7620
-
fc862838 automoc: avoid more compiler warnings in linker-warning-silencing code Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !7617
-
468a9953 FindBoost: Add support for Boost 1.80 Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: مهدي شينون (Mehdi Chinoune) <mehdi.chinoune@hotmail.com> Merge-request: !7600