Skip to content
Snippets Groups Projects
  1. Mar 14, 2023
  2. Mar 13, 2023
  3. Mar 10, 2023
  4. Mar 08, 2023
  5. Mar 07, 2023
  6. Mar 06, 2023
  7. Mar 03, 2023
  8. Mar 02, 2023
    • Brad King's avatar
      ExternalProject: Restore driving install through build system · 77138752
      Brad King authored
      Revert commit 66b5d51f (ExternalProject: Install CMake projects
      using 'cmake --install', 2022-09-08, v3.25.0-rc1~150^2).
      It changed the ExternalProject install step command from:
      
          cmake --build <dir> --target install --config <cfg>
      
      to:
      
          cmake --install <dir> --config <cfg>
      
      The latter command no longer runs the external project build system
      during the install step.  We could consider using the commands:
      
          cmake --build <dir> --target all --config <cfg>
          cmake --install <dir> --config <cfg>
      
      as the install step, but if `CMAKE_SKIP_INSTALL_ALL_DEPENDENCY` is
      used in the external project, that can change semantics too.
      
      Revert the original change pending further investigation on other ways
      to support its motivating use case.  Add a test covering the
      previously-regressed use case.
      
      Fixes: #24567
      Issue: #23946
      77138752
    • scivision's avatar
      Help:cmake-language: note new block() command scope · 2931f078
      scivision authored and Brad King's avatar Brad King committed
      2931f078
Loading