Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • iMSTK iMSTK
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 83
    • Issues 83
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • iMSTKiMSTK
  • iMSTKiMSTK
  • Issues
  • #368
Closed
Open
Issue created Sep 13, 2021 by Andrew Wilson@andrew.wilson🐘Contributor

PbdConstraintFunctors should be constructed in PbdModelConfig and used for parameters

One of the issues with the PbdModelConfig is how it stores parameters. Each Functor could have any set of parameters. Generally:

  • "Regular Constraints": Have one double stiffness value
  • FEMConstraints: Have either possions ratio+youngs modulus OR lame parameters
  • BendConstraint: Has an extra parameter for strides

Really there's no telling (literally unable to tell) what parameters a user would want to use with a functor. While we should still maintain the pretty simple PbdModelConfig::enableConstraint function. It should immediately create and store the functor otherwise PbdModelConfig has to worry about how to store all these parameters and then later use them to setup functors which causes nasty code.

This should eliminate complexities in PbdModelConfig for FEM and Bend constraints. Specialized functions such as enableBendConstraint(stiffness, stride) and enableFEMConstraint(type, material) should still be present.

Edited Sep 13, 2021 by Andrew Wilson
Assignee
Assign to
Time tracking