Kitware Robot authored 6 months ago and Ben Boeckel committed 6 months ago

Also use C++17 syntax rules as the next release expects to use C++17.

Ben Boeckel authored 9 months ago and Christos Tsolakis committed 6 months ago

This allows ParaView (and other projects) to use `VTK::catalyst` as
`CATALYST_TARGET` when creating a Catalyst implementation.

(cherry picked from commit 2a0fcba7)

When run in interactive mode under Python 3.13, the vtkpython exe
raised "AttributeError: 'vtkPythonStdStreamCaptureHelper' object has
no attribute 'encoding'" whenever it tried to print to the screen.

Adding an attribute "encoding='utf-8'" to the stream capture objects
fixes the exception.  Note that there is no check that the console is
actually UTF8, but VTK has historically assumed that it is.

- OpenGL library is now loaded at runtime.

Py_GetProgramName() was deprecated in Python 3.13 and will be
removed in Python 3.15.  The same information can be retrieved
from sys.executable.  Note that since we stopped using
Py_SetProgramName() for Python>=3.8, for consistency the #ifdef
for Py_GetProgramName() also checks Python>=3.8.

- MACOSX_DEPLOYMENT_TARGET>=10 uses dynlib files (as opposed to jnilib
  files).

The VTK_PYTHON_FULL_THREADSAFE variable has existed since 2015, but
so far has only been a cmake option in Paraview, never in VTK itself.
Since this option adds the GIL locks that are required for any
Python concurrency via PyEval_SaveThread()/PyEval_RestoreThread(),
it should be useful within a broad range of VTK projects.

The VTK_NO_PYTHON_THREADS option is an older option that was available
in VTK 5 but disappeared in VTK 6, though it still appeared in the C++
source files and in Paraview's CMakeLists.txt.

This improves support for utf-8 on Windows.

This namespace is cruft from the 1990s before the stl was standard.

This allows ParaView (and other projects) to use `VTK::catalyst` as
`CATALYST_TARGET` when creating a Catalyst implementation.

Jaswant Panchumarti (Kitware) authored 10 months ago and Jaswant Panchumarti (Kitware) committed 9 months ago

- Serialization code for vtkCompositeSurfaceLICMapper, vtkSurfaceLICInterface and vtkSurfaceLICMapper is autogenerated

Jaswant Panchumarti (Kitware) authored 10 months ago and Jaswant Panchumarti (Kitware) committed 9 months ago

- Serialization code for vtkGlyph3DMapper and vtkOpenGLGlyph3DMapper is autogenerated

Jaswant Panchumarti (Kitware) authored 10 months ago and Jaswant Panchumarti (Kitware) committed 9 months ago

- vtkCompositeDataDisplayAttributes is serialized with helper code written by hand
- serialization code for vtkCompositePolyDataMapper is autogenerated

Jaswant Panchumarti (Kitware) authored 10 months ago and Jaswant Panchumarti (Kitware) committed 9 months ago

- vtkMultiBlockDataSet, vtkPartitionedDataSetCollection and vtkPartitionedDataSet are serialized with helper code written by hand
- Serialization code for vtkMultiPieceDataSet, vtkDataObjectTree, vtkCompositeDataSet is autogenerated.

These should all be fixed eventually, the goal for now is to be able to have a green TSan build on cdash so that at least all code changes henceforth can be assured compatible with TSan.

ClaudioHoffmann authored 10 months ago and Lucas Givord committed 10 months ago

Section 7.1.2 in Part 5 of the DICOM Standard [1] defines a list of VRs
that use 2-byte lengths instead of the default 4-byte ones, but UT is
not part of that list. Using 2-byte lengths for UT therefore caused the
parser to break with any DICOM file that contains UT records in its
header.
See pydicom [2] for an alternate implementation that also uses 4-byte
lengths for UT.

[1]: https://www.dicomstandard.org/standards/view/data-structures-and-encoding#sect_7.1.2
[2]: https://github.com/pydicom/pydicom/blob/abbacee6f20428930037cadf49aef94969617767/src/pydicom/valuerep.py#L486-L591

(cherry picked from commit f4779a1b)

- Enables automated marshalling for some classes in the following modules
  1. ChartsCore
  2. RenderingContext2D
  3. RenderingLabel
  4. ViewsContext2D
  5. ViewsCore
- Enables automated marshalling for additional classes in the following
modules
  1. CommonExecutionModel
  2. InteractionWidgets
  3. RenderingCore
  4. RenderingOpenGL2

- this API works in wasm64 and web-workers
- the version of sdl2 ported by emscripten did not.
- deprecates vtkSDL2OpenGLRenderWindow for 9.4
- include vtkOpenGLOptions at the top of root CMakeLists.txt
  so that vtk_module_scan sees VTK_OPENGL_USE_GLES

- the vtkWrapSerDes tool can now generate code for properties
that resemble collection of vtkObjects.

- This script will now also convert headers using `VTK_MARSHALMANUAL` to `VTK_MARSHALAUTO` if the header file name was moved from VTK_MARSHALMANUAL.txt to VTK_MARSHALAUTO.txt

Section 7.1.2 in Part 5 of the DICOM Standard [1] defines a list of VRs
that use 2-byte lengths instead of the default 4-byte ones, but UT is
not part of that list. Using 2-byte lengths for UT therefore caused the
parser to break with any DICOM file that contains UT records in its
header.
See pydicom [2] for an alternate implementation that also uses 4-byte
lengths for UT.

[1]: https://www.dicomstandard.org/standards/view/data-structures-and-encoding#sect_7.1.2
[2]: https://github.com/pydicom/pydicom/blob/abbacee6f20428930037cadf49aef94969617767/src/pydicom/valuerep.py#L486-L591

Python 3.12 has a change to lock internal data structures that now
requires the interpreter be initialized before calling `Py_AtExit`. Add
support for such deferred registartion to `vtkPythonInterpreter` and use
it in `vtkPythonAppInit`.

(cherry picked from commit 628171ce)

See: https://github.com/python/cpython/issues/118016

Though a sweep of fixing some of the new lints should be done someday.

Python 3.12 has a change to lock internal data structures that now
requires the interpreter be initialized before calling `Py_AtExit`. Add
support for such deferred registartion to `vtkPythonInterpreter` and use
it in `vtkPythonAppInit`.

See: https://github.com/python/cpython/issues/118016

Client applications that initialize Python prior to initializing
vtkPythonInterpreter and which add Python search paths would hang
because the GIL was not released on Windows with Python version > 3.8
after DLL search paths were added. Fixed that by using the default
vtkPythonScopeGilEnsurer constructor, which defaults to releasing the
GIL.

(cherry picked from commit 25b17126)

Client applications that initialize Python prior to initializing
vtkPythonInterpreter and which add Python search paths would hang
because the GIL was not released on Windows with Python version > 3.8
after DLL search paths were added. Fixed that by using the default
vtkPythonScopeGilEnsurer constructor, which defaults to releasing the
GIL.

Python 3.7 has been end-of-lifed for a month. Drop official support.