- address paraview/paraview#22594
- address paraview/paraview#21832
- Thick lines were drawn by expanding a line to 2 triangles stacked on their longest side using a geometry shader. When coloring by cell scalars, this worked everywhere except on apple silicon.
- There seems to be a bug related to geometry shaders in Apple's OpenGL driver that caused thick lines to not correctly pick up cell colors.
- It looks like the value written to `gl_PrimitiveID` is overwritten implicitly by `EmitVertex` and incremented each time a vertex is emitted from the geometry shader.
- This commit works around it by fixing the usage of `gl_PrimitiveID` in fragment shader when drawing thick lines.

(cherry picked from commit 62466099)

Lucas Givord authored 2 months ago and Kitware Robot committed 2 months ago

bb974e2a vtkTableBasedClipDataSet: Add check to avoid nullptr access
6bf984f9 vtkHigherOrderTetra: Add size check
edbb983b vtkGenericCell: Return when cell is nullptr
aeeb3225 Fixed out of bounds string access found by ASan
7ce34755 vtkHDF: fix overflow issue
9480cd6e Numerically sort folder contents
b9b37da4 vtkTextureObject: Check for context before binding texture

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Merge-request: !11810

Spiros Tsalikis authored 3 months ago and Lucas Givord committed 2 months ago

(cherry picked from commit e3db3c76)

Spiros Tsalikis authored 3 months ago and Lucas Givord committed 2 months ago

(cherry picked from commit 1ab742b0)

Spiros Tsalikis authored 3 months ago and Lucas Givord committed 2 months ago

(cherry picked from commit 5d987d5b)

Sean McBride authored 5 months ago and Lucas Givord committed 2 months ago

Check length of offset before taking adrees of a range like `&string[n - 8]`.

Looked for similar cases and also reordered another case to check length first, may or may not have been a problem, but safer this way.

ASan would catch this *during* VTK builds, while generating the wrappings.

(cherry picked from commit ccbda30c)

Reader regarding overlappingAMR can have an overflow issue due to his
offset. Few places in the writer should rely on vtkIdType instead of int
too.

(cherry picked from commit fd2e7a9a)

David Gobbi authored 5 months ago and Lucas Givord committed 2 months ago

This is for correctly sorting names that have numeric components
without leading zeros, e.g. [f.0, f.10, f.5] -> [f.0, f.5, f.10].

(cherry picked from commit 7cd880e2)

Mathieu Westphal (Kitware) authored 3 months ago and Lucas Givord committed 2 months ago

(cherry picked from commit 4b476ba1)

Sankhesh Jhaveri authored 3 months ago and Kitware Robot committed 3 months ago

c5f888fc OSPRay: ambient light switch status

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11780

The OSPRay renderer node avoids ambient lighting if there is an existing
ambient light in the scene. However, this would fail if the existing
light was switched off. This new check ensures that OSPRay uses ambient
illumination even if existing ambient light is switched off.

Cory Quammen authored 3 months ago and Kitware Robot committed 3 months ago

af084bd3 Added release note for light widget path tracing
0a6e6b0f Added test for light widget
890c60e2 Support ray-traced rendering of light widget/representation
f60d1dc2 Support positional light attenuation with ray tracing

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11757

Cory Quammen authored 3 months ago and Kitware Robot committed 3 months ago

f5b8061a Added release note for rectilinear grid cell data support
21fa50d7 Fix volume rendering support for rectilinear grid celldata

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11764

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

a3db6c62 ci: exclude geometry shader issues on macOS tests
647bda9d gitlab-ci: update to Xcode 16.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Merge-request: !11772

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

82980672 matplotlib: use kwargs for `FontProperties` arguments

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11773

This has been deprecated and will be removed in a future release.
Migrate to kwargs instead.

Ben Boeckel authored 3 months ago and Kitware Robot committed 3 months ago

6c68c368 vtkTesting: clamp negative SSIM values
f053b934 vtkTesting: handle SSIM's [-1,1] range
7a07dd33 vtkTesting: fix typos in log string and comment
a450694a vtkTesting: fix string allocation
9692d102 TestIOSSExodusParallelWriter: fix compilation without MPI
5b1ff455 IO/IOSS/Testing: remove stray comma in source list
f0c476fa Relaxed overly tight floating-point comparison
b95a6030 ci: exclude floating point precision issues
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11675

When SSIM returns a negative value, the histogram bucketing ends up
writing to out-of-bounds memory. Don't do that and instead shift the
buckets to account for the full range of values that are possible.

Finally, add commentary on the code.

See commit cd75f4b9 which applied this
to `master` and `release`.

Co-authored-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>

`newFileName` is deleted using `delete[]`, so allocate it with `new[]`.

Sean McBride authored 11 months ago and Ben Boeckel committed 3 months ago

This fixes a test failure on arm64 Macs, with default compiler options (that is, without `-ffp-model=strict`), where the dist2 value is not exactly zero but very tiny (due to fma, fused multiply add).

Specifically, in the UnitTestCells test it previously output:

```
Testing EvaluatePosition in/out test...cell center failed inOut: 1 point: -1.04083e-17, 0, 0-> pcoords: 0, 0, 0: closestPoint: -1.04083e-17, 0, 0 dist2: 1.08334e-34 weights: -0.0625 -0.0625 0.5625 0.5625
vtkCubicLine FAILED
```

Also fixed unrelated spelling/typo.

Co-authored-by: David Gobbi <david.gobbi@gmail.com>
(cherry picked from commit d204cfba)

New Xcode defaults to `-ffp-contract=on` which allows for fusing
floating point operations. This changes effective precision which these
tests are sensitive to. See referenced issue for details.

See: #19418
(cherry picked from commit 5adcac19)

(cherry picked from commit ee16c509)

(cherry picked from commit 45b5fbb3)

(cherry picked from commit 23c47aa0)

(cherry picked from commit 5f574baf)

(cherry picked from commit 9da16ff1)

Clang (rightly) detects that the `PyCFunction` cast is between invalid
function pointer types. Ignore the warning in-code because we know it is
fine due to the `METH_KEYWORDS` flag for the method.

(cherry picked from commit e83f01c9)

Found with Xcode 15.4 as a warning.

(cherry picked from commit 03b9afcd)