Merge topic 'fix_deprecation_warning_get_faces' into release

5c4687d6 Keep GetFaces as GetSerializedCellFaces for legacy vtkUnstructuredGridWriter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !11558

Common/DataModel/vtkCellIterator.cxx

@@ -146,6 +146,13 @@ void vtkCellIterator::GetCell(vtkGenericCell* cell)
   }
 }
 
+//------------------------------------------------------------------------------
+// To be removed when deprecating
+vtkIdList* vtkCellIterator::GetFaces()
+{
+  return this->GetSerializedCellFaces();
+}
+
 //------------------------------------------------------------------------------
 vtkCellIterator::vtkCellIterator()
   : CellType(VTK_EMPTY_CELL)

Common/DataModel/vtkCellIterator.h

@@ -123,6 +123,12 @@ public:
    */
   vtkCellArray* GetCellFaces();
 
+  /**
+   * Get a serialized view of the faces for a polyhedral cell.
+   * This is only valid when CellType is VTK_POLYHEDRON.
+   */
+  vtkIdList* GetSerializedCellFaces();
+
   /**
    * Get the faces for a polyhedral cell. This is only valid when CellType
    * is VTK_POLYHEDRON.
@@ -280,8 +286,7 @@ inline vtkCellArray* vtkCellIterator::GetCellFaces()
 }
 
 //------------------------------------------------------------------------------
-// To be removed when deprecating
-inline vtkIdList* vtkCellIterator::GetFaces()
+inline vtkIdList* vtkCellIterator::GetSerializedCellFaces()
 {
   if (!this->CheckCache(FacesFlag))
   {

IO/Legacy/vtkUnstructuredGridWriter.cxx

@@ -146,7 +146,7 @@ int vtkUnstructuredGridWriter::WriteCellsAndFaces(
     }
     else
     {
-      expandedCells->InsertNextCell(it->GetFaces());
+      expandedCells->InsertNextCell(it->GetSerializedCellFaces());
     }
   }