Merge topic 'xarray_plugin'

29dedd2c Fix documentation
0002e702 Add testing for time.
08c4412e Fix typo
a5aa9083 Remove logging

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Sebastien Jourdain <sebastien.jourdain@kitware.com>
Merge-request: !11923

IO/NetCDF/Testing/Python/NetCDFCFSphericalCoords.py

 #!/usr/bin/env python
 from GetReader import get_reader
+from vtkmodules.vtkCommonExecutionModel import vtkStreamingDemandDrivenPipeline
 from vtkmodules.vtkFiltersCore import (
     vtkAssignAttribute,
     vtkThreshold,
@@ -23,7 +24,14 @@ VTK_DATA_ROOT = vtkGetDataRoot()
 # Open the file.
 reader = get_reader(VTK_DATA_ROOT + "/Data/tos_O1_2001-2002.nc")
 # Set the arrays we want to load.
-reader.UpdateMetaData()
+reader.UpdateInformation()
+info = reader.GetOutputInformation(0)
+assert info.Has(vtkStreamingDemandDrivenPipeline.TIME_STEPS()), "Time dependent dataset does not have TIME_STEPS key"
+# the exact times are not the same between NetCDFCF and XArray
+# accessors, because XArray converts the original NetCDF datetime
+# (based on a certain calendar) to numpy datetime64.
+times = info.Get(vtkStreamingDemandDrivenPipeline.TIME_STEPS())
+assert len(times) == 24 and (times[23]) - times[0] == (705.0 - 15.0), "Number of time steps or time values are wrong."
 reader.SetVariableArrayStatus("tos",1)
 reader.SetSphericalCoordinates(1)
 aa = vtkAssignAttribute()

Wrapping/Python/vtkmodules/util/xarray_support.py

@@ -109,9 +109,7 @@ class vtkXArrayCFReader(VTKPythonAlgorithmBase):
         VTKPythonAlgorithmBase.__init__(
             self, nInputPorts=0, nOutputPorts=1, outputType="vtkDataObject"
         )
-        logging.basicConfig(level=logging.DEBUG)
         self._log = logging.getLogger("vtkXArrayCFReader")
-        self._log.setLevel(logging.DEBUG)
         self._filename = None
         self._timesteps = None
         self._timeindex = None
@@ -130,7 +128,6 @@ class vtkXArrayCFReader(VTKPythonAlgorithmBase):
                 self.Modified()
             return getattr(self._reader, name)
         else:
-            logging.error(f"Attribute '{name}' is not forwarded.")
             raise AttributeError()
 
     def SetFileName(self, name):
@@ -193,7 +190,7 @@ class vtkXArrayCFReader(VTKPythonAlgorithmBase):
             self._log.debug("Whole extent: {}".format(ext))
             oi.Set(vtkStreamingDemandDrivenPipeline.WHOLE_EXTENT(), ext, 6)
         if roi.Has(vtkAlgorithm.CAN_HANDLE_PIECE_REQUEST()):
-            roi.Set(vtkAlgorithm.CAN_HANDLE_PIECE_REQUEST(), 1)
+            oi.Set(vtkAlgorithm.CAN_HANDLE_PIECE_REQUEST(), 1)
         if roi.Has(vtkAlgorithm.CAN_PRODUCE_SUB_EXTENT()):
             oi.Set(vtkAlgorithm.CAN_PRODUCE_SUB_EXTENT(), 1)
         return 1