If 'nmat' is not positive, 'inputsPerMaterial' becomes meaningless but is used anyway,
bail early if so.

Also replaced ISO-8859 'squared' character with ASCII "^2",
since it was confusing my text editor and git diff.

Change-Id: I480447340a2ff541453eddce8c090d8e31e2a01a

If 'g' was null, it was unconditionally
dereferenced.  Now, return false for
IsStructureValid(null).  Since it's a public
API, this seemed like a better choice than
an assert.

Change-Id: Iba9e2f993a7d6fa0875d8002e0db1b056d091778

Added assert to make analyzer understand
that the parameter will never be null.
(Presumably it never is, since it'd be
crashing.)

Change-Id: I3081ddb81199bfbf47cf2ccbe2b63a467cf239b7

Added default case to switch so that returned
pointer value is null instead of undefined.
Also initialized some pointers to null.
Analyzer still warns about improbable paths
that would deref null, but that's better than
derefing a random pointer at least.

Change-Id: I0fd5bc9c975411379994a0fb1002676ba759c85d

Change-Id: I753af97065c413eaee8bdaf604f521cf6bb8933a

Change-Id: I7ed36ce0e2988ba1a92459678d821a7ab8c77e80

Change-Id: I7d95e993b158bdbae04f2d84cb35d843383044eb

Change-Id: I52e29e65e732af8c247b472dc4e92935f4b0d0f6

moved default value into switch (should be impossible
with only 2 values of the enum, but I perserved the old behaviour)

Change-Id: Iba918245d9d8b77ffcb07cc9129f2592dd440bab

No warnings were actually fixed.  Removed some unnecessary checks for null before delete(), changed some variables used as booleans to real 'bool's, moved some declarations together with initial assignment, made some private globals static.

Change-Id: I76d54ae907dc504866576df935c9a47e71785f68

Remove several useless stores just before assert(0)
and add 'return' statement too.

Change-Id: I494d11d0ce3312bb82a094ec0d90451aa208b782

Change-Id: Idc7cafc9c7aeed9c01443efed0892cccb459ac0f

Change-Id: Ia2764b7a34514fd83e48ce10d3866f8f8091f987

Change-Id: If42caf9e6935a098f165493bc782bfe38b553905

Added 'return' after an vtkErrorMacro, just like every other vtkErrorMacro in this method.

Change-Id: Ife0f7526c31b21a5e99d2abd7101a4043c4f34d1

Change-Id: I361e472426ce927b301ea01a8c1a6680aa5c6438

If 'numDeleted' is not 2 nor 1, 'tri' was used uninitialized; call vtkErrorMacro instead.

Change-Id: Ia0e508184a37e07f3186e192a166d1f38c79cbdb

a) suppress null deref warning with assert
b) fixed null deref of 'cell' by bailing early
c) changed error test of an existing vtkErrorMacro and added 'return' to prevent 1) infinite loop (of count VTK_LARGE_INTEGER) and 2) null deref of 'minCells'

Change-Id: Iebc64b79b51fd30ac714be4d067e344321d2a17f

If GetNumberOfTuples returns more than 3 (probably never happens generally) the 'for' loop will read past the end of 'eigenvaluesGroundTruth', fixed by defensively bailing early if necessary.

Change-Id: Id7c7c6b8549b42912b993bc1582fdf69422c223f

The store to 'np' is definitely dead, but suspicious.  Perhaps it should be assigning to a different variable? Perhaps it's leftover copy-paste?

Change-Id: I79ec354985f7f0859b790702821a3c08520cbf5f

First store is useless because 'continue' statement results in it being overwritten in the next loop.  Second is useless because value is always overwritten later before it's read.

Change-Id: Ibd5f44dc52a0e58559e4a096743fc78a509fac4d

Change-Id: Ica56d71e3ae4b230b5cbe97df7a784b47970fa83

Exact same assignment is made later on, and right before usage.

Change-Id: I113c924d0d0fc8b2d268cbfbdc857dcb1bd40d7a

An 'abort' variable to exit a loop early was redundant with a 'break' statement in the loop.

Change-Id: Iad88d4b4fbf4d3fea9ee996c6c43a4aa55fc09cd

An 'abort' variable to exit a loop early was redundant with a 'break' statement in the loop.

Change-Id: Ifa7dc3bd9a58742ff9acc30de530f134e642ed85

Store to 'x' in loop is useless since it's overwritten in all cases below.

Change-Id: I6f09ecb8ca37bdbd4abe817856852354109e2e23

Useless store to local variable right before a return.

Change-Id: I0bd514edec4c7e7ac5409f68c50dae6bdee5a056

If neither 'DMapData' nor 'MapData' get set, 'results' is read uninitialized; added 'else' case and bail out instead.

Change-Id: Ifa35e7ff76a1d3d9e74d446f1b9f3c4b42e3bc9a

In an error code path, vtkErrorMacro is used but the 'return' was omitted (every other vtkErrorMacro is paired with return), execution would then continue and pass null to memcpy.

Also removed unrelated useless test for null before using delete.

Change-Id: I9d63fae00080c2fca5974442d8bd2f936fcf0790

The pointer was being checked for null, but only logged; now return too.

Change-Id: Id9af0f968fc4fd626d9eec79af1ee22aebdc6cc6

Change-Id: I20c684c0151ea7dab1575d003b40b78e5da2b809

Change-Id: I6a4fef51ca87fa256fc33ef6919b9bea4dbc3e9b

d5e12400 Initialize row_pointers
adf24a53 Fix memory leak in vtkPNGWriter when OutOfDiskSpaceError

42746d05 Add NaN support in web chart rendering

Change-Id: I4b848a00c553f0e5429521245572b526daa0d565

c68b549e Ensure libproj4 defaults to use pthreads if VTK does

a162be1f 14196: Allow unicode path in vtkLoadPythonTkWidgets.py.

Change-Id: I401d622e28e62d78ed850c36f5270a682f08a2c0

399f778d Disabling translation and scaling now works.

0b42c0e7 InsertNextCell and related method now return the proper vtkIdType.