- Oct 17, 2017
-
-
7153597d Fixed undefined behaviour in PLY code Acked-by:
Kitware Robot <kwrobot@kitware.com> Acked-by:
Ben Boeckel <ben.boeckel@kitware.com> Reviewed-by:
David Gobbi <david.gobbi@gmail.com> Merge-request: !3428
-
d497027e Add new baseline. Acked-by:
Brad King <brad.king@kitware.com> Merge-request: !3454
-
b5bdeda6 Lighting fix: single headlight ignored it's diffuse color Acked-by:
David E. DeMarle <dave.demarle@kitware.com> Merge-request: !3450
-
9ead442e develop.md: Update Leading Line indicating +1 means ready for integration Acked-by:
-
Allison Vacanti authored
-
Aron Helser authored
When only a single headlight was active with intensity 1, it used a simplified shader that ignored the light's (diffuse) color. Add the color as a shader param and use it for this case.
-
Jean-Christophe Fillion-Robin authored
For reference, see https://www.vtk.org/pipermail/vtk-developers/2017-October/035502.html
-
844eb614 Updated example to show both Retina and non-Retina Acked-by:
-
Sean McBride authored
Also added a vtkTextActor with Japanese text as a demonstration of how to get the macOS system font appropriate for passing to VTK. Updated read me and screenshot.
-
- Oct 16, 2017
-
-
6b106fb0 Update TestConnectivityFilter 2958a034 Change superclass of vtkConnectivityFilter f2b71559 Updated vtkConnectivityFilter documentation 0d79bd2a Produce different output types for connectivity filter Acked-by:
Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Reviewed-by:
Bill Lorensen <bill.lorensen@gmail.com> Merge-request: !3440
-
d4489673 Added PrintSelf std outs for member variables of SegY reader 0dd74fc4 Added a vertical reference system variable to SegY reader 8d9ffa5d Fix segy depth calculation Acked-by:
-
21d2a440 Check that docstrings are utf-8 478c4a6b Use tp_doc to store docstrings for wrappers. Acked-by:
-
a7ccda9b Improve test for plane through middle of a 2 voxel volume d0b75c95 Increase volume spacing for testing purposes 8c74b6cd Turn off auto adjust sample distances a30151d0 Added new test for plane passing through volume 48a2a5fd Updated baseline for two component dependent test f3c6422e Fixed off by one in one dimension for picking c0c01051 Fixed cell to point computation Acked-by:
-
442381f5 Fixed numerous warnings from the new cppcheck 1.81 Acked-by:
Allison Vacanti <allison.vacanti@kitware.com> Merge-request: !3445
-
Sankhesh Jhaveri authored
-
Sankhesh Jhaveri authored
This variable dictates whether the vertical axis follows a heights reference i.e. positive up, or a depths reference i.e. positive down.
-
Sankhesh Jhaveri authored
The samples are equidistant along the total depth with a distance of sampleInterval between them. This change also fixes the unit conversion from micro to milli in the depth calculation.
-
65e4970a Removed some MS warning suppressions, and fixed other warnings Acked-by:
Ken Martin <ken.martin@kitware.com> Merge-request: !3435
-
Cory Quammen authored
Change variable type too accommodate changes in GetOutput()'s return type.
-
Cory Quammen authored
Because vtkConnectivityFilter may produce a vtkPolyData as output, change the base class from vtkUnstructuredGridAlgorithm to vtkPointSetAlgorithm. This provides convenience methods for accessing the output as different types, e.g., GetUnstructuredGridOutput() and GetPolyDataOutput(). This will break backwards compatibility where callers to vtkConnectivityFilter::GetOutput() assign the value returned to a vtkUnstructuredGrid pointer or invoke uninherited API in vtkUnstruturedGrid from a temporary returned by GetOutput(). Changing the call from GetOutput() to GetUnstructuredGridOutput() is that path forward in such cases. Note that GetUnstructuredGridOutput() will return nullptr if the input to vtkConnectivityFilter is a vtkPolyData (its output will be a vtkPolyData).
-
Cory Quammen authored
-
Cory Quammen authored
This changes the vtkConnectivityFilter so that it produces a vtkPolyData when the input is a vtkPolyData and a vtkUnstructuredGrid when the input is anything else. It used to produce only vtkUnstructuredGrid outputs.
-
- Oct 15, 2017
-
-
Sean McBride authored
Specifically: very strange braces! syntaxError,Common/DataModel/vtkHyperTreeGrid.cxx:699,error,syntax error changed size()>0 to !empty() stlSize,Filters/General/vtkLoopBooleanPolyDataFilter.cxx:1426,performance,Possible inefficient checking for 'nocellregion' emptiness. This useless flag has been there since code was added in 2000 in f50b0909 knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:323,style,Condition 'flag' is always true knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:415,style,Condition 'flag' is always true knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:788,style,Condition 'flag' is always true knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:879,style,Condition 'flag' is always true This useless 'result' has been there since code was added in 2003 in dd39b9e4 knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:236,style,Condition 'result' is always true knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:245,style,Condition 'result' is always true knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:254,style,Condition 'result' is always true New check in cppcheck 1.81, block is indeed dead code: oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:272,warning,Opposite inner 'if' condition leads to a dead code block. oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:293,warning,Opposite inner 'if' condition leads to a dead code block. oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:349,warning,Opposite inner 'if' condition leads to a dead code block. false positive, suppressed with zero initialization: uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:810,error,Uninitialized variable: curDistance uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:812,error,Uninitialized variable: curDistance free(NULL) is allowed, so just remove null check knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:920,style,Condition 'truthIds' is always false knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:956,style,Condition 'diskFile' is always false Simplified the calculation, verified same codegen on x86_64 with godbolt shiftTooManyBitsSigned,Rendering/Volume/vtkHAVSVolumeMapper.cxx:53,error,Shifting signed 32-bit value by 31 bits is undefined behaviour These have all been thus since their inception, but a global search find the same pattern in TestDijkstraGraphGeodesicPath.cxx, from which I copied the apparent solution knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:119,style,Condition 'distanceOffsetSpecified' is always false knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:199,style,Condition 'distanceOffsetSpecified' is always false knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:244,style,Condition 'distanceOffsetSpecified' is always false knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:325,style,Condition 'distanceOffsetSpecified' is always false knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:117,style,Condition 'distanceOffsetSpecified' is always false knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:189,style,Condition 'distanceOffsetSpecified' is always false Toggle with #if instead knownConditionTrueFalse,Imaging/Hybrid/vtkSurfaceReconstructionFilter.cxx:300,style,Condition 'orientationPropagation' is always true Added parens clarifyCalculation,Common/DataModel/vtkLagrangeWedge.cxx:906,style,Clarify calculation precedence for '/' and '?'.
-
David Gobbi authored
Python 3 requires that static docstrings are utf-8, otherwise there is undefined behavior (corruption, segfault) during initialization.
-
- Oct 14, 2017
-
-
1b0571a5 Fix some dashboard issues. Acked-by:
-
David Thompson authored
+ Skip tests where the render window is generating images the wrong size. + Use stupid parentheses to make cppcheck happy.
-
- Oct 13, 2017
-
-
David Gobbi authored
Previously, the docstrings were broken into 500-byte segments to be within the minimum literal string length limit for C89/C++96. C++11 increases the limit to 65536.
-
05e2f1bf Exclude vtkLASReader from build all. Acked-by:
-
d636213c Fix tabs and utf-8 quotes in source code Acked-by:
-
957edf2c Add benchmarking code for vtkmLevelOfDetail. Acked-by:
Sujin Philip <sujin.philip@kitware.com> Merge-request: !3392
-
Allison Vacanti authored
Also bump VTK-m to bring in the new VertexClustering impl.
-
Dan Lipsa authored
-
- Oct 12, 2017
-
-
David Gobbi authored
Some VTK source code still had tabs (even some of the .py files!). Also, several comments used utf-8 quotes, which are hard to tell from regular quotes by eye and can lead to confusing mistakes.
-
e191a653 Merge branch 'upstream-xdmf3' into revert-xdmf3-noboost c368e870 xdmf3 2017-10-12 (4fb8185c) e4796b96 revert XDMF3 machinery to just before boost removal Acked-by:
Cory Quammen <cory.quammen@kitware.com>
Merge-request: !3439 -
bbf6e832 Suppress "decimal digit terminates octal escape sequence" Acked-by:
-
1df424ee Update VTK-m Acked-by:
-
David E. DeMarle authored
* upstream-xdmf3: xdmf3 2017-10-12 (4fb8185c)
-
Kitware Robot authoredCode extracted from: git://xdmf.org/Xdmf.git at commit 4fb8185cf479ced0d6782375189d3f6ed4cf98d6 (master). -
David E. DeMarle authored
but keep the conversion warning fix in the writer
-
David Gobbi authored
MSVC emits warning C4125 when it encounters an octal escape sequence that is followed by one or more digits. These escape sequences can occur in the automatically-generated docstrings for the Python wrappers.
-
