Add an option to interleave the datasets across the workers instead
of assigning blocks. This helps load balance certain types of datasets.

also correct some copy paste doc and alphabetize problems in
related files.

Note, approach for BMP is a little different in that I modified the
parent class to allow ostringstream. As such I had to change more
than just the one writer. On the up side, that should facilitate
making the same change to a handful of other writers.

Robbie Li authored 7 years ago and Brad King committed 7 years ago

On Windows, the vtksys::SystemTools::Fopen() function uses the cmake
KWSYS_ENCODING_DEFAULT_CODEPAGE setting for the encoding of filenames.
After this change, people can build VTK libraries that use utf8
filenames by setting KWSYS_ENCODING_DEFAULT_CODEPAGE=CP_UTF8.

This variable dictates whether the vertical axis follows a heights
reference i.e. positive up, or a depths reference i.e. positive down.

The samples are equidistant along the total depth with a distance of
sampleInterval between them. This change also fixes the unit conversion
from micro to milli in the depth calculation.

Specifically:

very strange braces!
syntaxError,Common/DataModel/vtkHyperTreeGrid.cxx:699,error,syntax error

changed size()>0 to !empty()
stlSize,Filters/General/vtkLoopBooleanPolyDataFilter.cxx:1426,performance,Possible inefficient checking for 'nocellregion' emptiness.

This useless flag has been there since code was added in 2000 in f50b0909
knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:323,style,Condition 'flag' is always true
knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:415,style,Condition 'flag' is always true
knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:788,style,Condition 'flag' is always true
knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:879,style,Condition 'flag' is always true

This useless 'result' has been there since code was added in 2003 in dd39b9e4
knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:236,style,Condition 'result' is always true
knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:245,style,Condition 'result' is always true
knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:254,style,Condition 'result' is always true

New check in cppcheck 1.81, block is indeed dead code:
oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:272,warning,Opposite inner 'if' condition leads to a dead code block.
oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:293,warning,Opposite inner 'if' condition leads to a dead code block.
oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:349,warning,Opposite inner 'if' condition leads to a dead code block.

false positive, suppressed with zero initialization:
uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:810,error,Uninitialized variable: curDistance
uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:812,error,Uninitialized variable: curDistance

free(NULL) is allowed, so just remove null check
knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:920,style,Condition 'truthIds' is always false
knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:956,style,Condition 'diskFile' is always false

Simplified the calculation, verified same codegen on x86_64 with godbolt
shiftTooManyBitsSigned,Rendering/Volume/vtkHAVSVolumeMapper.cxx:53,error,Shifting signed 32-bit value by 31 bits is undefined behaviour

These have all been thus since their inception, but a global search find the same pattern in TestDijkstraGraphGeodesicPath.cxx, from which I copied the apparent solution
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:119,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:199,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:244,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:325,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:117,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:189,style,Condition 'distanceOffsetSpecified' is always false

Toggle with #if instead
knownConditionTrueFalse,Imaging/Hybrid/vtkSurfaceReconstructionFilter.cxx:300,style,Condition 'orientationPropagation' is always true

Added parens
clarifyCalculation,Common/DataModel/vtkLagrangeWedge.cxx:906,style,Clarify calculation precedence for '/' and '?'.

but keep the conversion warning fix in the writer

After reading the docs for some of the warnings, I think many are obsolete and can be unsuppressed.

3 PLY tests were failing under UBSan.

All fixed by clamping values when converting between types.

Color by classification or intensity.

This determines the point scalar (classification or RGB)

This is based on work by Jatin Parekh in the
VTK’s Second Google Summer of Code with Aashish Chaudhary
as adviser.

Some real issues here.

This topic catches another batch of NULL conversions that
clang did not handle for various reasons. It also includes
a number of changes to comments and strings where NULL was
used. It also catches some recent code changes where NULL
was used instead of nullptr.

Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
wrap =delete;

This generalize ColumnArraySelection
at XMLReader level

the declspec warning is safe particularly as this is an internal
class not intended to be part of the public API.

Does not make sense for OpenGL2 and is not implemented
Also deprecate PainterDelegate

Now that VTK requires a C++11 compiler we can ditch using custom typedefs

Adding in functionality to allow inserting vtkNew objects into
stl containers of vtkSmartPointer objects as well as comparisons
between vtkNew objects and raw pointers. Also removing Get() and
GetPointer() calls from vtkNew objects since in most instances we
can just pass in the vtkNew<> object instead of having to use the
Get() or GetPointer() methods to get the raw pointer.

Louis Amore authored 7 years ago and Mathieu Westphal (Kitware) committed 7 years ago

vtkXMLDataObjectWriter is a superclass for vtkXMLDataSetWriter and other
non-DataSet writers