Specifically:

very strange braces!
syntaxError,Common/DataModel/vtkHyperTreeGrid.cxx:699,error,syntax error

changed size()>0 to !empty()
stlSize,Filters/General/vtkLoopBooleanPolyDataFilter.cxx:1426,performance,Possible inefficient checking for 'nocellregion' emptiness.

This useless flag has been there since code was added in 2000 in f50b0909
knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:323,style,Condition 'flag' is always true
knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:415,style,Condition 'flag' is always true
knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:788,style,Condition 'flag' is always true
knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:879,style,Condition 'flag' is always true

This useless 'result' has been there since code was added in 2003 in dd39b9e4
knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:236,style,Condition 'result' is always true
knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:245,style,Condition 'result' is always true
knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:254,style,Condition 'result' is always true

New check in cppcheck 1.81, block is indeed dead code:
oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:272,warning,Opposite inner 'if' condition leads to a dead code block.
oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:293,warning,Opposite inner 'if' condition leads to a dead code block.
oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:349,warning,Opposite inner 'if' condition leads to a dead code block.

false positive, suppressed with zero initialization:
uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:810,error,Uninitialized variable: curDistance
uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:812,error,Uninitialized variable: curDistance

free(NULL) is allowed, so just remove null check
knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:920,style,Condition 'truthIds' is always false
knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:956,style,Condition 'diskFile' is always false

Simplified the calculation, verified same codegen on x86_64 with godbolt
shiftTooManyBitsSigned,Rendering/Volume/vtkHAVSVolumeMapper.cxx:53,error,Shifting signed 32-bit value by 31 bits is undefined behaviour

These have all been thus since their inception, but a global search find the same pattern in TestDijkstraGraphGeodesicPath.cxx, from which I copied the apparent solution
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:119,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:199,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:244,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:325,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:117,style,Condition 'distanceOffsetSpecified' is always false
knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:189,style,Condition 'distanceOffsetSpecified' is always false

Toggle with #if instead
knownConditionTrueFalse,Imaging/Hybrid/vtkSurfaceReconstructionFilter.cxx:300,style,Condition 'orientationPropagation' is always true

Added parens
clarifyCalculation,Common/DataModel/vtkLagrangeWedge.cxx:906,style,Clarify calculation precedence for '/' and '?'.

David Thompson authored 7 years ago and Kitware Robot committed 7 years ago

1b0571a5 Fix some dashboard issues.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ken Martin <ken.martin@kitware.com>
Merge-request: !3449

+ Skip tests where the render window is generating images the wrong size.
+ Use stupid parentheses to make cppcheck happy.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

05e2f1bf Exclude vtkLASReader from build all.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !3444

David Gobbi authored 7 years ago and Kitware Robot committed 7 years ago

d636213c Fix tabs and utf-8 quotes in source code

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: David E. DeMarle <dave.demarle@kitware.com>
Reviewed-by: Bill Lorensen <bill.lorensen@gmail.com>
Merge-request: !3442

Allison Vacanti authored 7 years ago and Kitware Robot committed 7 years ago

957edf2c Add benchmarking code for vtkmLevelOfDetail.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Sujin Philip <sujin.philip@kitware.com>
Merge-request: !3392

Also bump VTK-m to bring in the new VertexClustering impl.

Some VTK source code still had tabs (even some of the .py files!).
Also, several comments used utf-8 quotes, which are hard to tell
from regular quotes by eye and can lead to confusing mistakes.

David E. DeMarle authored 7 years ago and Kitware Robot committed 7 years ago

e191a653 Merge branch 'upstream-xdmf3' into revert-xdmf3-noboost
c368e870 xdmf3 2017-10-12 (4fb8185c)
e4796b96 revert XDMF3 machinery to just before boost removal

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !3439

David Gobbi authored 7 years ago and Kitware Robot committed 7 years ago

bbf6e832 Suppress "decimal digit terminates octal escape sequence"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !3438

Sujin Philip authored 7 years ago and Kitware Robot committed 7 years ago

1df424ee Update VTK-m

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Allison Vacanti <allison.vacanti@kitware.com>
Merge-request: !3437

* upstream-xdmf3:
  xdmf3 2017-10-12 (4fb8185c)

Code extracted from:

    git://xdmf.org/Xdmf.git

at commit 4fb8185cf479ced0d6782375189d3f6ed4cf98d6 (master).

but keep the conversion warning fix in the writer

MSVC emits warning C4125 when it encounters an octal escape sequence
that is followed by one or more digits.  These escape sequences can
occur in the automatically-generated docstrings for the Python wrappers.

Includes fixes for cuda 9 compilation issues.

Ken Martin authored 7 years ago and Kitware Robot committed 7 years ago

1c220560 try to fix compiler warning on eeloo

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3436

David Thompson authored 7 years ago and Kitware Robot committed 7 years ago

64fab1f7 Fix an array with the wrong length.
98c6691b Fix face comparison in unstructured grid geometry filter.
5c52fba9 Fix face normals for Lagrange tetrahedra.
05d09d4b Implement 21-point wedge; fix others.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !3426

Not really sure why the old code produced the warning
but maybe this will fix it.

David Gobbi authored 7 years ago and Kitware Robot committed 7 years ago

b2bed375 Fix comment-to-string wrapping error

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !3433

Dan Lipsa authored 7 years ago and Kitware Robot committed 7 years ago

4af82846 Additional baseline for LAS reader.
c477969c Wrap LAS reader.
ac5226b6 Remove comments.
b08645b0 Handle color in the test program.
a898ac32 Test 2 las files
755e1028 Save color, classification and intensity as scalar values.
b15feea6 Delete unnecessary class vars and cleanup file.
5340dfd9 Read the Point Data Record format from the header.
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Aashish Chaudhary <aashish.chaudhary@kitware.com>
Merge-request: !3419

When building docstrings, the wrappers were passing utf-8 codes
(or, in fact, any extended 8-bit codes) verbatim from the comment
to the string literal.  It is safer to convert extended 8-bit codes
to octal escape codes, which the compiler can read regardless of
what encoding the compiler is expecting.

Thanks to Ben and TJ.

This changes the order of points in the output Lagrange triangles
so that their normals always point outwards.

Color by classification or intensity.

This determines the point scalar (classification or RGB)

This is based on work by Jatin Parekh in the
VTK’s Second Google Summer of Code with Aashish Chaudhary
as adviser.

Ken Martin authored 7 years ago and Kitware Robot committed 7 years ago

d6544480 fix some warnings that eeloo found

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !3431

Utkarsh Ayachit authored 7 years ago and Kitware Robot committed 7 years ago

03f51c11 vtkGenericEdgeTable: Fix potentially uninitialized warning.
f061250f Fix potential overflow.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: David Gobbi <david.gobbi@gmail.com>
Reviewed-by: Ken Martin <ken.martin@kitware.com>
Merge-request: !3430

Some real issues here.