Skip to content
Snippets Groups Projects
Commit bc8b0a56 authored by Utkarsh Ayachit's avatar Utkarsh Ayachit Committed by Kitware Robot
Browse files

Merge topic 'missing_modified_event'


3d720e75 Ensure ModifiedEvent is fired after changing ViewUp.

Acked-by: default avatarKitware Robot <kwrobot@kitware.com>
Acked-by: default avatarKen Martin <ken.martin@kitware.com>
Merge-request: !3472
parents 08798dc5 3d720e75
No related branches found
No related tags found
No related merge requests found
......@@ -725,6 +725,11 @@ void vtkCamera::Pitch(double angle)
this->ViewUp[0] = savedViewUp[0];
this->ViewUp[1] = savedViewUp[1];
this->ViewUp[2] = savedViewUp[2];
// this is needed since the last time Modified was called (in SetFocalPoint),
// the ViewUp was not same as savedViewUp. Since we're changing its value
// here, we need to fire Modified event. We don't call `SetViewUp` since we
// don't want the computation of the view transform to happen again.
this->Modified();
}
//----------------------------------------------------------------------------
......@@ -783,6 +788,11 @@ void vtkCamera::Elevation(double angle)
this->ViewUp[0] = savedViewUp[0];
this->ViewUp[1] = savedViewUp[1];
this->ViewUp[2] = savedViewUp[2];
// this is needed since the last time Modified was called (in SetPosition),
// the ViewUp was not same as savedViewUp. Since we're changing its value
// here, we need to fire Modified event. We don't call `SetViewUp` since we
// don't want the computation of the view transform to happen again.
this->Modified();
}
//----------------------------------------------------------------------------
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment