Brad King authored 3 years ago and Kitware Robot committed 3 years ago

e47dfce7 CMP0128: Enable/disable extensions if standard same as default

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !6723

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

b1edd6e7 Fortran: Save frontend variant persistently for IntelLLVM

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6718

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

220f78e2 TI: Recognize invalid compiler option warning during try_compile()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6705

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

190d2b5d gitlab-ci: Update Windows jobs to VS 2022
ac327949 gitlab-ci: Re-organize Windows job tags

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6724

This was intended to be part of the initial MR (!6177), but accidentally went
missing when debugging nightly failures on less common systems. Noticed during
!6711 review as the comment about this behaviour didn't match the code.

Documentation for CMP0128 is updated to remove a false case and note the two
cases related to this.

Fixes #22224.

Name the tag groups based on the VS version needed.

Merge-request: !6718

Merge-request: !6718

William R. Dieter authored 3 years ago and Brad King committed 3 years ago

Since commit a90d2a9e (IntelLLVM: Add support for Intel LLVM-based
compilers, 2020-11-02, v3.20.0-rc1~89^2~20), our IntelLLVM compiler
support populates `CMAKE_Fortran_COMPILER_FRONTEND_VARIANT`.  However,
the frontend variant was not stored in `CMakeCompilerFortran.cmake`.

Signed-off-by: William R. Dieter <william.r.dieter@intel.com>

Craig Scott authored 3 years ago and Brad King committed 3 years ago

Fixes: #22866

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

48f29b58 IntelLLVM: Use MSVC linker with MSVC frontend variant

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6719

Merge-request: !6719

William R. Dieter authored 3 years ago and Brad King committed 3 years ago

The Intel compiler (pre-LLVM) expected xilink.exe and had special logic to
set xilink.exe.  The newer LLVM-based compiler does not want xilink.exe.
link.exe works better for host code, and is the default, so change
the matching condition such that the old compiler matches (and gets
xilink.exe) and the new compiler gets the default link.exe it expects.

A better solution will be to use the compiler as the linker.  A future
change will switch to compiler as linker by default, but that fix needs
more validation.

Signed-off-by: William R. Dieter <william.r.dieter@intel.com>

Craig Scott authored 3 years ago and Kitware Robot committed 3 years ago

8371056f Help: Correct inaccuracies in wording for CMP0128

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Raul Tambre <raul@tambre.ee>
Merge-request: !6711

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

24455099 PCH: Fixed Ninja Multi-Config and REUSE_FROM for MSVC

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !6713

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

95fa27d9 PCH: Fix REUSE_FROM when Debug and RelWithDebInfo configs differ

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !6712

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

6dc64124 Help: Use stronger wording in rule about preset inheritance

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6710

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

d51246c6 VS: Default TargetFrameworkVersion to v4.7.2 for VS 2022
f97f8537 VS: Model a default target framework
e40ceddd cmVisualStudio10TargetGenerator: Refactor target framework selection
78782cc7 cmGlobalVisualStudio8Generator: Refactor SetGeneratorPlatform

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6699

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

84667a6f Help: Clarify valid versus supported values for CUDA_STANDARD

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Raul Tambre <raul@tambre.ee>
Merge-request: !6707

The copy_idb_pdb.cmake script would be executed for every configuration
for all configurations.

Debug would still want to get the RelWithDebInfo files, and the other
way around.

If the Debug configuration contains `/ZI` but the RelWithDebInfo doesn't
then the copy_pdb_idb.cmake script will cause problems due to the fact
that it was common for both configurations but they are incompatible
with each other.

Craig Scott authored 3 years ago and Kitware Robot committed 3 years ago

76c02814 Help: Clarify how PKG_CONFIG env var initializes cache vars

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6706

CMake 3.18 added the first support for any compiler for 17 and 20,
but those were recognized as valid values in earlier CMake versions
even though there was no compiler that supported them. Make this
distinction clear to avoid creating the impression that these standards
could be usefully used before CMake 3.18.

While 98 is recognized as a valid value, it also just gets treated as 03
internally. Document this behavior as well.

Fixes: #22711

Fixes: #22870

MSBuild defaults to v4.0 but VS 2022 does not install it anymore.
Explicitly specify a newer framework version by default.  Use a
version that VS 2022 installs without selecting a separate component.

Fixes: #22835

Add fields to the VS generator to select a target framework.
Migrate the existing default for VS 12 .NET CF for Windows CE.

Report the values in `CMAKE_VS_*` variables and use them for
the CSharp compiler id project too.

Issue: #22849

Split the selection from the generation of the resulting element(s).

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

95f44e00 Ninja Multi-Config: Fix custom command target dependencies in cross-configs
a8833639 Ninja Multi-Config: Fix internal cross-config target dependency ordering
16e24748 Ninja Multi-Config: Fix cross-config custom command dependency tracing

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !6702

Brad King authored 3 years ago and Kitware Robot committed 3 years ago

58c8d649 CheckLinkerFlag: Set policies needed by the implementation

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6701

Thomas Dickerson authored 3 years ago and Brad King committed 3 years ago

The module was added in CMake 3.18 by commit af96c0f4
(CheckLinkerFlag: Add module to check validity of linker flags,
2020-05-16, v3.18.0-rc1~103^2), but it is still possible for projects to
use it without setting policies to the 3.18 version level.

Generator expressions in a non-cross custom command's `COMMAND`
arguments are evaluated in the command config.  Target-level
dependencies implied by `TARGET_FILE` must therefore be cross
dependencies.  This is important to generate proper target-level
dependencies on the cross-config build statements for the target to
which the custom command is attached.

Fixes: #22855

In commit 7abc3d61 (Ninja Multi-Config: Fix issue with framework
dependencies and Autogen, 2020-02-13, v3.17.0-rc2~18^2) the `cmLinkItem`
comparison operator was updated to order identical strings by the
cross-config boolean.  We need to order identical targets that way too
in order to represent both a cross and non-cross dependency on the same
target.

Issue: #22855

Process `CMAKE_CROSS_CONFIGS` and friends to properly configure the
generator for cross-config behavior before custom command dependency
tracing.