Skip to content
Snippets Groups Projects
  1. Sep 07, 2017
  2. Sep 06, 2017
  3. Sep 05, 2017
  4. Sep 01, 2017
    • Brad King's avatar
      Merge branch 'fix-genex-SOURCES' into release-3.9 · 2820de21
      Brad King authored
      Merge-request: !1218
      2820de21
    • Brad King's avatar
      Genex: Fix TARGET_PROPERTY value of SOURCES · 068cc545
      Brad King authored
      Refactoring in commit v3.8.0-rc1~445^2~2 (cmTarget: Move sanity checks
      and computed property access to callers, 2016-10-13) exposed a typo in
      commit v3.8.0-rc1~445^2~3 (cmGeneratorTarget: Implement
      cmTargetPropertyComputer interface, 2016-10-13).  Together they broke
      the `$<TARGET_PROPERTY:mytgt,SOURCES>` generator expression in the case
      that the `SOURCES` target property is populated in part by the
      `target_sources` command.  Add the missing `;`-separator.
      
      Fixes: #17243
      068cc545
  5. Aug 29, 2017
  6. Aug 24, 2017
  7. Aug 23, 2017
    • Brad King's avatar
      Merge branch 'ninja-cl-intl' into release-3.9 · 6fd0c721
      Brad King authored
      Merge-request: !1179
      6fd0c721
    • Brad King's avatar
      Ninja: Fix support for MSVC with non-English output · de9840d1
      Brad King authored
      With MSVC the Ninja generator extracts the `cl -showIncludes` prefix.
      When MSVC is configured to have non-English output, e.g. via
      `VSLANG=2052` in the environment, then `cl` prints the prefix encoded
      for the current code page, which is not necessarily UTF-8 encoding.
      Currently we fail to convert the prefix to our internal UTF-8 encoding,
      but assume it is UTF-8 later.
      
      While writing `rules.ninja`, the Ninja generator converts our internal
      UTF-8 encoding to the current code page.  The `msvc_deps_prefix =` line
      needs to be encoded as the current code page so that `ninja` can match
      in the output from `cl -showIncludes` during the build.
      
      Prior to commit v3.9.0-rc1~47^2 (codecvt: Re-implement do_out and
      do_unshift, 2017-05-25), the non-UTF-8 prefix extracted above was
      written without noticing its incorrect internal encoding.  The
      `rules.ninja` file was successfully written, but possibly with a mangled
      `msvc_deps_prefix`.  Since that commit the output stream correctly
      rejects the non-UTF-8 byte sequence and writing `rules.ninja` fails.
      
      Fix this by correctly converting the `cl -showIncludes` output from the
      current code page to our internal UTF-8 encoding.
      
      Fixes: #17191
      de9840d1
  8. Aug 22, 2017
  9. Aug 21, 2017
  10. Aug 15, 2017
Loading