- Aug 26, 2013
-
-
Brad King authored
Ensure CMAKE_DATA_DIR, CMAKE_DOC_DIR, and CMAKE_MAN_DIR are always relative paths in CMake code, and set defaults accordingly. Use the install() command instead of install_files() and install_targets(). This is more modern and also avoids stripping of the first character from user-specified destinations. While at it, fix the default destinations reported in the bootstrap help.
-
- Aug 15, 2013
-
-
9040ec91 Do not warn about left paren not separated by a space
-
335a1278 OS X: Do not default to non-existent deployment target SDK
-
Brad King authored
Since commit 58e52416 (Warn about arguments not separated by whitespace, 2013-02-16) we warn about arguments not separated by spaces. Loosen the warning to not complain about left parens not separated by spaces from the preceding token. This is common in code like "if(NOT(X))". Teach the RunCMake.Syntax test to cover cases of left parens not separated by spaces and check that no warning appears.
-
Kitware Robot authored
-
- Aug 14, 2013
-
-
-
07c16eec Update version introducing CMP0021, CMP0022, and CMP0023
-
Brad King authored
These policies will be first released in 2.8.12.
-
d05a9bd1 Cygwin: Avoid legacy warnings in RunCMake.* tests
-
36eef302 Genex: Fix segfault when parsing ends with parameter expectation.
-
Kitware Robot authored
-
- Aug 13, 2013
-
-
Brad King authored
Set the minimum required version of CMake high enough to avoid the warning for CMAKE_LEGACY_CYGWIN_WIN32. The warning appears on stderr and breaks the expected output matching.
-
Stephen Kelly authored
The extendResult method expects a non-empty parameters vector, as assured by the normal case. Avoid calling the method when the parser finds an incomplete generator expression, but has already entered the state of expecting to find parameters.
-
Kitware Robot authored
-
- Aug 12, 2013
-
-
Kitware Robot authored
-
- Aug 11, 2013
-
-
Kitware Robot authored
-
- Aug 10, 2013
-
-
Kitware Robot authored
-
- Aug 09, 2013
-
-
b33c9844 Revert "Add compiler target compile options."
-
Stephen Kelly authored
This reverts commit 2d9ec1da.
-
Kitware Robot authored
-
- Aug 08, 2013
-
-
b93982fb Merge branch 'dev/fix-variable-watch-crash' into cmake-syntax c50f7ede cmListFileLexer: Modify flex output to avoid Borland warning bf732646 Warn about unquoted arguments that look like long brackets 58e52416 Warn about arguments not separated by whitespace e75b69f5 cmListFileCache: Convert CMake language parser to class e945949d Add RunCMake.Syntax test cases for command invocation styles 0546484e cmListFileArgument: Generalize 'Quoted' bool to 'Delimeter' enum 28685ade cmListFileLexer: Split normal and legacy unquoted arguments 1eafa3ed cmListFileLexer: Fix line number after backslash in string f3155cd6 Add RunCMake.Syntax test to cover argument parsing
-
6aa0c214 variable_watch: Add test for watching a variable multiple times b86e37c8 variable_watch: Check newValue for NULL f9bb20fe variable_watch: Don't share memory for callbacks 05dad99f variable_watch: Fix a typo in the error message 00ce12a3 variable_watch: Prevent making extra entries in the watch map 34b397e8 variable_watch: Allow specifying the data to match in RemoveWatch e43e207c variable_watch: Match client_data when finding duplicates 0d6acb1d variable_watch: Add a deleter for the client data fc7c3b4d variable_watch: Store client data as pointers
-
6f9aaad1 CTest: create one output file per memcheck (#14303)
-
cd345aa7 Skip CTestLimitDashJ test on Borland
-
-
-
ae6a5ea5 Include cmMakefile.h before cm*Lexer.h to get stdint.h first
-
8120e13f cmake-gui: Fix build rules for Qt5 on Windows
-
Brad King authored
Resolve conflict in Source/cmVariableWatchCommand.cxx by integrating the changes from both sides.
-
-
On read access, newValue can be NULL since there is no new value, so use the empty string instead.
-
The command itself is owned by the cmMakefile class, but the cmVariableWatch which holds a pointer to the cmVariableWatchCommand via the client_data for the callback outlives the cmMakefile class in the Qt GUI. This means that when the cmMakefile is destroyed, the variable watch is still in effect, but with a stale pointer. To fix this, each callback is now a separate entity completely and doesn't rely on the command which spawned it at all. An example CMakeLists.txt which demonstrates the issue (only displayed in cmake-gui, so no tests can be written for it): set(var 0) variable_watch(var) -
There was no space between "callback" and the quoted command name.
-
When removing a watch on a variable, using the operator [] on the internal map will create an empty watch if the variable doesn't have any existing watches. Rather than creating this empty structure in the map, return if there isn't a watch on the variable already.
-
Now that watches are dependent on their client_data when adding, it also makes sense to allow matching the data for removal.
-
If a callback has the same data as another call, we don't want to delete the old callback. This is because if the client_data is the same, it might get deleted causing the new client_data to be bogus. Now, AddWatch will return true if it will use the watch, false otherwise. Callers should check the return value to know whether client_data was adopted by the watch or not.
-
The client data is arbitrary and the callback may be called an unspecified number of times, so the cmVariableWatch must be the one to delete the client data in the end (if it is needed at all).
-
The STL containers create extra copies which makes keeping track of the owner of the client data much messier.
-
Brad King authored
Remove the "yyscanner = NULL" assignment from the end of the yylex_destroy function because Borland warns that the value is never used.
-
Brad King authored
In the future CMake will introduce Lua-style long bracket syntax. Warn about unquoted arguments that in the future will be treated as opening long brackets. Teach the RunCMake.Syntax test to cover such cases and ensure that the warning appears.
-
